starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Font preview in host properties is broken after 154ac2b #20800

New Issue
Closed
opened 2026-01-31 07:24:25 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 07:24:25 +00:00
Owner
Copy Link

Originally created by @alabuzhev on GitHub (Nov 12, 2023).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version

Latest source

Windows build number

10.0.19045.3448

Other Software

No response

Steps to reproduce

  1. Open the solution.
  2. Build Conhost/Host.EXE
  3. Run it.
  4. Open host properties (Alt+Space, P)
  5. Switch to Font tab
  6. Select Consolas, Courier New, Lucida Console, or any raster font.
  7. Look at the preview below.

Expected Behavior

Preview is rendered using the selected font:

okay

Actual Behavior

Preview is rendered using some fallback raster font:

not_okay

Observations

  1. Removing the built console.dll and using the system one works as expected.
  2. Some other TrueType fonts, e.g. all Cascadias and asians, are rendered as expected.
  3. Looks like it stopped working after 154ac2b916. Commenting that line fixes the issue:
diff --git a/src/propsheet/misc.cpp b/src/propsheet/misc.cpp
index 054eef961..312669f41 100644
--- a/src/propsheet/misc.cpp
+++ b/src/propsheet/misc.cpp
@@ -400,7 +400,7 @@ CreateBoldFont:
      */
     if (FontInfo[nFont].hFont != nullptr)
     {
-        DeleteObject(FontInfo[nFont].hFont);
+        //DeleteObject(FontInfo[nFont].hFont);
     }
     FontInfo[nFont].hFont = hFont;
     FontInfo[nFont].Family = tmFamily;

Apparently the font object is still used at this point and should be deleted later?

Originally created by @alabuzhev on GitHub (Nov 12, 2023). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version Latest source ### Windows build number 10.0.19045.3448 ### Other Software _No response_ ### Steps to reproduce 1. Open the solution. 2. Build Conhost/Host.EXE 3. Run it. 4. Open host properties (Alt+Space, P) 5. Switch to Font tab 6. Select Consolas, Courier New, Lucida Console, or any raster font. 7. Look at the preview below. ### Expected Behavior Preview is rendered using the selected font: ![okay](https://github.com/microsoft/terminal/assets/11453922/edb195d4-4003-4b36-91ac-9a0d85242f50) ### Actual Behavior Preview is rendered using some fallback raster font: ![not_okay](https://github.com/microsoft/terminal/assets/11453922/697e08c9-925b-4a1c-878d-058a9fe9ed8d) ----- ### Observations 1. Removing the built console.dll and using the system one works as expected. 2. Some other TrueType fonts, e.g. all Cascadias and asians, are rendered as expected. 3. Looks like it stopped working after 154ac2b9160177c079f1a93436a0b6240761c5a2. Commenting that line fixes the issue: ```DIFF diff --git a/src/propsheet/misc.cpp b/src/propsheet/misc.cpp index 054eef961..312669f41 100644 --- a/src/propsheet/misc.cpp +++ b/src/propsheet/misc.cpp @@ -400,7 +400,7 @@ CreateBoldFont: */ if (FontInfo[nFont].hFont != nullptr) { - DeleteObject(FontInfo[nFont].hFont); + //DeleteObject(FontInfo[nFont].hFont); } FontInfo[nFont].hFont = hFont; FontInfo[nFont].Family = tmFamily; ``` Apparently the font object is still used at this point and should be deleted later?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Fonts In-PR Issue-Bug Needs-Tag-Fix Product-Conhost Severity-Blocking zInbox-Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20800
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?