starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Search box doesn't pick up the newly selected text from the buffer #20868

New Issue
Closed
opened 2026-01-31 07:26:23 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 07:26:23 +00:00
Owner
Copy Link

Originally created by @tusharsnx on GitHub (Nov 22, 2023).

Windows Terminal version

1.19.3172.0

Windows build number

10.0.22631.0

Other Software

No response

Steps to reproduce

  1. Select a piece of text in the terminal
  2. Trigger Search Action.
  3. The search criteria (needle) is now the selected text.
  4. Close SearchBox
  5. Select a different piece of text.
  6. Trigger Search Action.
  7. The search criteria is still the old one.

Expected Behavior

At step 7, needle should be the newly selected text, instead of the old one.

Actual Behavior

At step 7, needle is still the previously selected text.

Originally created by @tusharsnx on GitHub (Nov 22, 2023). ### Windows Terminal version 1.19.3172.0 ### Windows build number 10.0.22631.0 ### Other Software _No response_ ### Steps to reproduce 1. Select a piece of text in the terminal 2. Trigger Search Action. 3. The search criteria (`needle`) is now the selected text. 4. Close SearchBox 5. Select a different piece of text. 6. Trigger Search Action. 7. The search criteria is still the old one. ### Expected Behavior At step 7, `needle` should be the newly selected text, instead of the old one. ### Actual Behavior At step 7, `needle` is still the previously selected text.
claunia commented 2026-01-31 07:26:25 +00:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Nov 22, 2023):

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@github-actions[bot] commented on GitHub (Nov 22, 2023): Hi I'm an AI powered bot that finds similar issues based off the issue title. Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you! ### Closed similar issues: - [Selected text should populate search box (#8307)](https://github.com/microsoft/terminal/issues/8307), similarity score: 0.83 > Note: You can give me feedback by thumbs upping or thumbs downing this comment.
claunia commented 2026-01-31 07:26:25 +00:00
Author
Owner
Copy Link

@tusharsnx commented on GitHub (Nov 22, 2023):

Regressed in #0cbde

It's a combination of these codes that creates the race condition. The VisibilityChanged event overwrites _selection before we can read the newly selected text using it.

63b3820a18/src/cascadia/TerminalControl/SearchBoxControl.cpp (L22-L32)

It may not be obvious but, if we look at the TermControl::CreateSearchBoxControl code, it fires two events when a selection is active.

63b3820a18/src/cascadia/TerminalControl/TermControl.cpp (L404-L433)

Once, when we change the visibility, and second when we populate the text box with the selected text. Both calls But by the time we call _core.SelectedText(), the visibility event handler has already overwritten CoreControl::_selection, and it now shows that the previous highlighted match is being selected 🫤

Trace:

  1. We still haven't populated the search box with the currently selected text, and we called _searchBox->Visibility(Visibility::Visible):
    VisibilityChanged -> SearchBoxControl::_SearchChangedHandlers() -> TermControl::_SearchChanged() -> Get the lock on Terminal -> ControlCore::Search() -> _searcher.SelectCurrent(). The selection now highlights previously selected text.

  2. Now when we call _searchBox->_core.SelectedText(true), we receive the previously selected text and populate the search box with this stale text. After this, SearchBoxControl::_SearchChangedHandlers() is invoked by the SearchBoxControl::TextBoxTextChanged handler like normally it would, but unfortunately, the needle isn't correct.

@tusharsnx commented on GitHub (Nov 22, 2023): Regressed in [#0cbde](https://github.com/microsoft/terminal/commit/0cbde94e4b2e530eac00acc7de1808fe2fd10273) It's a combination of these codes that creates the race condition. The VisibilityChanged event overwrites `_selection` before we can read the newly selected text using it. https://github.com/microsoft/terminal/blob/63b3820a18be096a4b1950e335c9605267440734/src/cascadia/TerminalControl/SearchBoxControl.cpp#L22-L32 It may not be obvious but, if we look at the `TermControl::CreateSearchBoxControl` code, it fires two events when a selection is active. https://github.com/microsoft/terminal/blob/63b3820a18be096a4b1950e335c9605267440734/src/cascadia/TerminalControl/TermControl.cpp#L404-L433 Once, when we change the visibility, and second when we populate the text box with the selected text. Both calls But by the time we call `_core.SelectedText()`, the visibility event handler has already overwritten `CoreControl::_selection`, and it now shows that the previous highlighted match is being selected 🫤 Trace: 1. We still haven't populated the search box with the currently selected text, and we called `_searchBox->Visibility(Visibility::Visible)`: VisibilityChanged -> `SearchBoxControl::_SearchChangedHandlers()` -> `TermControl::_SearchChanged()` -> Get the lock on `Terminal` -> `ControlCore::Search()` -> `_searcher.SelectCurrent()`. The selection now highlights previously selected text. 2. Now when we call `_searchBox->_core.SelectedText(true)`, we receive the previously selected text and populate the search box with this stale text. After this, `SearchBoxControl::_SearchChangedHandlers()` is invoked by the `SearchBoxControl::TextBoxTextChanged` handler like normally it would, but unfortunately, the needle isn't correct.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface In-PR Issue-Bug Needs-Tag-Fix Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20868
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?