starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

conhost does not close the first time after clicking close / after all clients disconnect #20966

New Issue
Closed
opened 2026-01-31 07:29:12 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 07:29:12 +00:00
Owner
Copy Link

Originally created by @lhecker on GitHub (Dec 8, 2023).

If you encounter this, please capture a dump of the affected conhost.exe!

Windows Terminal version

20dad62

Windows build number

10.0.22635.0

Other Software

pwsh 7.4.0

Steps to reproduce

Repro steps are as of yet unknown. It only happened twice to me in >1 month.

Expected Behavior

When clicking the close button (the X button), conhost will send a CTRL_CLOSE_EVENT to all connected clients. Once all clients have disconnected, it'll RundownAndExit (= quit).

Actual Behavior

The window does not close, but clicking the close button a second time works.

Investigation, thought process:

  • First of all, the CTRL_CLOSE_EVENT part works, because I was able to observe that my affected conhost.exe had no parent pwsh.exe process anymore.
  • Next, the exit point of conhost is ServiceLocator::RundownAndExit. That function was not called on the first click, because the 2nd click on the close button does work and ServiceLocator::RundownAndExit only ever allows 1 single call to progress (see the locked atomic within it).
  • This further implies that the server pipe is still alive, because if it wasn't, then the Console IO thread would've immediately called ServiceLocator::RundownAndExit once it gets a ERROR_PIPE_NOT_CONNECTED. That would've otherwise made the 2nd click on the close button not work.

--> Most likely cause: Something is holding onto the server pipe and not releasing it.

Originally created by @lhecker on GitHub (Dec 8, 2023). ## If you encounter this, please capture a dump of the affected conhost.exe! --- ### Windows Terminal version 20dad62 ### Windows build number 10.0.22635.0 ### Other Software pwsh 7.4.0 ### Steps to reproduce Repro steps are as of yet unknown. It only happened twice to me in >1 month. ### Expected Behavior When clicking the close button (the X button), conhost will send a `CTRL_CLOSE_EVENT` to all connected clients. Once all clients have disconnected, it'll `RundownAndExit` (= quit). ### Actual Behavior The window does not close, but clicking the close button a second time works. Investigation, thought process: * First of all, the `CTRL_CLOSE_EVENT` part works, because I was able to observe that my affected conhost.exe had no parent pwsh.exe process anymore. * Next, the exit point of conhost is `ServiceLocator::RundownAndExit`. That function was not called on the first click, because the 2nd click on the close button does work and `ServiceLocator::RundownAndExit` only ever allows 1 single call to progress (see the `locked` atomic within it). * This further implies that the server pipe is still alive, because if it wasn't, then the Console IO thread would've immediately called `ServiceLocator::RundownAndExit` once it gets a `ERROR_PIPE_NOT_CONNECTED`. That would've otherwise made the 2nd click on the close button not work. --> Most likely cause: Something is holding onto the server pipe and not releasing it.
claunia commented 2026-01-31 07:29:14 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Dec 8, 2023):

@DHowett galaxy-brained me just now (again): Running code inside a console will hold a \Reference handle to the console without ever releasing it. --> Closing the conhost window while VS Code is still open will thus keep the server alive, requiring two close button clicks (because the 2nd one sort of forces it).
I was told this before, but I sort of never actually tried this out myself and so never connected the dots. 😅 Sorry y'all.

@lhecker commented on GitHub (Dec 8, 2023): @DHowett galaxy-brained me just now (again): Running `code` inside a console will hold a \Reference handle to the console without ever releasing it. --> Closing the conhost window while VS Code is still open will thus keep the server alive, requiring two close button clicks (because the 2nd one sort of forces it). I was told this before, but I sort of never actually tried this out myself and so never connected the dots. 😅 Sorry y'all.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Repro Needs-Triage Priority-1 Product-Conhost Resolution-External
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20966
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?