starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Comment] Invalid URL #20967

New Issue
Closed
opened 2026-01-31 07:29:14 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 07:29:14 +00:00
Owner
Copy Link

Originally created by @JeremieBergeron on GitHub (Dec 7, 2023).

The link at the line 591 of src/renderer/gdi/state.cpp redirect to an error page.

It would be appreciated if it could be updated to the right link.

20dad62471/src/renderer/gdi/state.cpp (L588-L593)

Originally created by @JeremieBergeron on GitHub (Dec 7, 2023). The [link at the line 591 of src/renderer/gdi/state.cpp](https://github.com/microsoft/terminal/blob/20dad624710249f3a4ee77c47a58d4ca367a820b/src/renderer/gdi/state.cpp#L591 ) redirect to an error page. It would be appreciated if it could be updated to the right link. https://github.com/microsoft/terminal/blob/20dad624710249f3a4ee77c47a58d4ca367a820b/src/renderer/gdi/state.cpp#L588-L593
claunia added the In-PRIssue-DocsProduct-MetaArea-CodeHealth labels 2026-01-31 07:29:14 +00:00
claunia commented 2026-01-31 07:29:15 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 11, 2023):

As a note, that LOC goes back to the original open-source release of the Terminal. That link is probably super old - I sure have no memory of what article that may have pointed to in the first place

@zadjii-msft commented on GitHub (Dec 11, 2023): As a note, that LOC goes back to the original open-source release of the Terminal. That link is probably super old - I sure have no memory of what article that may have pointed to in the first place
claunia commented 2026-01-31 07:29:15 +00:00
Author
Owner
Copy Link

@AvishekDas5 commented on GitHub (Sep 23, 2025):

Hi! I noticed this issue and fixed the broken MSDN link.
The original link redirected to a removed article which I found here and now republished here.

I’ve opened a PR #19372 that updates the link to the correct Microsoft Learn page.

@AvishekDas5 commented on GitHub (Sep 23, 2025): Hi! I noticed this issue and fixed the broken MSDN link. The original link redirected to a removed article which I found [here](https://mskb.pkisolutions.com/kb/94646) and now republished [here](https://learn.microsoft.com/en-us/windows/win32/gdi/character-widths). I’ve opened a PR #19372 that updates the link to the correct Microsoft Learn page.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth In-PR Issue-Docs Product-Meta
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20967
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?