Feature Request - Duplicate tab (Basic) #2097

@carlos-zamora commented on GitHub (Jun 25, 2019):

@dnagl Yup! We're on the same page. And we can't do the flyout menu until #760 gets resolved anyways.

I'd very much appreciate it if you implement this. 😊 Let me know if you have any questions! (and definitely add me as a reviewer so I get a notification when it comes in)

@carlos-zamora commented on GitHub (Jun 25, 2019): @dnagl Yup! We're on the same page. And we can't do the flyout menu until #760 gets resolved anyways. I'd very much appreciate it if you implement this. 😊 Let me know if you have any questions! (and definitely add me as a reviewer so I get a notification when it comes in)

claunia commented

@xmm1989218 commented on GitHub (Jun 25, 2019):

@carlos-zamora "Simple" + custom shortcut is good enough
@J00MZ if has the "Simple" way, can use commandline in profile.json to implement FAKE "Full State Copy",

"commandline" : "wsl.exe -d Legacy -- /path_to/ssh_script",

@xmm1989218 commented on GitHub (Jun 25, 2019): @carlos-zamora "Simple" + custom shortcut is good enough @J00MZ if has the "Simple" way, can use commandline in profile.json to implement FAKE "Full State Copy", "commandline" : "wsl.exe -d Legacy -- /path_to/ssh_script",

claunia commented

@J00MZ commented on GitHub (Jun 25, 2019):

@xmm1989218 I've used the command line in profile.json for similar stuff, such as defaulting to a specific directory which has my custom .bashrc, but I'd classify it as a "hack", not feature.

@J00MZ commented on GitHub (Jun 25, 2019): @xmm1989218 I've used the command line in profile.json for similar stuff, such as defaulting to a specific directory which has my custom .bashrc, but I'd classify it as a "hack", not feature.

claunia commented

@xmm1989218 commented on GitHub (Jun 25, 2019):

@J00MZ your right. it is hack. if has many ssh-host will seem ugly. it just works at light startup job

@xmm1989218 commented on GitHub (Jun 25, 2019): @J00MZ your right. it is hack. if has many ssh-host will seem ugly. it just works at light startup job

claunia commented

@dnagl commented on GitHub (Jun 26, 2019):

@carlos-zamora I have some problems to get the keybindings to work properly. Maybe you could have a look at the code in my repository and the last commit on the featurebranch. When I am pressing CTRL+SHIFT+D the method AppKeyBindings::TryKeyChord gets called but there is no element in _keyShortcuts for the keybinding

Repository

Edit

I fixed the problem. I was adding the keybinding in the wrong profiles.json file

@dnagl commented on GitHub (Jun 26, 2019): @carlos-zamora I have some problems to get the keybindings to work properly. Maybe you could have a look at the code in my repository and the last commit on the featurebranch. When I am pressing CTRL+SHIFT+D the method `AppKeyBindings::TryKeyChord` gets called but there is no element in `_keyShortcuts` for the keybinding [Repository](https://github.com/dnagl/terminal/tree/1536-duplicate-tab) ### Edit > I fixed the problem. I was adding the keybinding in the wrong `profiles.json` file

claunia commented

@mdtauk commented on GitHub (Jun 26, 2019):

Would a duplicate Tab maintain the same history and current output?

@mdtauk commented on GitHub (Jun 26, 2019): Would a duplicate Tab maintain the same history and current output?

claunia commented

@J00MZ commented on GitHub (Jun 26, 2019):

@mdtauk see @carlos-zamora reply re the options this could be implemented.

@J00MZ commented on GitHub (Jun 26, 2019): @mdtauk see @carlos-zamora reply re the options this could be implemented.

claunia commented

@dnagl commented on GitHub (Jun 27, 2019):

@carlos-zamora I cannot add you as a reviewer to the pull request. Am I missing some permissions for this action?

@dnagl commented on GitHub (Jun 27, 2019): @carlos-zamora I cannot add you as a reviewer to the pull request. Am I missing some permissions for this action?

claunia commented

@carlos-zamora commented on GitHub (Jun 27, 2019):

Huh. I guess you do need permissions for that. Found it though. I'll try and get to it tomorrow. Thanks!

@carlos-zamora commented on GitHub (Jun 27, 2019): Huh. I guess you do need permissions for that. Found it though. I'll try and get to it tomorrow. Thanks!

claunia commented

@ghost commented on GitHub (Aug 3, 2019):

:tada:This issue was addressed in #1685, which has now been successfully released as Windows Terminal Preview v0.3.2142.0.🎉

Handy links:

@ghost commented on GitHub (Aug 3, 2019): :tada:This issue was addressed in #1685, which has now been successfully released as `Windows Terminal Preview v0.3.2142.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.3.2142.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)

claunia commented

@CoskunSunali commented on GitHub (Aug 7, 2019):

It seems that new tab and duplicate tab features work the same way for me when I use it for WSL. E.g. they both create a new tab and nothing else.

I SSHed into a server using Ubuntu, duplicated the tab, SSH session is not carried over. I switched to a directory and duplicated the tab, the directory was set to the default startingDirectory which is //wsl$/Ubuntu/home/coskun.

So why would I use the duplicate feature? No pun intended, just trying to understand what is the advantage of using the duplicate feature over creating a new tab.

@CoskunSunali commented on GitHub (Aug 7, 2019): It seems that new tab and duplicate tab features work the same way for me when I use it for WSL. E.g. they both create a new tab and nothing else. I SSHed into a server using Ubuntu, duplicated the tab, SSH session is not carried over. I switched to a directory and duplicated the tab, the directory was set to the default `startingDirectory` which is `//wsl$/Ubuntu/home/coskun`. So why would I use the duplicate feature? No pun intended, just trying to understand what is the advantage of using the duplicate feature over creating a new tab.

claunia commented

@J00MZ commented on GitHub (Aug 7, 2019):

@CoskunSunali
The duplicate tab feature defaults to the profile you are using now.
Opening a new tab defaults to your default profile.

If you use various different profiles in Terminal, it's very convenient to duplicate your current working one rather than the default one.

For example, my default profile is Ubuntu 18 WSL, but I may want to duplicate my Powershell or Ubuntu 16 WSL tabs.

@J00MZ commented on GitHub (Aug 7, 2019): @CoskunSunali The duplicate tab feature defaults to the profile you are using now. Opening a new tab defaults to your default profile. If you use various different profiles in Terminal, it's very convenient to duplicate your current working one rather than the default one. For example, my default profile is Ubuntu 18 WSL, but I may want to duplicate my Powershell or Ubuntu 16 WSL tabs. ![image](https://user-images.githubusercontent.com/3058176/62620773-d2501100-b922-11e9-8646-443eb73b7511.png)

claunia commented

@CoskunSunali commented on GitHub (Aug 7, 2019):

@J00MZ That totally makes sense. Thank you for the insights.

@CoskunSunali commented on GitHub (Aug 7, 2019): @J00MZ That totally makes sense. Thank you for the insights.

claunia commented

@CoskunSunali commented on GitHub (Aug 7, 2019):

Sorry for the spam. Are there any plans for implementing state duplication? E.g. carrying over the SSH session?

@CoskunSunali commented on GitHub (Aug 7, 2019): Sorry for the spam. Are there any plans for implementing state duplication? E.g. carrying over the SSH session?

claunia commented

@zadjii-msft commented on GitHub (Aug 7, 2019):

@CoskunSunali No, because that would likely be neigh impossible to do in a general sense. How would we duplicate an instance of vim for example? What if the foreground process has opened some sort of file for exclusive access - how could we duplicate that process?

If there's a way this can be done safely and generally I'm all ears for proposed technical solutions, but I don't think it's something that's possible, so I'm not going to be investigating it.

@zadjii-msft commented on GitHub (Aug 7, 2019): @CoskunSunali No, because that would likely be neigh impossible to do in a general sense. How would we duplicate an instance of vim for example? What if the foreground process has opened some sort of file for exclusive access - how could we duplicate that process? If there's a way this can be done safely and generally I'm all ears for proposed technical solutions, but I don't think it's something that's possible, so I'm not going to be investigating it.

claunia commented