starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

WindowsTerminal.exe leak (never exit) after the wtd.exe new-tab ... command line process exits. #20982

New Issue
Closed
opened 2026-01-31 07:29:40 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 07:29:40 +00:00
Owner
Copy Link

Originally created by @ShenHongFei on GitHub (Dec 12, 2023).

Windows Terminal version

latest commit of main branch

Windows build number

10.0.22631.0

Other Software

No response

Steps to reproduce

Execute the following command on the command line:

wtd.exe new-tab ping.exe localhost

Expected Behavior

There is only one WindowsTerminal.exe process after the ping command ends

Actual Behavior

Each time the above command is executed, there will be one more WindowsTerminal.exe process.

I debugged the redundant WindowsTerminal.exe process and found that it was stuck on the line highlighted in the picture below.
D:\1\winterm\packages\Microsoft.Windows.ImplementationLibrary.1.0.230824.2\include\wil\filesystem.h

image

I guessed it might be related to Microsoft.Windows.ImplementationLibrary, and then revert this PR https://github.com/microsoft/terminal/pull/16120
After recompiling and building, the problem disappeared and there were no redundant leaking processes.

Originally created by @ShenHongFei on GitHub (Dec 12, 2023). ### Windows Terminal version latest commit of main branch ### Windows build number 10.0.22631.0 ### Other Software _No response_ ### Steps to reproduce Execute the following command on the command line: ``` wtd.exe new-tab ping.exe localhost ``` ### Expected Behavior There is only one WindowsTerminal.exe process after the ping command ends ### Actual Behavior Each time the above command is executed, there will be one more WindowsTerminal.exe process. I debugged the redundant WindowsTerminal.exe process and found that it was stuck on the line highlighted in the picture below. `D:\1\winterm\packages\Microsoft.Windows.ImplementationLibrary.1.0.230824.2\include\wil\filesystem.h` ![image](https://github.com/microsoft/terminal/assets/15074472/ffed717b-3d10-466c-83cd-ede1950cbdfd) I guessed it might be related to `Microsoft.Windows.ImplementationLibrary`, and then revert this PR https://github.com/microsoft/terminal/pull/16120 After recompiling and building, the problem disappeared and there were no redundant leaking processes.
claunia commented 2026-01-31 07:29:42 +00:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Dec 12, 2023):

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@github-actions[bot] commented on GitHub (Dec 12, 2023): Hi I'm an AI powered bot that finds similar issues based off the issue title. Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you! ### Closed similar issues: - [Closing last tab crashes WindowsTerminal.exe (#1552)](https://github.com/microsoft/terminal/issues/1552), similarity score: 0.81 > Note: You can give me feedback by thumbs upping or thumbs downing this comment.
claunia commented 2026-01-31 07:29:42 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 12, 2023):

Thanks for filing this!

I noticed this a few weeks back and totally forgot to file or investigate it. I'm guessing we're starting up the settings file watcher as we do the handoff to the monarch, but then never closing.

@zadjii-msft commented on GitHub (Dec 12, 2023): Thanks for filing this! I noticed this a few weeks back and totally forgot to file or investigate it. I'm guessing we're starting up the settings file watcher as we do the handoff to the monarch, but then never closing.
claunia commented 2026-01-31 07:29:42 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Dec 12, 2023):

Oh, @zadjii-msft, this is the one that was caused by https://github.com/microsoft/wil/pull/326.

It may have been fixed in https://github.com/microsoft/wil/pull/386

Which we should ingest!

@DHowett commented on GitHub (Dec 12, 2023): Oh, @zadjii-msft, this is the one that was caused by https://github.com/microsoft/wil/pull/326. It may have been fixed in https://github.com/microsoft/wil/pull/386 Which we should ingest!
claunia commented 2026-01-31 07:29:42 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Dec 12, 2023):

(it hasn't been shipped to the nuget feed yet)

@DHowett commented on GitHub (Dec 12, 2023): (it hasn't been shipped to the nuget feed yet)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Remoting Area-Windowing In-PR Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20982
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?