starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

VtEngine: Console-style (undelayed) line wraps results in \r\n #20988

New Issue
Closed
opened 2026-01-31 07:29:51 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 07:29:51 +00:00
Owner
Copy Link

Originally created by @lhecker on GitHub (Dec 13, 2023).

Windows Terminal version

1.16.230126001

Windows build number

No response

Other Software

No response

Steps to reproduce

  • Use cmd.exe
  • Scroll at least 1 viewport down (hold Enter or Ctrl+C, etc.)
  • Type text until it line wraps
  • Copy the prompt to your clipboard

Expected Behavior

Clipboard contains 1 line of text without line wraps.

Actual Behavior

The clipboard is line wrapped at the right margin.

XtermEngine::_MoveCursor is called 3 times during the forced line wrap. When I type a single "a" at the end of the prompt, this results in 3 cursor movement sequences in total and the character being printed twice:

a\r\n\x1b[23;80Ha\r\n

I'm setting this to P2 because this bug has probably existed since the beginning. There might be a duplicate already.

Originally created by @lhecker on GitHub (Dec 13, 2023). ### Windows Terminal version 1.16.230126001 ### Windows build number _No response_ ### Other Software _No response_ ### Steps to reproduce * Use cmd.exe * Scroll at least 1 viewport down (hold Enter or Ctrl+C, etc.) * Type text until it line wraps * Copy the prompt to your clipboard ### Expected Behavior Clipboard contains 1 line of text without line wraps. ### Actual Behavior The clipboard is line wrapped at the right margin. `XtermEngine::_MoveCursor` is called 3 times during the forced line wrap. When I type a single "a" at the end of the prompt, this results in 3 cursor movement sequences in total and the character being printed twice: ``` a\r\n\x1b[23;80Ha\r\n ``` I'm setting this to P2 because this bug has probably existed since the beginning. There might be a duplicate already.
claunia commented 2026-01-31 07:29:53 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Dec 13, 2023):

I suspect that this may actually have "worked" in the past, because of the exact-wrap bug (#3088). If your output has wrapped in a legacy console app, that would assumedly mean you had written something in the last column of the line. And if I remember correctly, that used to be enough for the resize algorithm to consider the line as being wrapped. I'm not sure about copy-to-clipboard though.

As for fixing it, I didn't think there was an easy way to reproduce legacy-style wrapping on a VT terminal. To trigger a wrap, you've got to write something past the end end of the line, which potentially means you're overwriting whatever is on the next line. In our current conpty implementation we could at least lookup the character on the next line, and write that out, but that seems horribly hacky, and would never work in a full pass-through mode.

I don't know if maybe you have a better plan than that.

@j4james commented on GitHub (Dec 13, 2023): I suspect that this may actually have "worked" in the past, because of the exact-wrap bug (#3088). If your output has wrapped in a legacy console app, that would assumedly mean you had written something in the last column of the line. And if I remember correctly, that used to be enough for the resize algorithm to consider the line as being wrapped. I'm not sure about copy-to-clipboard though. As for fixing it, I didn't think there was an easy way to reproduce legacy-style wrapping on a VT terminal. To trigger a wrap, you've got to write something _past_ the end end of the line, which potentially means you're overwriting whatever is on the next line. In our current conpty implementation we could at least lookup the character on the next line, and write that out, but that seems horribly hacky, and would never work in a full pass-through mode. I don't know if maybe you have a better plan than that.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering In-PR Issue-Bug Needs-Tag-Fix Priority-2 Product-Conpty
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#20988
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?