starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Line height input format didn't follow system locale #21016

New Issue
Closed
opened 2026-01-31 07:30:41 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 07:30:41 +00:00
Owner
Copy Link

Originally created by @wicaksono on GitHub (Dec 27, 2023).

Windows Terminal version

1.18.3181.0

Windows build number

10.0.22631.2861

Other Software

No response

Steps to reproduce

Open Terminal, go to Settings > Default > Appearance > Line height

Expected Behavior

Decimal digit will separated by system locale (in my case is comma) and able to click up and down arrow.

Actual Behavior

On my locale, the digits is separated by comma, but terminal is ignoring it and using dot. This is also makes me unable to click up and down arrow next to it.

Originally created by @wicaksono on GitHub (Dec 27, 2023). ### Windows Terminal version 1.18.3181.0 ### Windows build number 10.0.22631.2861 ### Other Software _No response_ ### Steps to reproduce Open Terminal, go to Settings > Default > Appearance > Line height ### Expected Behavior Decimal digit will separated by system locale (in my case is comma) and able to click up and down arrow. ### Actual Behavior On my locale, the digits is separated by comma, but terminal is ignoring it and using dot. This is also makes me unable to click up and down arrow next to it.
claunia commented 2026-01-31 07:30:44 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 3, 2024):

Yep, we should fix that. Thanks!

@zadjii-msft commented on GitHub (Jan 3, 2024): Yep, we should fix that. Thanks!
claunia commented 2026-01-31 07:30:45 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jan 8, 2024):

I was intending to change that input field to use a CSS line-height string so that it supports explicit "px" and "pt" suffixes. I wonder if it would be necessary to add an explicit unit selector as a GUI element... 🤔

@lhecker commented on GitHub (Jan 8, 2024): I was intending to change that input field to use a CSS line-height string so that it supports explicit "px" and "pt" suffixes. I wonder if it would be necessary to add an explicit unit selector as a GUI element... 🤔
claunia commented 2026-01-31 07:30:45 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (May 17, 2024):

Oh I see now. The problem is that you're mistaking the placeholder string as a value. If you just type any number into the field you can use up/down perfectly fine:
image

@lhecker commented on GitHub (May 17, 2024): Oh I see now. The problem is that you're mistaking the placeholder string as a value. If you just type any number into the field you can use up/down perfectly fine: ![image](https://github.com/microsoft/terminal/assets/2256941/fc41e277-16ab-4f0a-ac5e-54a2c9feffe1)
claunia commented 2026-01-31 07:30:45 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (May 17, 2024):

Frankly, I don't know how to fix this. NumberBox is hardcoded to disable the up/down buttons if the value is NaN (= no value): 326f5a684b/controls/dev/NumberBox/NumberBox.cpp (L665-L694)
We could change the template, but I'm not sure whether that's worth it.

@lhecker commented on GitHub (May 17, 2024): Frankly, I don't know how to fix this. `NumberBox` is hardcoded to disable the up/down buttons if the value is NaN (= no value): https://github.com/microsoft/microsoft-ui-xaml/blob/326f5a684bd765db6d7c939e971486810381688d/controls/dev/NumberBox/NumberBox.cpp#L665-L694 We could change the template, but I'm not sure whether that's worth it.
claunia commented 2026-01-31 07:30:45 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 22, 2024):

I suspect that it's not worth it to fix this as-is. Please feel to reopen it (or comment!) if you disagree.

@DHowett commented on GitHub (Aug 22, 2024): I suspect that it's not worth it to fix this as-is. Please feel to reopen it (or comment!) if you disagree.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Help Wanted Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21016
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?