starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add support for more DSR queries #21041

New Issue
Closed
opened 2026-01-31 07:31:27 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 07:31:27 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Jan 2, 2024).

Description of the new feature/enhancement

One of the things we need to do to meet level 2 conformance requirements is to add support for more DSR queries. As a minimum, I think we need these three:

  • User-Defined Key Status: Although UDKs are an optional extension, the standard says that a level 2 device is still required to respond to the DSR query to indicate that it doesn't support the extension if that is the case.
  • Printer Status: Again this is an optional extension, and although it's not specifically mentioned in the standard, it also seems like a good idea to support the DSR query indicating the lack of support (reporting no printer connected).
  • Keyboard Status: This seems to have been left out of the DEC standards manual, but every level 2+ device supports it, and it's not an extension as far as I know, so I think it's something we probably should be reporting.

And while those are the ones that I think are essential, it would also be nice to do some of the other DSR queries at the same time. They're all essentially static responses, so it's not a lot of extra effort.

  • Locator Status and Identify: I'd like to add locator support at some point in the future (this is essentially DEC's mouse protocol), but for now we can respond to these queries with a status indicating that the device is not connected.
  • Data Integrity: Much like the operating status report, we can just respond to this with a hardcoded status indicating that everything is good (which I suspect is what everyone else does).
  • Multiple Session Status: This is an optional extension that we'll likely never support, but again I think it's worth responding to the DSR query to indicate that we don't support it.

Proposed technical implementation details (optional)

My plan was to replace the existing _OperatingStatus method with a generic _DeviceStatusReport method that takes a parameter with the status string. All of the above reports use simple DSR responses of the form \033[{}n, so it'd be overkill to have separate methods for each of them.

Originally created by @j4james on GitHub (Jan 2, 2024). # Description of the new feature/enhancement One of the things we need to do to meet level 2 conformance requirements is to add support for more `DSR` queries. As a minimum, I think we need these three: * **User-Defined Key Status**: Although UDKs are an optional extension, the standard says that a level 2 device is still required to respond to the `DSR` query to indicate that it doesn't support the extension if that is the case. * **Printer Status**: Again this is an optional extension, and although it's not specifically mentioned in the standard, it also seems like a good idea to support the `DSR` query indicating the lack of support (reporting no printer connected). * **Keyboard Status**: This seems to have been left out of the DEC standards manual, but every level 2+ device supports it, and it's not an extension as far as I know, so I think it's something we probably should be reporting. And while those are the ones that I think are essential, it would also be nice to do some of the other `DSR` queries at the same time. They're all essentially static responses, so it's not a lot of extra effort. * **Locator Status and Identify**: I'd like to add locator support at some point in the future (this is essentially DEC's mouse protocol), but for now we can respond to these queries with a status indicating that the device is not connected. * **Data Integrity**: Much like the operating status report, we can just respond to this with a hardcoded status indicating that everything is good (which I suspect is what everyone else does). * **Multiple Session Status**: This is an optional extension that we'll likely never support, but again I think it's worth responding to the `DSR` query to indicate that we don't support it. # Proposed technical implementation details (optional) My plan was to replace the existing [`_OperatingStatus`](https://github.com/microsoft/terminal/blob/63c3573a13cc96bfa3d655f0f1898ae250e2fe35/src/terminal/adapter/adaptDispatch.cpp#L1617) method with a generic `_DeviceStatusReport` method that takes a parameter with the status string. All of the above reports use simple `DSR` responses of the form `\033[{}n`, so it'd be overkill to have separate methods for each of them.
claunia added the Help WantedProduct-ConhostIssue-TaskIn-PRArea-VT labels 2026-01-31 07:31:27 +00:00
claunia commented 2026-01-31 07:31:28 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 3, 2024):

we really need a bot rule that's just "Oh j4james filed this? mark as task, VT, conhost, and yank triage" 😄

@zadjii-msft commented on GitHub (Jan 3, 2024): _we really need a bot rule that's just "Oh j4james filed this? mark as task, VT, conhost, and yank triage"_ 😄
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Help Wanted In-PR Issue-Task Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21041
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?