starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

why is the overline so much less thick than the underlines? #21056

New Issue
Closed
opened 2026-01-31 07:31:53 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 07:31:53 +00:00
Owner
Copy Link

Originally created by @ClaireCJS on GitHub (Jan 6, 2024).

Windows Terminal version

1.18.3181.0

Windows build number

10.0.19045.3803

Other Software

TCC 29.00.17 x64

Steps to reproduce

Overline and underline things at the same time.
image

Expected Behavior

The lines to be the same thickness

Actual Behavior

The underlines are thicker than the overlines. To the extent that at certain font sizes & colors (i.e. small & purple), you can see one, but not see the other, even though both are there.

image

Originally created by @ClaireCJS on GitHub (Jan 6, 2024). ### Windows Terminal version 1.18.3181.0 ### Windows build number 10.0.19045.3803 ### Other Software TCC 29.00.17 x64 ### Steps to reproduce Overline and underline things at the same time. ![image](https://github.com/microsoft/terminal/assets/789591/c31c7296-25b8-43f1-92ac-999a685042e1) ### Expected Behavior The lines to be the same thickness ### Actual Behavior The underlines are thicker than the overlines. To the extent that at certain font sizes & colors (i.e. small & purple), you can see one, but not see the other, even though both are there. ![image](https://github.com/microsoft/terminal/assets/789591/799bd06a-d4c1-4b17-af93-407213cad1ed)
claunia added the Needs-TriageIssue-Bug labels 2026-01-31 07:31:53 +00:00
claunia commented 2026-01-31 07:31:54 +00:00
Author
Owner
Copy Link

@ClaireCJS commented on GitHub (Jan 6, 2024):

Please forgive me for the pettiest bug report of all time. This just seriously bugs me.

@ClaireCJS commented on GitHub (Jan 6, 2024): Please forgive me for the pettiest bug report of all time. This just seriously bugs me.
claunia commented 2026-01-31 07:31:55 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jan 6, 2024):

This is intentional. They're two separate concepts. The underline style is a feature of the font, so its width will vary depending on what font you're using. The overline is just one of the "grid lines" that border all sides of the cell. Traditionally those lines have always been a single pixel, so we've tried to remain reasonably compatible with that usage. It does now scale if you're using a high DPI display or a large font size, but it isn't expected to match the underline width.

@j4james commented on GitHub (Jan 6, 2024): This is intentional. They're two separate concepts. The underline style is a feature of the font, so its width will vary depending on what font you're using. The overline is just one of the "grid lines" that border all sides of the cell. Traditionally those lines have always been a single pixel, so we've tried to remain reasonably compatible with that usage. It does now scale if you're using a high DPI display or a large font size, but it isn't expected to match the underline width.
claunia commented 2026-01-31 07:31:55 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jan 6, 2024):

That said, you could argue that maybe the base size of these grid lines should be wider (I think it's currently 0.025em), but we need to be careful that we're not breaking backwards compatibility with the original single pixel expectation. Grid lines are more commonly used in "East Asian" locales, where the glyphs tend to occupy a large portion of the cell, so you're at risk of overlapping the text if the grid lines are too wide.

@j4james commented on GitHub (Jan 6, 2024): That said, you could argue that maybe the base size of these grid lines should be wider (I think it's currently 0.025em), but we need to be careful that we're not breaking backwards compatibility with the original single pixel expectation. Grid lines are more commonly used in "East Asian" locales, where the glyphs tend to occupy a large portion of the cell, so you're at risk of overlapping the text if the grid lines are too wide.
claunia commented 2026-01-31 07:31:55 +00:00
Author
Owner
Copy Link

@237dmitry commented on GitHub (Jan 6, 2024):

The lines to be the same thickness

In my opinion they are the same thickness:

Screenshot 2024-01-06 203550

@237dmitry commented on GitHub (Jan 6, 2024): > The lines to be the same thickness In my opinion they are the same thickness: ![Screenshot 2024-01-06 203550](https://github.com/microsoft/terminal/assets/78153320/f48504b1-04de-4fce-8949-235082e432a5)
claunia commented 2026-01-31 07:31:55 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jan 8, 2024):

@237dmitry It depends on your DPI / display scale and font size. DxRenderer (old text renderer) uses 0.025em for its thin lines. That is, for a font size of 12pt you get 0.3px thick lines (here I mean pt and px as CSS units in 96 DPI, aka 100% display scale). At 300% scale like in the original comment above, it would still result in <1px thick lines, which is then forcefully rounded up to a min. of 1px.

The newer AtlasEngine uses half the underline width as the width for thin lines, as this happens to match Word's approach for double-underlines. This may result in thicker 2px lines for @ClaireCJS depending on whether their 1.5px thickness gets rounded up or down.

@lhecker commented on GitHub (Jan 8, 2024): @237dmitry It depends on your DPI / display scale and font size. DxRenderer (old text renderer) uses 0.025em for its thin lines. That is, for a font size of 12pt you get 0.3px thick lines (here I mean pt and px as CSS units in 96 DPI, aka 100% display scale). At 300% scale like in the original comment above, it would still result in <1px thick lines, which is then forcefully rounded up to a min. of 1px. The newer AtlasEngine uses half the underline width as the width for thin lines, as this happens to match Word's approach for double-underlines. This may result in thicker 2px lines for @ClaireCJS depending on whether their 1.5px thickness gets rounded up or down.
claunia commented 2026-01-31 07:31:55 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jan 8, 2024):

@lhecker I knew the AlasEngine used a different algorithm for double underlines, but I wasn't aware that it was using that same "thin line" width for grid lines. That's possibly not a good idea. Does Word really use grid lines like that as well?

Not that it matters as things are now, since the only grid line that works in Windows Terminal is the overline, but if we ever got full grid line support, I would think a width derived from the underline style could be more risky.

@j4james commented on GitHub (Jan 8, 2024): @lhecker I knew the AlasEngine used a different algorithm for double underlines, but I wasn't aware that it was using that same "thin line" width for grid lines. That's possibly not a good idea. Does Word really use grid lines like that as well? Not that it matters as things are now, since the only grid line that works in Windows Terminal is the overline, but if we ever got full grid line support, I would think a width derived from the underline style could be more risky.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21056
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?