starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Feature Request: Ability to change what key/key sequence reopens or closes a profile session #21120

New Issue
Open
opened 2026-01-31 07:33:42 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 07:33:42 +00:00
Owner
Copy Link

Originally created by @datdamnmachine on GitHub (Jan 21, 2024).

Description of the new feature/enhancement

This feature request is related to this feature request:

https://github.com/microsoft/terminal/issues/4379

Essentially, the ability to customize what key/key sequences reopens or closes a profile session. Currently Ctrl+D will close the terminal after exit and "Enter" will restart it. I would like to customize it so that "r" will restart the session and "" or "" will close the session for good. This is what MobaXterm uses and it would be nice to have it consistent as I use both regularly.

Proposed technical implementation details (optional)

Something like this in the json file:

"closeOnExit": "never",
{
"closeKey": "",
"reopenKey": "r"
}

Originally created by @datdamnmachine on GitHub (Jan 21, 2024). # Description of the new feature/enhancement This feature request is related to this feature request: https://github.com/microsoft/terminal/issues/4379 Essentially, the ability to customize what key/key sequences reopens or closes a profile session. Currently Ctrl+D will close the terminal after exit and "Enter" will restart it. I would like to customize it so that "r" will restart the session and "<Return>" or "<Enter>" will close the session for good. This is what MobaXterm uses and it would be nice to have it consistent as I use both regularly. # Proposed technical implementation details (optional) Something like this in the json file: "closeOnExit": "never", { "closeKey": "<Enter>", "reopenKey": "r" }
claunia added the Issue-FeatureHelp WantedProduct-TerminalArea-TerminalControl labels 2026-01-31 07:33:43 +00:00
claunia commented 2026-01-31 07:33:44 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jan 24, 2024):

Good catch! Thanks for filing this.

@carlos-zamora commented on GitHub (Jan 24, 2024): Good catch! Thanks for filing this.
claunia commented 2026-01-31 07:33:44 +00:00
Author
Owner
Copy Link

@skywalker290 commented on GitHub (Jan 26, 2024):

Can i help on this one?

@skywalker290 commented on GitHub (Jan 26, 2024): Can i help on this one?
claunia commented 2026-01-31 07:33:44 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 1, 2024):

@skywalker290 We probably won't get to this ourselves, so we'd definitely appreciate the help!

I'd caveat all this with the fact that we'll need to brainstorm what the settings would look like in the actual json, so we may change how the setting is parsed on review. I'd guess something like the following would be a good start:

    "profiles": 
    {
        "defaults": 
        {
            "closeOnExit": "never",
            "closeKey": "ctrl+alt+q",
            "reopenKey": "r"
@zadjii-msft commented on GitHub (Feb 1, 2024): @skywalker290 We probably won't get to this ourselves, so we'd definitely appreciate the help! I'd caveat all this with the fact that we'll need to brainstorm what the settings would look like in the actual json, so we may change how the setting is parsed on review. I'd guess something like the following would be a good start: ```json "profiles": { "defaults": { "closeOnExit": "never", "closeKey": "ctrl+alt+q", "reopenKey": "r" ``` * `MTSM_PROFILE_SETTINGS` in https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalSettingsModel/MTSMSettings.h#L78 already contains all the per-profile settings. * That'd need to get plumbed down to ControlCore: https://github.com/microsoft/terminal/blob/c669afe2a06c6db9a103e81a48cdc5b040d6fcff/src/cascadia/TerminalControl/ControlCore.cpp#L480-L497 * More tricky: we'd have to find a way to also plumb those keys (or the stringification of them) into: https://github.com/microsoft/terminal/blob/c669afe2a06c6db9a103e81a48cdc5b040d6fcff/src/cascadia/TerminalConnection/ConptyConnection.cpp#L457-L470 which is where the message is actually printed
claunia commented 2026-01-31 07:33:44 +00:00
Author
Owner
Copy Link

@skywalker290 commented on GitHub (Feb 23, 2024):

Json format would help with this we can put data into one json structure and send it.

@skywalker290 commented on GitHub (Feb 23, 2024): Json format would help with this we can put data into one json structure and send it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Help Wanted Issue-Feature Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21120
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?