starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Localization - Typos/consistency errors in French in closing contextual menu #21353

New Issue
Closed
opened 2026-01-31 07:42:08 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 07:42:08 +00:00
Owner
Copy Link

Originally created by @SphinxKnight on GitHub (Mar 5, 2024).

Windows Terminal version

1.19.10573.0

Windows build number

10.0.19045.4046

Other Software

No response

Steps to reproduce

Open the Terminal (splitting the tab helps discover one more string)

Expected Behavior

The contextual menu should contain "Fermer" (infinitive) and not "Fermez" (imperative)
Submenu should contain "Fermer les onglets à droite" / "Fermer les autres onglets" / "Fermer le volet"

Actual Behavior

Casing and conjugation are inconsistent

Conjugation: a mix of infinitive and imperative while the rest of the UI is, correctly, using infinitive
image

Casing: those strings are using uppercase starting words while the rest of the UI is, correctly, using an uppercase letter only for the first letter of the text

Originally created by @SphinxKnight on GitHub (Mar 5, 2024). ### Windows Terminal version 1.19.10573.0 ### Windows build number 10.0.19045.4046 ### Other Software _No response_ ### Steps to reproduce Open the Terminal (splitting the tab helps discover one more string) ### Expected Behavior The contextual menu should contain "Fermer" (infinitive) and not "Fermez" (imperative) Submenu should contain "Fermer les onglets à droite" / "Fermer les autres onglets" / "Fermer le volet" ### Actual Behavior Casing and conjugation are inconsistent Conjugation: a mix of infinitive and imperative while the rest of the UI is, correctly, using infinitive ![image](https://github.com/microsoft/terminal/assets/2413436/b1ba26a2-f55d-4a43-bb9a-59ab2940e21b) Casing: those strings are using uppercase starting words while the rest of the UI is, correctly, using an uppercase letter only for the first letter of the text
claunia added the Issue-BugNeeds-Tag-FixProduct-TerminalArea-Localization labels 2026-01-31 07:42:08 +00:00
claunia commented 2026-01-31 07:42:09 +00:00
Author
Owner
Copy Link

@PhMajerus commented on GitHub (Mar 8, 2024):

Just to clarify the expected behavior, the cascading menu item also needs to be fixed:

Fermer… >
     Fermer les onglets à droite
     Fermer les autres onglets
     Fermer le volet
Fermer l'onglet

The uppercases of some items seems weird to me even in English, but if you want to keep them and want French to be consistent with other languages:

Fermer… >
     Fermer les Onglets à Droite
     Fermer les Autres onglets
     Fermer le Volet
Fermer l'onglet

(note the Pane/volet is currently using uppercase in English but lowercase in French)

To be fair, it feels weird in English as well, and just looks even worse in French because it is applied only to some menu items and because determiners make them lose their left alignments, making it worse visually.

Oh, and those … are not consistent with Windows UI guidelines and have to go, see #16846.

@PhMajerus commented on GitHub (Mar 8, 2024): Just to clarify the expected behavior, the cascading menu item also needs to be fixed: ``` Fermer… > Fermer les onglets à droite Fermer les autres onglets Fermer le volet Fermer l'onglet ``` The uppercases of some items seems weird to me even in English, but if you want to keep them and want French to be consistent with other languages: ``` Fermer… > Fermer les Onglets à Droite Fermer les Autres onglets Fermer le Volet Fermer l'onglet ``` (note the `Pane`/`volet` is currently using uppercase in English but lowercase in French) To be fair, it feels weird in English as well, and just looks even worse in French because it is applied only to some menu items and because determiners make them lose their left alignments, making it worse visually. Oh, and those `…` are not consistent with Windows UI guidelines and have to go, see #16846.
claunia commented 2026-01-31 07:42:10 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (May 17, 2024):

The fermer vs. fermez issue does seem resolved now. I'm not entirely sure either whether capitalizing Pane in French is a good idea. It's a little weird even in the English original IMO.

@lhecker commented on GitHub (May 17, 2024): The fermer vs. fermez issue does seem resolved now. I'm not entirely sure either whether capitalizing Pane in French is a good idea. It's a little weird even in the English original IMO.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Localization Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21353
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?