starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add windows key support for key bindings #21428

New Issue
Closed
opened 2026-01-31 07:44:27 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 07:44:27 +00:00
Owner
Copy Link

Originally created by @cktgh on GitHub (Mar 21, 2024).

(While there are similar issues I suppose this is not exactly a duplicate)

Please consider adding support for the Windows modifier key in key binding settings.
Right now only the other 3 modifier keys (Ctrl, Alt and Shift) is functional.

Originally created by @cktgh on GitHub (Mar 21, 2024). (While there are similar issues I suppose this is not exactly a duplicate) Please consider adding support for the Windows modifier key in key binding settings. Right now only the other 3 modifier keys (Ctrl, Alt and Shift) is functional.
claunia commented 2026-01-31 07:44:29 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 22, 2024):

I'm pretty sure we already do support win as a modifier?

Looks like we've supported that for like, 3 years now. What exactly are you trying/?

@zadjii-msft commented on GitHub (Mar 22, 2024): I'm pretty sure we already do support `win` as a modifier? * https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalControl/KeyChord.cpp#L19 * https://github.com/microsoft/terminal/pull/9783 Looks like we've supported that for like, 3 years now. What exactly are you trying/?
claunia commented 2026-01-31 07:44:29 +00:00
Author
Owner
Copy Link

@cktgh commented on GitHub (Mar 22, 2024):

Sorry for being unclear, I presumed that the windows key was not supported to begin with, because key presses on the windows key are not detected when modifying key bindings on the UI:
WindowsTerminal_vnB5PBO7sY

@cktgh commented on GitHub (Mar 22, 2024): Sorry for being unclear, I presumed that the windows key was not supported to begin with, because key presses on the windows key are not detected when modifying key bindings on the UI: ![WindowsTerminal_vnB5PBO7sY](https://github.com/microsoft/terminal/assets/136404740/fb2b1d39-b118-4d87-91e7-c202ce181b1d)
claunia commented 2026-01-31 07:44:29 +00:00
Author
Owner
Copy Link

@cktgh commented on GitHub (Mar 22, 2024):

Now that I looked into it, changing a key binding (that involves the window key) manually through editing the JSON occasionally works.

Code_7mFQeOxyd8
WindowsTerminal_DS0I6gkOuG

Here I noticed that changes to the key bindings is registered, yet it is non-functional if there is an existing binding using the same key combinations.
e.g. win+t is non-functional; win+n is functional.

EDIT:
I read the pull request you linked

So the list of valid combos is vanishingly small. It's all about that win+~

😢

@cktgh commented on GitHub (Mar 22, 2024): Now that I looked into it, changing a key binding (that involves the window key) manually through editing the JSON occasionally works. ![Code_7mFQeOxyd8](https://github.com/microsoft/terminal/assets/136404740/7800de30-c4c9-45a9-87ae-7e3bc7c1ae54) ![WindowsTerminal_DS0I6gkOuG](https://github.com/microsoft/terminal/assets/136404740/5b312323-5b47-49a8-a870-10e6b1b1c604) Here I noticed that changes to the key bindings is registered, yet it is non-functional **if there is an existing binding using the same key combinations**. e.g. `win+t` is non-functional; `win+n` is functional. EDIT: I read the pull request you linked > So the list of valid combos is vanishingly small. It's all about that win+~ 😢
claunia commented 2026-01-31 07:44:29 +00:00
Author
Owner
Copy Link

@cktgh commented on GitHub (Mar 22, 2024):

Terminal's distant cousin iTerm2 actually supports the equivalent of what I was trying to do pretty well 😅

To mitigate the issue I have written a script in AHKv2. Unfortunately this script doesn't work with the option "Hide Terminal in the notification area when it is minimized":

#Requires AutoHotkey v2.0

#T::toggleTerminal
!^T::launchTerminal

toggleTerminal(){
	if(ProcessExist("WindowsTerminal.exe")){
		hwnd := WinGetID("ahk_exe WindowsTerminal.exe")
		if(WinExist(hwnd)){
			WinActive(hwnd) ? WinMinimize(hwnd) : WinActivate(hwnd)
		}
	}
	else{
		launchTerminal()
	}
}

launchTerminal(){
	Run("wt -d D:\")
}

I hope this helps anyone else who have the same issue.

@cktgh commented on GitHub (Mar 22, 2024): Terminal's distant cousin [iTerm2](https://iterm2.com/) actually supports the equivalent of what I was trying to do pretty well 😅 To mitigate the issue I have written a script in AHKv2. Unfortunately this script doesn't work with the option "Hide Terminal in the notification area when it is minimized": ```ahk #Requires AutoHotkey v2.0 #T::toggleTerminal !^T::launchTerminal toggleTerminal(){ if(ProcessExist("WindowsTerminal.exe")){ hwnd := WinGetID("ahk_exe WindowsTerminal.exe") if(WinExist(hwnd)){ WinActive(hwnd) ? WinMinimize(hwnd) : WinActivate(hwnd) } } else{ launchTerminal() } } launchTerminal(){ Run("wt -d D:\") } ``` I hope this helps anyone else who have the same issue.
claunia commented 2026-01-31 07:44:29 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 22, 2024):

Yea, Win+T looks like it's not going to work in the Terminal directly, since that's a keyboard shortcut that's reserved by the OS for focusing the taskbar (at least, that's seemingly what it does on Windows 11).

Thanks for following up!

@zadjii-msft commented on GitHub (Mar 22, 2024): Yea, <kbd>Win+T</kbd> looks like it's not going to work in the Terminal directly, since that's a keyboard shortcut that's reserved by the OS for focusing the taskbar (at least, that's seemingly what it does on Windows 11). Thanks for following up!
claunia commented 2026-01-31 07:44:30 +00:00
Author
Owner
Copy Link

@cktgh commented on GitHub (Mar 22, 2024):

It would be nice if we could override the key binding reservation, it can definitely be done as demonstrated by AHK, even wiithout administrator rights

I don't think anyone takes "OS reseved windows key bindings" seriously;
WIN+CTRL+SHIFT+ALT+L opens Linklin in our default browser, so even the OS doesn't take it seriously 😂

@cktgh commented on GitHub (Mar 22, 2024): It would be nice if we could override the key binding reservation, it can definitely be done as demonstrated by AHK, even wiithout administrator rights I don't think anyone takes "OS reseved windows key bindings" seriously; WIN+CTRL+SHIFT+ALT+L opens Linklin in our default browser, so even the OS doesn't take it seriously 😂
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Question Needs-Attention Needs-Tag-Fix Needs-Triage Resolution-Answered
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21428
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?