starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.21.921] Session persistence will crash the Terminal if you've got uninitialized panes #21464

New Issue
Closed
opened 2026-01-31 07:45:27 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 07:45:27 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Apr 2, 2024).

Originally assigned to: @zadjii-msft on GitHub.

  • Make sure you've got session restore enabled.
  • quit the terminal with all your tabs and panes and stuff. I had a pane that was zoomed, and two windows.
  • install 1.21.921 because you're super excited for buffer restore
  • open the Terminal.
  • Immediately quit it, so you can see buffer restore in action
  • 💥

Stack is

[0x0]   Microsoft_Terminal_Control!TextBuffer::GetSize+0x4   0x8d070fe1d0   0x7ff9d62be272   
[0x1]   Microsoft_Terminal_Control!TextBuffer::GetLastNonSpaceCharacter+0x2a   0x8d070fe1f0   0x7ff9d6357cd8   
[0x2]   Microsoft_Terminal_Control!TextBuffer::Serialize+0xe8   0x8d070fe230   0x7ff9d63b2155   
[0x3]   Microsoft_Terminal_Control!Microsoft::Terminal::Core::Terminal::SerializeMainBuffer+0xf   0x8d070fe440   0x7ff9d63b209f   
[0x4]   Microsoft_Terminal_Control!winrt::Microsoft::Terminal::Control::implementation::ControlCore::PersistToPath+0x3a   0x8d070fe440   0x7ff9d63b209f   
[0x5]   Microsoft_Terminal_Control!winrt::Microsoft::Terminal::Control::implementation::TermControl::PersistToPath+0x6d   0x8d070fe440   0x7ff9d63b209f

In this case, a pane wasn't activated, so the core was never initialized, so the buffer was never instantiated.

Originally created by @zadjii-msft on GitHub (Apr 2, 2024). Originally assigned to: @zadjii-msft on GitHub. * Make sure you've got session restore enabled. * quit the terminal with all your tabs and panes and stuff. I had a pane that was zoomed, and two windows. * install 1.21.921 because you're super excited for buffer restore * open the Terminal. * Immediately quit it, so you can see buffer restore in action * 💥 Stack is ``` [0x0] Microsoft_Terminal_Control!TextBuffer::GetSize+0x4 0x8d070fe1d0 0x7ff9d62be272 [0x1] Microsoft_Terminal_Control!TextBuffer::GetLastNonSpaceCharacter+0x2a 0x8d070fe1f0 0x7ff9d6357cd8 [0x2] Microsoft_Terminal_Control!TextBuffer::Serialize+0xe8 0x8d070fe230 0x7ff9d63b2155 [0x3] Microsoft_Terminal_Control!Microsoft::Terminal::Core::Terminal::SerializeMainBuffer+0xf 0x8d070fe440 0x7ff9d63b209f [0x4] Microsoft_Terminal_Control!winrt::Microsoft::Terminal::Control::implementation::ControlCore::PersistToPath+0x3a 0x8d070fe440 0x7ff9d63b209f [0x5] Microsoft_Terminal_Control!winrt::Microsoft::Terminal::Control::implementation::TermControl::PersistToPath+0x6d 0x8d070fe440 0x7ff9d63b209f ``` In this case, a pane wasn't activated, so the core was never initialized, so the buffer was never instantiated.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Needs-Tag-Fix Needs-Triage Product-Terminal Severity-Blocking Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21464
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?