starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.21 canary] Session restore is restoring to the wrong screen coordinates and window size #21478

New Issue
Closed
opened 2026-01-31 07:45:51 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 07:45:51 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Apr 3, 2024).

Originally assigned to: @zadjii-msft on GitHub.

Seems like we're off by a DPI scaling factor somewhere?

image

settings

    "firstWindowPreference": "persistedWindowLayout",
    "initialCols": 80,
    "initialPosition": "-128,383",
    "initialRows": 24,
    "launchMode": "default",

state:

	"persistedWindowLayouts" : 
	[
		{
			"initialSize" : 
			{
				"height" : 896.0,
				"width" : 1407.0
			},
			"launchMode" : "default",
			"tabLayout" :

oops no initialPosition

Originally created by @zadjii-msft on GitHub (Apr 3, 2024). Originally assigned to: @zadjii-msft on GitHub. Seems like we're off by a DPI scaling factor somewhere? ![image](https://github.com/microsoft/terminal/assets/18356694/81facd8e-f89f-4956-bd17-a3ee145f771c) `settings` ```json "firstWindowPreference": "persistedWindowLayout", "initialCols": 80, "initialPosition": "-128,383", "initialRows": 24, "launchMode": "default", ``` `state`: ```json "persistedWindowLayouts" : [ { "initialSize" : { "height" : 896.0, "width" : 1407.0 }, "launchMode" : "default", "tabLayout" : ``` oops no `initialPosition`
claunia commented 2026-01-31 07:45:53 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 15, 2024):

https://github.com/microsoft/terminal/pull/16598#discussion_r1511519304

Looks like AppHost::_GetWindowLaunchPosition is never called

@zadjii-msft commented on GitHub (Apr 15, 2024): https://github.com/microsoft/terminal/pull/16598#discussion_r1511519304 Looks like `AppHost::_GetWindowLaunchPosition` is never called
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Windowing Issue-Bug Needs-Tag-Fix Product-Terminal Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21478
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?