starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Canary]: Tab tear-off leads to crash #21501

New Issue
Closed
opened 2026-01-31 07:46:25 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 07:46:25 +00:00
Owner
Copy Link

Originally created by @tusharsnx on GitHub (Apr 9, 2024).

Windows Terminal version

1.21.991.0

Windows build number

10.0.22631.0

Other Software

No response

Steps to reproduce

  1. Open Windows Terminal Canary.
  2. Try tearing off a tab.

Expected Behavior

The tab is opened in a new WT window.

Actual Behavior

WT crashes.

Originally created by @tusharsnx on GitHub (Apr 9, 2024). ### Windows Terminal version 1.21.991.0 ### Windows build number 10.0.22631.0 ### Other Software _No response_ ### Steps to reproduce 1. Open Windows Terminal Canary. 2. Try tearing off a tab. ### Expected Behavior The tab is opened in a new WT window. ### Actual Behavior WT crashes.
claunia commented 2026-01-31 07:46:28 +00:00
Author
Owner
Copy Link

@tusharsnx commented on GitHub (Apr 9, 2024):

In debug build on main, Closing a tab with the "❌" button also leads to the same crashing behavior. This is not reproducible on the latest Canary build (maybe due to release vs debug build?)

@tusharsnx commented on GitHub (Apr 9, 2024): In debug build on `main`, Closing a tab with the "❌" button also leads to the same crashing behavior. This is not reproducible on the latest Canary build (maybe due to release vs debug build?)
claunia commented 2026-01-31 07:46:28 +00:00
Author
Owner
Copy Link

@tusharsnx commented on GitHub (Apr 9, 2024):

Exception: Unhandled exception at 0x00007FFDD7FBEBDF (ntdll.dll) in WindowsTerminal.exe: Indirect call guard check detected invalid control transfer.

The exception is thrown at this if's scope exit:

Screenshot 2024-04-09 194231

image

@tusharsnx commented on GitHub (Apr 9, 2024): Exception: Unhandled exception at 0x00007FFDD7FBEBDF (ntdll.dll) in WindowsTerminal.exe: Indirect call guard check detected invalid control transfer. The exception is thrown at this `if`'s scope exit: ![Screenshot 2024-04-09 194231](https://github.com/microsoft/terminal/assets/55626797/bb5563d0-2d8b-40ee-a61a-9f49540da99c) ![image](https://github.com/microsoft/terminal/assets/55626797/6aea4c5d-f212-45fd-8e44-17c291b3dc9f)
claunia commented 2026-01-31 07:46:28 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Apr 9, 2024):

Indirect call guard check detected invalid control transfer.

Hmm, this is just a hunch, and I apologize for your SSD 😣, but could you try cleaning the entire solution and building it again?

image

Some of us had this issue happen before and back then it could be resolved with a clean build. My suspicion is that the build system doesn't properly invalidate some compiled objects which results in mismatched vtables.

@lhecker commented on GitHub (Apr 9, 2024): > Indirect call guard check detected invalid control transfer. Hmm, this is just a hunch, and I apologize for your SSD 😣, but could you try cleaning the entire solution and building it again? ![image](https://github.com/microsoft/terminal/assets/2256941/c6ba8def-9147-4f22-986b-af0b2eedd3ed) Some of us had this issue happen before and back then it could be resolved with a clean build. My suspicion is that the build system doesn't properly invalidate some compiled objects which results in mismatched vtables.
claunia commented 2026-01-31 07:46:28 +00:00
Author
Owner
Copy Link

@tusharsnx commented on GitHub (Apr 9, 2024):

@lhecker Thanks for the info. I'll try doing a clean build next time.

I'm also curious why Canary might crash on tab tear-off 🤔

@tusharsnx commented on GitHub (Apr 9, 2024): @lhecker Thanks for the info. I'll try doing a clean build next time. I'm also curious why Canary might crash on tab tear-off 🤔
claunia commented 2026-01-31 07:46:28 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 15, 2024):

FWIW I can repro the tear-off crash on my own canary 21.991 (and after upgrading, my 21.1011) here as well. So, it's definitely not just a clean build problem.

@zadjii-msft commented on GitHub (Apr 15, 2024): FWIW I can repro the tear-off crash on my own canary 21.991 (and after upgrading, my 21.1011) here as well. So, it's definitely not just a clean build problem.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Windowing Issue-Bug Needs-Tag-Fix Priority-1 Product-Terminal Severity-Blocking Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21501
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?