starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.21] Clicking on the right side of a combobox doesn't cause it to open / dropdown #21525

New Issue
Closed
opened 2026-01-31 07:47:06 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 07:47:06 +00:00
Owner
Copy Link

Originally created by @Zeroes1 on GitHub (Apr 15, 2024).

Originally assigned to: @zadjii-msft on GitHub.

Windows Terminal version

1.21.1011.0

Windows build number

10.0.19045.3448

Other Software

No response

Steps to reproduce

look the video
https://github.com/microsoft/terminal/assets/11919060/f5c52bf2-d51c-482c-9dfc-557d919ec554

ps. for future is good idea post issue like BUG for CANARY builds WT?

Expected Behavior

good work wit combobox
latest good canary buid: terminal-1.21.931.0

Actual Behavior

terminal-1.21.991.0
terminal-1.21.1011.0
is bad for work with combobox

Originally created by @Zeroes1 on GitHub (Apr 15, 2024). Originally assigned to: @zadjii-msft on GitHub. ### Windows Terminal version 1.21.1011.0 ### Windows build number 10.0.19045.3448 ### Other Software _No response_ ### Steps to reproduce look the video https://github.com/microsoft/terminal/assets/11919060/f5c52bf2-d51c-482c-9dfc-557d919ec554 ps. for future is good idea post issue like BUG for CANARY builds WT? ### Expected Behavior good work wit combobox latest good canary buid: terminal-1.21.931.0 ### Actual Behavior terminal-1.21.991.0 terminal-1.21.1011.0 is bad for work with combobox
claunia commented 2026-01-31 07:47:09 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 15, 2024):

for future is good idea post issue like BUG for CANARY builds WT

Yes absolutely! If you're using canary and find bugs in it, absolutely file them here 😄

21.931 included the font face combo box, so that wasn't the source of this regression.

@zadjii-msft commented on GitHub (Apr 15, 2024): > for future is good idea post issue like BUG for CANARY builds WT Yes absolutely! If you're using canary and find bugs in it, absolutely file them here 😄 ---- 21.931 included the font face combo box, so that wasn't the source of this regression.
claunia commented 2026-01-31 07:47:09 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 17, 2024):

Here are the commits for that version range:

1.21.991.0 (bad ) -> * b90eb93d2 Localization Updates - main - 04/06/2024 03:04:16 (#17025)
                     * 156b9aeea Make marks a stable feature (#16938)
                     * c3f44f773 Rewrite how marks are stored & add reflow (#16937)
                     * dc4026d18 Add support for restoring non-terminal panes, and opening them with `splitPane`, `newTab` (#16914)
                     * c063d2bad Change default pane keybindings to duplicate, rather than use default profile (#16951)
                     * 6a69b94fc Increase usage of fmt and FMT_COMPILE (#17012)
                     * 8d6e7a8a7 Buffer Restore: Fix serializing >32KiB (#17022)
                     * 1a6ba43dd Get rid of UpdateTerminalSettings (#17009)
                     * 67ae9f6c3 Refactor the SettingsTab to be a pane (#16172)
1.21.931.0 (good) -> * 2bcbe6b49 ci/rel: publish symbols using the internal symbol request API instead (#16991)
@DHowett commented on GitHub (Apr 17, 2024): Here are the commits for that version range: ``` 1.21.991.0 (bad ) -> * b90eb93d2 Localization Updates - main - 04/06/2024 03:04:16 (#17025) * 156b9aeea Make marks a stable feature (#16938) * c3f44f773 Rewrite how marks are stored & add reflow (#16937) * dc4026d18 Add support for restoring non-terminal panes, and opening them with `splitPane`, `newTab` (#16914) * c063d2bad Change default pane keybindings to duplicate, rather than use default profile (#16951) * 6a69b94fc Increase usage of fmt and FMT_COMPILE (#17012) * 8d6e7a8a7 Buffer Restore: Fix serializing >32KiB (#17022) * 1a6ba43dd Get rid of UpdateTerminalSettings (#17009) * 67ae9f6c3 Refactor the SettingsTab to be a pane (#16172) 1.21.931.0 (good) -> * 2bcbe6b49 ci/rel: publish symbols using the internal symbol request API instead (#16991) ```
claunia commented 2026-01-31 07:47:09 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 17, 2024):

@zadjii-msft just a cold read, but due to 67ae9f6c3 you may be the killer

@DHowett commented on GitHub (Apr 17, 2024): @zadjii-msft just a cold read, but due to 67ae9f6c3 you may be the killer
claunia commented 2026-01-31 07:47:10 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 1, 2024):

You know, this is pretty dang painful. Promoting to blocking to investigate

Notes:

Wait a sec this doesn't repro on the canary build I have open on this machine anymore. What the hay barrels? Did I lose the repro?

okay definitely repros on main. Click on the right side of the combobox, and slowly move to the left. Usually there's a point where it starts working?

67ae9f6c3e is the first bad commit

@zadjii-msft commented on GitHub (May 1, 2024): You know, this is pretty dang painful. Promoting to blocking to investigate Notes: Wait a sec this doesn't repro on the canary build I have open on this machine anymore. What the hay barrels? Did I lose the repro? okay definitely repros on main. Click on the right side of the combobox, and slowly move to the left. Usually there's a point where it starts working? * [x] ❌ 32fbb16d4 main * [x] ❌ f49cf44b799b4a4017ab7dce5c29694cda0fe725 Add more TraceLogging to ApiDispatchers (#17085) * [x] ❌ 8bd9578b3ca9d18ba362ce1fff9b396d426b39e9 Fix: UI style errors: Menu items capitalization and … (ellipses) mark misuse (#16886) * [x] ❌ c063d2bad68d46525a1fc693f4ff1d1c136b6f60 Change default pane keybindings to duplicate, rather than use default profile (#16951) * [x] ❌1a6ba43dd220d4a318627006bf2a6c8b9a70c7bc Get rid of UpdateTerminalSettings (#17009) * [ ] 67ae9f6c3e42e1ad3431ca02123fcfce57eef188 Refactor the SettingsTab to be a pane (#16172) * [ ] ✅ 2bcbe6b49 ci/rel: publish symbols using the internal symbol request API instead (#16991) 67ae9f6c3e42e1ad3431ca02123fcfce57eef188 is the first bad commit
claunia commented 2026-01-31 07:47:10 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 1, 2024):

48ed8be3-eafd-4cf4-9969-cdb317837a95

  • On the non-retemplated ones, it's just the arrow region that doesn't open it.
  • On the retemplated ones, it's anything except the label that doesn't open it
@zadjii-msft commented on GitHub (May 1, 2024): ![48ed8be3-eafd-4cf4-9969-cdb317837a95](https://github.com/microsoft/terminal/assets/18356694/7985a3cd-44de-4a4a-a106-cc75c0ac5a45) * On the non-retemplated ones, it's just the arrow region that doesn't open it. * On the retemplated ones, it's anything except the label that doesn't open it
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Issue-Bug Needs-Tag-Fix Product-Terminal Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21525
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?