starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

URL highlight broken when URL ends at the EOL #21532

New Issue
Closed
opened 2026-01-31 07:47:24 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 07:47:24 +00:00
Owner
Copy Link

Originally created by @bestis on GitHub (Apr 16, 2024).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version

1.19.10821.0

Windows build number

10.0.22631.3447

Other Software

No response

Steps to reproduce

  • Open Ubuntu terminal
  • Set your terminal to X cols
  • Run these echo's so that the amount of spaces make the middle one end in the EOL
echo 'https://developer.mozilla.org/en-US/docs/Web/CSS/letter-spacing'
echo '                 https://developer.mozilla.org/en-US/docs/Web/CSS/letter-spacing'
echo '                  https://developer.mozilla.org/en-US/docs/Web/CSS/letter-spacing'

  • Open Windows Powershell

  • Run similar echos

  • Open Command Prompt

  • Run similar echos without the quotes.

Expected Behavior

All the links open the right webpage.

Actual Behavior

  • Ubuntu, the middle link looses the last letter.
    image
  • Powershell, the middle link gets extra PS in the end.
    image
  • Command prompt, middle link looses the last letter
    image
Originally created by @bestis on GitHub (Apr 16, 2024). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version 1.19.10821.0 ### Windows build number 10.0.22631.3447 ### Other Software _No response_ ### Steps to reproduce - Open Ubuntu terminal - Set your terminal to X cols - Run these echo's so that the amount of spaces make the middle one end in the EOL ``` echo 'https://developer.mozilla.org/en-US/docs/Web/CSS/letter-spacing' echo ' https://developer.mozilla.org/en-US/docs/Web/CSS/letter-spacing' echo ' https://developer.mozilla.org/en-US/docs/Web/CSS/letter-spacing' ``` - Open Windows Powershell - Run similar echos - Open Command Prompt - Run similar echos without the quotes. ### Expected Behavior All the links open the right webpage. ### Actual Behavior - Ubuntu, the middle link looses the last letter. ![image](https://github.com/microsoft/terminal/assets/1753286/06d67ebd-a2ea-4826-bb73-0cbf6059c472) - Powershell, the middle link gets extra PS in the end. ![image](https://github.com/microsoft/terminal/assets/1753286/3aff4ac5-f770-49dc-b908-9d6a6379a211) - Command prompt, middle link looses the last letter ![image](https://github.com/microsoft/terminal/assets/1753286/aed85484-1f68-4c73-8d23-02ecaffdcad8)
claunia added the Area-OutputIssue-BugPriority-3Needs-Tag-FixProduct-Terminal labels 2026-01-31 07:47:25 +00:00
claunia commented 2026-01-31 07:47:26 +00:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Apr 16, 2024):

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@github-actions[bot] commented on GitHub (Apr 16, 2024): Hi I'm an AI powered bot that finds similar issues based off the issue title. Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you! ### Closed similar issues: - [URL highlight issues with emoji (#11797)](https://github.com/microsoft/terminal/issues/11797), similarity score: 0.79 > Note: You can give me feedback by thumbs upping or thumbs downing this comment.
claunia commented 2026-01-31 07:47:26 +00:00
Author
Owner
Copy Link

@bestis commented on GitHub (Apr 16, 2024):

My example has no emoji, wide-characters, etc. So doesn't seem related to me.

@bestis commented on GitHub (Apr 16, 2024): My example has no emoji, wide-characters, etc. So doesn't seem related to me.
claunia commented 2026-01-31 07:47:26 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Apr 17, 2024):

This likely occurs because the UTextAdapter.cpp code doesn't insert newlines between rows. This only becomes apparent when there's a newline at the exact end of the row because then there's no separator between the match (URL) and the remaining text.

@lhecker commented on GitHub (Apr 17, 2024): This likely occurs because the `UTextAdapter.cpp` code doesn't insert newlines between rows. This only becomes apparent when there's a newline at the exact end of the row because then there's no separator between the match (URL) and the remaining text.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21532
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?