starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Search highlights are gone if the window is resized #21535

New Issue
Closed
opened 2026-01-31 07:47:28 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 07:47:28 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Apr 16, 2024).

v1.20.11072.0 (bug bash on 4/16)

They shouldn't stick around after a resize

Originally created by @carlos-zamora on GitHub (Apr 16, 2024). v1.20.11072.0 (bug bash on 4/16) They shouldn't stick around after a resize
claunia added the Area-OutputIssue-BugNeeds-Tag-FixProduct-Terminal labels 2026-01-31 07:47:28 +00:00
claunia commented 2026-01-31 07:47:30 +00:00
Author
Owner
Copy Link

@tusharsnx commented on GitHub (Apr 19, 2024):

They shouldn't stick around after a resize

Does #16611 fix this for you?

@tusharsnx commented on GitHub (Apr 19, 2024): > They shouldn't stick around after a resize Does #16611 fix this for you?
claunia commented 2026-01-31 07:47:30 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Apr 19, 2024):

I may be doing something wrong, but it seems to still occur.

@lhecker commented on GitHub (Apr 19, 2024): I may be doing something wrong, but it seems to still occur.
claunia commented 2026-01-31 07:47:30 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Apr 19, 2024):

BTW something funny is happening when I resize the app (this is a debug build so it's a little laggy):

https://github.com/microsoft/terminal/assets/2256941/de665325-c0a2-4b2d-bdaf-5a759b5f8652

This is with my changes in to redo the search on resize, but I haven't touched the search code so I think it may have a bug.

@lhecker commented on GitHub (Apr 19, 2024): BTW something funny is happening when I resize the app (this is a debug build so it's a little laggy): https://github.com/microsoft/terminal/assets/2256941/de665325-c0a2-4b2d-bdaf-5a759b5f8652 This is with my changes in to redo the search on resize, but I haven't touched the search code so I think it may have a bug.
claunia commented 2026-01-31 07:47:30 +00:00
Author
Owner
Copy Link

@tusharsnx commented on GitHub (Apr 19, 2024):

If you have already introduced the throttled func, you still need to clear the search at the time of resize otherwise they render relative to the old buffer 🤔

@tusharsnx commented on GitHub (Apr 19, 2024): If you have already introduced the throttled func, you still need to clear the search at the time of resize otherwise they render relative to the old buffer 🤔
claunia commented 2026-01-31 07:47:31 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Apr 19, 2024):

OH.

@lhecker commented on GitHub (Apr 19, 2024): OH.
claunia commented 2026-01-31 07:47:31 +00:00
Author
Owner
Copy Link

@tusharsnx commented on GitHub (Apr 19, 2024):

Also, we don't really need to clear the highlights (and we should absolutely not because that's going to be announced as results being cleared 🤔). All we need is when there's a pending call to refresh the highlights, we should mark current results within Search to be not fresh. So, when the renderer tries to read in between the pending call, it should get an empty list for the duration. Later, the throttled call would refresh the results and mark them as fresh again.

@tusharsnx commented on GitHub (Apr 19, 2024): Also, we don't really need to _clear_ the highlights (and we should absolutely not because that's going to be announced as results being cleared 🤔). All we need is when there's a pending call to refresh the highlights, we should mark current results within `Search` to be _not_ fresh. So, when the renderer tries to read in between the pending call, it should get an empty list for the duration. Later, the throttled call would refresh the results and mark them as fresh again.
claunia commented 2026-01-31 07:47:31 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Apr 19, 2024):

[...] and we should absolutely not because that's going to be announced as results being cleared

BTW I've removed the event and replaced it with

  • An "output is idle" event, which gets thrown whenever there wasn't any output for 100ms
  • ControlCore::Search() returns a SearchResults struct

TermControl owns ControlCore and because of that IMHO the former should be in charge of deciding when to call into the latter. Whenever ControlCore raises this generic "output is idle" event, TermControl calls _core.Search() and handles updating the UI synchronously. That way no search update event is needed.

So, when the renderer tries to read in between the pending call, it should get an empty list for the duration. Later, the throttled call would refresh the results and mark them as fresh again.

I may be misunderstanding you again, but you're suggesting to clear the search results after the reflow and then trigger a search update asynchronously, right? That's the same thing I had in mind. 🙂

@lhecker commented on GitHub (Apr 19, 2024): > [...] and we should absolutely not because that's going to be announced as results being cleared BTW I've removed the event and replaced it with * An "output is idle" event, which gets thrown whenever there wasn't any output for 100ms * `ControlCore::Search()` returns a `SearchResults` struct `TermControl` owns `ControlCore` and because of that IMHO the former should be in charge of deciding when to call into the latter. Whenever `ControlCore` raises this generic "output is idle" event, `TermControl` calls `_core.Search()` and handles updating the UI synchronously. That way no search update event is needed. > So, when the renderer tries to read in between the pending call, it should get an empty list for the duration. Later, the throttled call would refresh the results and mark them as fresh again. I may be misunderstanding you again, but you're suggesting to clear the search results after the reflow and then trigger a search update asynchronously, right? That's the same thing I had in mind. 🙂
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21535
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?