starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.21] Selecting commands, output with the context menu is totally in the wrong place #21585

New Issue
Closed
opened 2026-01-31 07:48:51 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 07:48:51 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Apr 25, 2024).

Originally assigned to: @zadjii-msft on GitHub.

open pwsh, with shell integration enabled

do a

cd Z:\dev\public\OpenConsole\
git status
dir
foo
whatever

try and right-click select the output of dir, and it's... wrong:

image

surely, I'm the murderer, but I could have swore there were tests for this

Originally created by @zadjii-msft on GitHub (Apr 25, 2024). Originally assigned to: @zadjii-msft on GitHub. open pwsh, with shell integration enabled do a ``` cd Z:\dev\public\OpenConsole\ git status dir foo whatever ``` try and right-click select the output of `dir`, and it's... wrong: ![image](https://github.com/microsoft/terminal/assets/18356694/99bee5a6-5e62-4d8a-8aea-b7d8acf018f6) surely, I'm the murderer, but I could have swore there were tests for this
claunia added the Issue-BugIn-PRNeeds-Tag-Fix labels 2026-01-31 07:48:51 +00:00
claunia commented 2026-01-31 07:48:52 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 25, 2024):

f36d589a8e/src/cascadia/TerminalCore/terminalrenderdata.cpp (L205-L214)

or prior:

d632c39cc3/src/cascadia/TerminalCore/terminalrenderdata.cpp (L171-L207)

Just staring at that in isolation, it's not clear to me what coordinate system the coord params of

SelectNewRegion(const til::point coordStart, const til::point coordEnd)

are

@zadjii-msft commented on GitHub (Apr 25, 2024): https://github.com/microsoft/terminal/blame/f36d589a8eb60fe9ff4c8efaad8eac088647e8a8/src/cascadia/TerminalCore/terminalrenderdata.cpp#L205-L214 or prior: https://github.com/microsoft/terminal/blame/d632c39cc3cef3075f09d881e03801518310d641/src/cascadia/TerminalCore/terminalrenderdata.cpp#L171-L207 Just staring at that in isolation, it's not clear to me what coordinate system the coord params of ```c++ SelectNewRegion(const til::point coordStart, const til::point coordEnd) ``` are
claunia commented 2026-01-31 07:48:53 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 25, 2024):

diff --git a/src/cascadia/TerminalCore/terminalrenderdata.cpp b/src/cascadia/TerminalCore/terminalrenderdata.cpp
index ec28b59d5..3d989f31f 100644
--- a/src/cascadia/TerminalCore/terminalrenderdata.cpp
+++ b/src/cascadia/TerminalCore/terminalrenderdata.cpp
@@ -199,7 +199,7 @@ til::CoordType Terminal::_ScrollToPoints(const til::point coordStart, const til:
         _NotifyScrollEvent();
     }

-    return _scrollOffset;
+    return _VisibleStartIndex();
 }

 void Terminal::SelectNewRegion(const til::point coordStart, const til::point coordEnd)

this fixes it. Need to write a test

@zadjii-msft commented on GitHub (Apr 25, 2024): ```diff diff --git a/src/cascadia/TerminalCore/terminalrenderdata.cpp b/src/cascadia/TerminalCore/terminalrenderdata.cpp index ec28b59d5..3d989f31f 100644 --- a/src/cascadia/TerminalCore/terminalrenderdata.cpp +++ b/src/cascadia/TerminalCore/terminalrenderdata.cpp @@ -199,7 +199,7 @@ til::CoordType Terminal::_ScrollToPoints(const til::point coordStart, const til: _NotifyScrollEvent(); } - return _scrollOffset; + return _VisibleStartIndex(); } void Terminal::SelectNewRegion(const til::point coordStart, const til::point coordEnd) ``` this fixes it. Need to write a test
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label In-PR Issue-Bug Needs-Tag-Fix
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21585
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?