starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Issues with cursor invalidation in GDI #21595

New Issue
Closed
opened 2026-01-31 07:49:04 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 07:49:04 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Apr 28, 2024).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version

Commit 378b6594bd

Windows build number

10.0.19045.4291

Other Software

No response

Steps to reproduce

  1. Make sure the conhost render engine is set to GDI (i.e. the UseDx registry entry is 0).
  2. Open a WSL shell in a recent build of OpenConsole (commit 20b0bed46d or later)
  3. Execute the following statements: 
    printf "\e[2 q"; sleep 2; printf "\e[A"; sleep 2; printf "\e[B"

Expected Behavior

The above script is setting the cursor to a steady block so it's easy to see, sleeping for 2 seconds, moving up a line and sleeping for another 2 seconds, then moving the cursor back down again. You should be able to see the cursor the entire time.

Actual Behavior

Initially the cursor is visible, but as soon as we move up a line it becomes invisible for 2 seconds.

I believe this is a regression from PR #15500. Originally we would call InvalidateCursor (via TriggerRedrawCursor) whenever the cursor was moved, both to invalidate the old position and the new position. But since PR #15500, TriggerRedrawCursor has been nuked, and InvalidateCursor is now called at the start of every frame (regardless of whether the cursor is moved or not), and it only invalidates the old cursor position. So when the cursor moves, it's erased from the old position, but not redrawn in the new position.

This typically only affects vertical movement (other than some edge cases), because at some point I think we stopped caring about the horizontal extent of the invalidated region and just refresh the full width of the screen regardless. This also doesn't seem to affect the DX and Atlas engines, but I have no idea why.

Originally created by @j4james on GitHub (Apr 28, 2024). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version Commit 378b6594bd94cf3b27f4e309a11efe25d83de0d9 ### Windows build number 10.0.19045.4291 ### Other Software _No response_ ### Steps to reproduce 1. Make sure the conhost render engine is set to GDI (i.e. the `UseDx` registry entry is 0). 2. Open a WSL shell in a recent build of OpenConsole (commit 20b0bed46df71c596b4fb68edfb6bb4b4ebf1c89 or later) 3. Execute the following statements: ``` printf "\e[2 q"; sleep 2; printf "\e[A"; sleep 2; printf "\e[B" ``` ### Expected Behavior The above script is setting the cursor to a steady block so it's easy to see, sleeping for 2 seconds, moving up a line and sleeping for another 2 seconds, then moving the cursor back down again. You should be able to see the cursor the entire time. ### Actual Behavior Initially the cursor is visible, but as soon as we move up a line it becomes invisible for 2 seconds. I believe this is a regression from PR #15500. Originally we would call `InvalidateCursor` (via `TriggerRedrawCursor`) whenever the cursor was moved, both to invalidate the old position and the new position. But since PR #15500, `TriggerRedrawCursor` has been nuked, and `InvalidateCursor` is now called at the start of every frame (regardless of whether the cursor is moved or not), and it only invalidates the old cursor position. So when the cursor moves, it's erased from the old position, but not redrawn in the new position. This typically only affects vertical movement (other than some edge cases), because at some point I think we stopped caring about the horizontal extent of the invalidated region and just refresh the full width of the screen regardless. This also doesn't seem to affect the DX and Atlas engines, but I have no idea why.
claunia commented 2026-01-31 07:49:06 +00:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Apr 28, 2024):

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@github-actions[bot] commented on GitHub (Apr 28, 2024): Hi I'm an AI powered bot that finds similar issues based off the issue title. Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you! ### Open similar issues: - [Flickering in conhost when scrolling top part of screen (#11274)](https://github.com/microsoft/terminal/issues/11274), similarity score: 0.76 ### Closed similar issues: - [More cursor droppings (#8213)](https://github.com/microsoft/terminal/issues/8213), similarity score: 0.80 - [Cursor droppings are back in conhost (#12739)](https://github.com/microsoft/terminal/issues/12739), similarity score: 0.77 - [Weird scrolling regression in the GDI renderer (#13270)](https://github.com/microsoft/terminal/issues/13270), similarity score: 0.76 > Note: You can give me feedback by thumbs upping or thumbs downing this comment.
claunia commented 2026-01-31 07:49:06 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Apr 28, 2024):

I love you github-actions bot, and I hope you'll spare my life when the robot revolution comes, but I feel a little bit hurt when you suggest a bunch of my own issues back to me, like idiot human can't remember that he's already raised this issue before. Although to be fair, that's not an unreasonable assumption.

@j4james commented on GitHub (Apr 28, 2024): I love you github-actions bot, and I hope you'll spare my life when the robot revolution comes, but I feel a little bit hurt when you suggest a bunch of my own issues back to me, like idiot human can't remember that he's already raised this issue before. Although to be fair, that's not an unreasonable assumption.
claunia commented 2026-01-31 07:49:06 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Apr 28, 2024):

As to how we fix this issue, I can get it to work again by replicating most of the following code a couple of lines down:
378b6594bd/src/renderer/base/renderer.cpp (L124-L160)

That is, after we've reinitialized _currentCursorOptions with the new position, we need to invalidate that new position as well (I'm not sure about the _compositionCache, so I just ignored that bit). I don't know if this is a good solution, though.

@j4james commented on GitHub (Apr 28, 2024): As to how we fix this issue, I can get it to work again by replicating most of the following code a couple of lines down: https://github.com/microsoft/terminal/blob/378b6594bd94cf3b27f4e309a11efe25d83de0d9/src/renderer/base/renderer.cpp#L124-L160 That is, after we've reinitialized `_currentCursorOptions` with the new position, we need to invalidate that new position as well (I'm not sure about the `_compositionCache`, so I just ignored that bit). I don't know if this is a good solution, though.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Needs-Tag-Fix Product-Terminal Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21595
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?