starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Output containing OSC sequences (e.g. shell integration) is not rendered (regression) #21641

New Issue
Closed
opened 2026-01-31 07:50:37 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 07:50:37 +00:00
Owner
Copy Link

Originally created by @krzysdz on GitHub (May 8, 2024).

Windows Terminal version

432dfcc490 and later

Windows build number

10.0.19045.4291

Other Software

No response

Steps to reproduce

  1. Enable shell integration in oh-my-posh or set your PowerShell prompt to 
    function prompt {
    "$([char]0x1b)]133;D`a$([char]0x1b)]133;A`a> $([char]0x1b)]133;B`a"
}
  2. Open a new pane/window to load the profile
  3. (Optionally) Try pressing Ctrl+C and normal characters

Expected Behavior

No response

Actual Behavior

The prompt (and ^C sometimes too) is not rendered until a printable character is entered from keyboard or the window is resized (resizing doesn't always help).

https://github.com/microsoft/terminal/assets/12915102/75bff0bb-0ad7-48ec-9209-0718279caec6

https://github.com/microsoft/terminal/assets/12915102/e560387f-2f12-4d9c-870d-af21d053cb08

This regression was introduced in 432dfcc490 (#17194)

Originally created by @krzysdz on GitHub (May 8, 2024). ### Windows Terminal version 432dfcc4902d1a8393217a5f529d07e65182a3f8 and later ### Windows build number 10.0.19045.4291 ### Other Software _No response_ ### Steps to reproduce 1. Enable shell integration in oh-my-posh or set your PowerShell prompt to ```ps function prompt { "$([char]0x1b)]133;D`a$([char]0x1b)]133;A`a> $([char]0x1b)]133;B`a" } ``` 2. Open a new pane/window to load the profile 3. (Optionally) Try pressing Ctrl+C and normal characters ### Expected Behavior _No response_ ### Actual Behavior The prompt (and `^C` sometimes too) is not rendered until a printable character is entered from keyboard or the window is resized (resizing doesn't always help). https://github.com/microsoft/terminal/assets/12915102/75bff0bb-0ad7-48ec-9209-0718279caec6 https://github.com/microsoft/terminal/assets/12915102/e560387f-2f12-4d9c-870d-af21d053cb08 This regression was introduced in 432dfcc4902d1a8393217a5f529d07e65182a3f8 (#17194)
claunia added the Needs-TriageIssue-BugProduct-ConptyPriority-0Severity-Blocking labels 2026-01-31 07:50:37 +00:00
claunia commented 2026-01-31 07:50:39 +00:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (May 8, 2024):

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@github-actions[bot] commented on GitHub (May 8, 2024): Hi I'm an AI powered bot that finds similar issues based off the issue title. Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you! ### Closed similar issues: - [[REGR #3956] Terminal incorrectly splits part of escape sequence (#4131)](https://github.com/microsoft/terminal/issues/4131), similarity score: 0.78 - [OSC sequences in prompt get front loaded (#11220)](https://github.com/microsoft/terminal/issues/11220), similarity score: 0.75 > Note: You can give me feedback by thumbs upping or thumbs downing this comment.
claunia commented 2026-01-31 07:50:39 +00:00
Author
Owner
Copy Link

@krzysdz commented on GitHub (May 8, 2024):

@j4james ping

@krzysdz commented on GitHub (May 8, 2024): @j4james ping
claunia commented 2026-01-31 07:50:40 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (May 8, 2024):

I'm very sorry about this. I suspect it might be something else that needs to be reset in XtermEngine::StartPaint when returning early. But if it's not obvious, and we need a quick fix, feel free to revert PR #17194. That bug probably affects far fewer people.

@j4james commented on GitHub (May 8, 2024): I'm very sorry about this. I suspect it might be something else that needs to be reset in `XtermEngine::StartPaint` when returning early. But if it's not obvious, and we need a quick fix, feel free to revert PR #17194. That bug probably affects far fewer people.
claunia commented 2026-01-31 07:50:41 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 8, 2024):

Ah yep yeah I can confirm this too. It's... pretty rough, though I honestly don't know how many people have shell integration set up.

@lhecker you wanna take a look at this, see if we can't come up with a more clever fix than just reverting #17194? If we can't, then I'll probably make the argument that we need to revert that later this week.

@zadjii-msft commented on GitHub (May 8, 2024): Ah yep yeah I can confirm this too. It's... pretty rough, though I honestly don't know how many people have shell integration set up. @lhecker you wanna take a look at this, see if we can't come up with a more clever fix than just reverting #17194? If we can't, then I'll probably make the argument that we need to revert that later this week.
claunia commented 2026-01-31 07:50:41 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (May 8, 2024):

Hmm I wonder if it has to do with the _cursorMoved changes. Since it was always true this always caused a render pass. Restoring the old _cursorMoved = true code does make everything work again.

@lhecker commented on GitHub (May 8, 2024): Hmm I wonder if it has to do with the `_cursorMoved` changes. Since it was always `true` this always caused a render pass. Restoring the old `_cursorMoved = true` code does make everything work again.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Triage Priority-0 Product-Conpty Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21641
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?