starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Window layout persisted in state.json even if window persistence not enabled #21648

New Issue
Closed
opened 2026-01-31 07:50:53 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 07:50:53 +00:00
Owner
Copy Link

Originally created by @ianjoneill on GitHub (May 8, 2024).

Windows Terminal version

1.20.11215.0

Windows build number

10.0.22631.3447

Other Software

No response

Steps to reproduce

  1. Ensure window persistence is turned off
  2. Set windows terminal as your default terminal application
  3. Go to run and type cmd /k echo hello world
  4. Close the terminal
  5. Inspect %LOCALAPPDATA%\Packages\Microsoft.WindowsTerminalPreview_8wekyb3d8bbwe\LocalState\state.json

Expected Behavior

There is no history of the command that I ran in state.json.

Actual Behavior

state.json has leaked my super secret command line invocation!

{
  "persistedWindowLayouts" : 
  [
    {
      "initialPosition" : "234,234",
      "initialSize" : 
      {
        "height" : 436.0,
        "width" : 873.0
      },
      "launchMode" : "default",
      "tabLayout" : 
      [
        {
          "action" : "newTab",
          "commandline" : "\"C:\\WINDOWS\\system32\\cmd.exe\" /k echo hello world",
          "profile" : "Command Prompt",
          "startingDirectory" : "C:\\Users\\Ian",
          "suppressApplicationTitle" : false,
          "tabTitle" : "C:\\WINDOWS\\system32\\cmd.exe"
        }
      ]
    }
  ],
  "settingsHash" : "190f05f1cd1315b4-01d98faa8aecd332"
}

This is not reproducible on version 1.19.11213.0.

Originally created by @ianjoneill on GitHub (May 8, 2024). ### Windows Terminal version 1.20.11215.0 ### Windows build number 10.0.22631.3447 ### Other Software _No response_ ### Steps to reproduce 1. Ensure window persistence is turned off 2. Set windows terminal as your default terminal application 3. Go to run and type `cmd /k echo hello world` 4. Close the terminal 5. Inspect `%LOCALAPPDATA%\Packages\Microsoft.WindowsTerminalPreview_8wekyb3d8bbwe\LocalState\state.json` ### Expected Behavior There is no history of the command that I ran in `state.json`. ### Actual Behavior `state.json` has leaked my super secret command line invocation! ```json { "persistedWindowLayouts" : [ { "initialPosition" : "234,234", "initialSize" : { "height" : 436.0, "width" : 873.0 }, "launchMode" : "default", "tabLayout" : [ { "action" : "newTab", "commandline" : "\"C:\\WINDOWS\\system32\\cmd.exe\" /k echo hello world", "profile" : "Command Prompt", "startingDirectory" : "C:\\Users\\Ian", "suppressApplicationTitle" : false, "tabTitle" : "C:\\WINDOWS\\system32\\cmd.exe" } ] } ], "settingsHash" : "190f05f1cd1315b4-01d98faa8aecd332" } ``` This is not reproducible on version 1.19.11213.0.
claunia commented 2026-01-31 07:50:56 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (May 8, 2024):

Oh dear... But #17206 was created a little earlier than this issue, so lets close it in favor of the older one. 🙂 /dup #17206

@lhecker commented on GitHub (May 8, 2024): Oh dear... But #17206 was created a little earlier than this issue, so lets close it in favor of the older one. 🙂 /dup #17206
claunia commented 2026-01-31 07:50:56 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (May 8, 2024):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service[bot] commented on GitHub (May 8, 2024): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! <!-- Policy app identification https://img.shields.io/static/v1?label=PullRequestIssueManagement. -->
claunia commented 2026-01-31 07:50:57 +00:00
Author
Owner
Copy Link

@ianjoneill commented on GitHub (May 8, 2024):

I figured they were related, but not quite the same, so opened a separate ticket - given that this pre-dates 1.21.

@ianjoneill commented on GitHub (May 8, 2024): I figured they were related, but not quite the same, so opened a separate ticket - given that this pre-dates 1.21.
claunia commented 2026-01-31 07:50:57 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (May 8, 2024):

Oof, I saw the title, read the repro steps, and considering the timing I thought it would be a dupe. I'm sorry. 😣 However, it is in fact the exact same underlying reason: 1.20 contains the same session persistence improvements that 1.21 got, but without the buffer restore code. This is why both 1.20 and 1.21 have the same bug: They persist, even when they shouldn't.

I'll mark #17211 as fixing this issue. We'll then backport the parts that are relevant for 1.20 (a single if condition basically).

@lhecker commented on GitHub (May 8, 2024): Oof, I saw the title, read the repro steps, and considering the timing I thought it would be a dupe. I'm sorry. 😣 However, it is in fact the exact same underlying reason: 1.20 contains the same session persistence improvements that 1.21 got, but without the buffer restore code. This is why both 1.20 and 1.21 have the same bug: They persist, even when they shouldn't. I'll mark #17211 as fixing this issue. We'll then backport the parts that are relevant for 1.20 (a single if condition basically).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings In-PR Issue-Bug Needs-Tag-Fix Priority-1 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21648
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?