starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Regression in launching links #21774

New Issue
Closed
opened 2026-01-31 07:54:34 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 07:54:34 +00:00
Owner
Copy Link

Originally created by @chrisant996 on GitHub (May 25, 2024).

Windows Terminal version

1.21.1272.0

Windows build number

19045.4412

Other Software

No response

Steps to reproduce

  1. Open a cmd.exe tab in Terminal.
  2. Run echo Hello ^(https://github.com/chrisant996/clink^).
  3. Move the mouse over the hyperlink -- observe that the hyperlink is underlined correctly.
  4. Ctrl+Click the hyperlink -- the ) is mistakenly included in the URL, and causes the web navigation to fail.

Expected Behavior

It should open the link https://github.com/chrisant996/clink.
It should open the same link that it underlined.
Terminal 1.19.11213.0 works correctly.

Actual Behavior

It opened the link https://github.com/chrisant996/clink) -- note that the ) was mistakenly included.
What it opens is different from what it underlined.

Originally created by @chrisant996 on GitHub (May 25, 2024). ### Windows Terminal version 1.21.1272.0 ### Windows build number 19045.4412 ### Other Software _No response_ ### Steps to reproduce 1. Open a cmd.exe tab in Terminal. 2. Run `echo Hello ^(https://github.com/chrisant996/clink^)`. 3. Move the mouse over the hyperlink -- observe that the hyperlink is underlined correctly. 4. Ctrl+Click the hyperlink -- the `)` is mistakenly included in the URL, and causes the web navigation to fail. ### Expected Behavior It should open the link `https://github.com/chrisant996/clink`. It should open the same link that it underlined. Terminal 1.19.11213.0 works correctly. ### Actual Behavior It opened the link `https://github.com/chrisant996/clink)` -- note that the `)` was mistakenly included. What it opens is different from what it underlined.
claunia added the Needs-TriageIssue-Bug labels 2026-01-31 07:54:34 +00:00
claunia commented 2026-01-31 07:54:36 +00:00
Author
Owner
Copy Link

@tusharsnx commented on GitHub (May 28, 2024):

Thanks for reporting this.

I believe result->stop is an exclusive coord, but it was passed down to the .GetPlainText() which expects inclusive coords:
5d1cf1a704/src/cascadia/TerminalCore/Terminal.cpp (L525)

On it.

@tusharsnx commented on GitHub (May 28, 2024): Thanks for reporting this. I believe `result->stop` is an exclusive coord, but it was passed down to the `.GetPlainText()` which expects inclusive coords: https://github.com/microsoft/terminal/blob/5d1cf1a704986808d09ae7729aaed39ce5d5f909/src/cascadia/TerminalCore/Terminal.cpp#L525 On it.
claunia commented 2026-01-31 07:54:36 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 28, 2024):

@tusharsnx, @lhecker do either of you know if this will impact 1.20 as well?

@DHowett commented on GitHub (May 28, 2024): @tusharsnx, @lhecker do either of you know if this will impact 1.20 as well?
claunia commented 2026-01-31 07:54:36 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 28, 2024):

Checked it out - yes, 1.20 is impacted. I'll service this.

Thanks @chrisant996 for the report!

@DHowett commented on GitHub (May 28, 2024): Checked it out - yes, 1.20 is impacted. I'll service this. Thanks @chrisant996 for the report!
claunia commented 2026-01-31 07:54:36 +00:00
Author
Owner
Copy Link

@chrisant996 commented on GitHub (May 28, 2024):

Ah, I see, yes it's fresh, introduced by 5b8eadb2ea a month ago. 👍

@chrisant996 commented on GitHub (May 28, 2024): Ah, I see, yes it's fresh, introduced by 5b8eadb2ea16206bac2bb1c0b06f35bd4d0aae15 a month ago. 👍
claunia commented 2026-01-31 07:54:37 +00:00
Author
Owner
Copy Link

@Psypher1 commented on GitHub (Jun 12, 2024):

Hello, I was told my issue #17424 is already being tracked here. My question; I see a merge was done. Does that mean I should update terminal to enact the changes? However the most recent release is still preview...

Because while the merge sort of handle a similar issue, it's not quite what I'm experiencing

@Psypher1 commented on GitHub (Jun 12, 2024): Hello, I was told my issue #17424 is already being tracked here. My question; I see a merge was done. Does that mean I should update terminal to enact the changes? However the most recent release is still preview... Because while the merge sort of handle a similar issue, it's not quite what I'm experiencing
claunia commented 2026-01-31 07:54:37 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jun 18, 2024):

Preview will receive the fix sometime soon. Until then you can test out our nightly version here: https://aka.ms/terminal-canary-installer
Don't worry: If you uninstall it later, no traces will be left behind. :)

@lhecker commented on GitHub (Jun 18, 2024): Preview will receive the fix sometime soon. Until then you can test out our nightly version here: https://aka.ms/terminal-canary-installer Don't worry: If you uninstall it later, no traces will be left behind. :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21774
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?