starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Menu item accelerator does not get set for f1-f12 keys #21809

New Issue
Open
opened 2026-01-31 07:55:28 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 07:55:28 +00:00
Owner
Copy Link

Originally created by @PankajBhojwani on GitHub (Jun 4, 2024).

Windows Terminal version

No response

Windows build number

No response

Other Software

No response

Steps to reproduce

You need a build of terminal that has #17281 in it to repro this

  • Add an action to your new tab dropdown with f1 as the keybinding
  • Open the new tab dropdown
  • The action shows up, but the accelerator does not (there should be an accelerator that says the keybinding is f1)

Example json snippet to test this:

"keybindings": [
        {
            "id": "Terminal.CopyToClipboard",
            "keys": "f1"
        }
],
    "newTabMenu": 
    [
        {
            "type": "action",
            "id": "Terminal.CopyToClipboard"
        }
    ],

Preliminary investigation shows that MapVirtualKeyW (called in TerminalPage::_SetAcceleratorForMenuItem) returns 0 for any of the keys f1 through f12, and that's the issue

Expected Behavior

Accelerator should show up with f1 in it

Actual Behavior

There is no accelerator

Originally created by @PankajBhojwani on GitHub (Jun 4, 2024). ### Windows Terminal version _No response_ ### Windows build number _No response_ ### Other Software _No response_ ### Steps to reproduce You need a build of terminal that has #17281 in it to repro this - Add an action to your new tab dropdown with `f1` as the keybinding - Open the new tab dropdown - The action shows up, but the accelerator does not (there should be an accelerator that says the keybinding is `f1`) Example json snippet to test this: ``` "keybindings": [ { "id": "Terminal.CopyToClipboard", "keys": "f1" } ], "newTabMenu": [ { "type": "action", "id": "Terminal.CopyToClipboard" } ], ``` Preliminary investigation shows that `MapVirtualKeyW` (called in `TerminalPage::_SetAcceleratorForMenuItem`) returns `0` for any of the keys `f1` through `f12`, and that's the issue ### Expected Behavior Accelerator should show up with `f1` in it ### Actual Behavior There is no accelerator
claunia added the Issue-BugProduct-TerminalArea-UserInterface labels 2026-01-31 07:55:28 +00:00
claunia commented 2026-01-31 07:55:29 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jun 5, 2024):

Something like the quake mode keybinding with its scancode should have similar issues, but for a different reason, right? Also, don't we need to show the strings in the command palette too? Maybe we should make it a property of KeyChord so we don't have to do it twice.

@lhecker commented on GitHub (Jun 5, 2024): Something like the quake mode keybinding with its scancode should have similar issues, but for a different reason, right? Also, don't we need to show the strings in the command palette too? Maybe we should make it a property of `KeyChord` so we don't have to do it twice.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21809
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?