starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

1.22 We broke hot reload entirely #21811

New Issue
Closed
opened 2026-01-31 07:55:29 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 07:55:29 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jun 4, 2024).

Originally assigned to: @zadjii-msft on GitHub.

selfhost-1.22-bugbash-2024-06-04

culprits:

Originally created by @zadjii-msft on GitHub (Jun 4, 2024). Originally assigned to: @zadjii-msft on GitHub. selfhost-1.22-bugbash-2024-06-04 culprits: * 1c8e996 PRE-MERGE #17352 Fix some search highlights scenarios * 274010f PRE-MERGE #17358 Fix two panes being closed when just one is * 4485e50 PRE-MERGE #16848 Add support for custom CommandNotFound OSC * ab25a1e PRE-MERGE #16895 Add support for resizing panes with mouse * 7802e20 PRE-MERGE #16916 Implement grapheme clusters * e321c00 PRE-MERGE #17330 Add a snippets pane * b968f91 PRE-MERGE #17143 Improve Viewport and Viewport::WalkInBounds * 5460324 PRE-MERGE #16513 Add ability to save input action from command line * a2adcd3 PRE-MERGE #16479 Theme for settings * d14a984 PRE-MERGE #17281 Allow actions in the new tab dropdown * cf50777 PRE-MERGE #17215 Remove command's knowledge of its keys * d699a08 PRE-MERGE #17162 Refactor ActionMap and Command to use ActionIDs
claunia added the Needs-TriageNeeds-Tag-FixPriority-0Severity-Blocking labels 2026-01-31 07:55:29 +00:00
claunia commented 2026-01-31 07:55:30 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 4, 2024):

(i'll try to find the culprit in the morning)

@zadjii-msft commented on GitHub (Jun 4, 2024): (i'll try to find the culprit in the morning)
claunia commented 2026-01-31 07:55:30 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 5, 2024):

Uh, CascadiaSettings::LoadAll isn't called at all in hot reload. Neither is the lambda inside AppLogic::_RegisterSettingsChange. Uh, what? the call to AppLogic::_RegisterSettingsChange got entirely removed?? I'm betting it was a bad merge. I'm the murderer aren't I?

@zadjii-msft commented on GitHub (Jun 5, 2024): Uh, `CascadiaSettings::LoadAll` isn't called at all in hot reload. Neither is the lambda inside `AppLogic::_RegisterSettingsChange`. Uh, what? the call to `AppLogic::_RegisterSettingsChange` got entirely removed?? I'm betting it was a bad merge. I'm the murderer aren't I?
claunia commented 2026-01-31 07:55:30 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 5, 2024):

Okay, found the regression in #16916. You may return to your regularly scheduled anything else.

@zadjii-msft commented on GitHub (Jun 5, 2024): Okay, found the regression in #16916. You may return to your regularly scheduled _anything else_.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Tag-Fix Needs-Triage Priority-0 Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21811
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?