starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

conpty hangs in _ClosePseudoConsoleMembers #21917

New Issue
Closed
opened 2026-01-31 07:58:20 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 07:58:20 +00:00
Owner
Copy Link

Originally created by @LemonBoy on GitHub (Jun 30, 2024).

Windows Terminal version

No response

Windows build number

10.0.22631.0

Other Software

vim 9.1

Steps to reproduce

  • git clone git@github.com:vim/vim.git
  • cd src
  • nmake -f .\Make_mvc.mak GUI=yes FEATURES=HUGE TERMINAL=yes DEBUG=yes
  • .\gvimd.exe -U NONE -u NONE -c 'set go+=! | !dir'

Expected Behavior

No response

Actual Behavior

The program hangs.

Attacching a debugger shows the main thread waiting in _ClosePseudoConsoleMembers for conhost.exe to die.
The pipes passed by Vim are all closed by the time it calls ClosePseudoConsole, I've read the remark in the docs regarding the possibility for the function to hang, but here I'm not sure it applies to this case.

Originally created by @LemonBoy on GitHub (Jun 30, 2024). ### Windows Terminal version _No response_ ### Windows build number 10.0.22631.0 ### Other Software vim 9.1 ### Steps to reproduce - `git clone git@github.com:vim/vim.git` - `cd src` - `nmake -f .\Make_mvc.mak GUI=yes FEATURES=HUGE TERMINAL=yes DEBUG=yes` - `.\gvimd.exe -U NONE -u NONE -c 'set go+=! | !dir'` ### Expected Behavior _No response_ ### Actual Behavior The program hangs. Attacching a debugger shows the main thread waiting in `_ClosePseudoConsoleMembers` for `conhost.exe` to die. The pipes passed by Vim are all closed by the time it calls `ClosePseudoConsole`, I've read the remark in the docs regarding the possibility for the function to hang, but here I'm not sure it applies to this case.
claunia added the Needs-TriageIssue-Bug labels 2026-01-31 07:58:20 +00:00
claunia commented 2026-01-31 07:58:21 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jul 8, 2024):

The pipes passed by Vim are all closed by the time it calls ClosePseudoConsole, I've read the remark in the docs regarding the possibility for the function to hang, but here I'm not sure it applies to this case.

It does apply unfortunately. You must keep the output pipe open and read from it until after ClosePseudoConsole has returned.

Because this was difficult to use, we have modified ClosePseudoConsole in Windows 11 24H2 to never block. But that doesn't fix the issue on older Windows versions of course. I'm afraid this is an issue that vim must fix on their side for now (especially since this flaw was publicly documented for a long time).
Windows 11 24H2 also contains a ReleasePseudoConsole API with which you can simply read the output pipe until it's closed on you. That way you don't need to monitor whether the spawned child has exited, which makes it even safer to use.

@lhecker commented on GitHub (Jul 8, 2024): > The pipes passed by Vim are all closed by the time it calls `ClosePseudoConsole`, I've read the remark in the docs regarding the possibility for the function to hang, but here I'm not sure it applies to this case. It does apply unfortunately. You must keep the output pipe open and read from it until after `ClosePseudoConsole` has returned. Because this was difficult to use, we have modified `ClosePseudoConsole` in Windows 11 24H2 to never block. But that doesn't fix the issue on older Windows versions of course. I'm afraid this is an issue that vim must fix on their side for now (especially since this flaw was publicly documented for a long time). Windows 11 24H2 also contains a `ReleasePseudoConsole` API with which you can simply read the output pipe until it's closed on you. That way you don't need to monitor whether the spawned child has exited, which makes it even safer to use.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21917
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?