starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-23 23:45:08 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Backspace in wrapped cooked read erases char on line above #21963

New Issue
Closed
opened 2026-01-31 07:59:29 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 07:59:29 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Jul 12, 2024).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version

Commit ac5b4f5831

Windows build number

10.0.19045.4529

Other Software

No response

Steps to reproduce

  1. Checkout the latest code from main (ac5b4f5831 or later).
  2. Start a cmd shell in OpenConsole.
  3. Type some content at the prompt until it wraps onto the second line.
  4. Backspace until the cursor is at the start of that second line.

Expected Behavior

Backspaces on the second line should have no effect on the characters in the first line.

Actual Behavior

The last character on the first line gets erased when backspacing over the first character in the second line.

This is what it looks like after wrapping.
image

And this is what it looks like after two backspaces. Notice the r erased from the first line.
image

The same thing occurs in both OpenConsole and Windows Terminal. I think this was introduced by the new VT cooked read implementation (PR #17445).

Originally created by @j4james on GitHub (Jul 12, 2024). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version Commit ac5b4f5831c125e7defe65eab93d3928b282559f ### Windows build number 10.0.19045.4529 ### Other Software _No response_ ### Steps to reproduce 1. Checkout the latest code from main (ac5b4f5831c125e7defe65eab93d3928b282559f or later). 2. Start a cmd shell in OpenConsole. 3. Type some content at the prompt until it wraps onto the second line. 4. Backspace until the cursor is at the start of that second line. ### Expected Behavior Backspaces on the second line should have no effect on the characters in the first line. ### Actual Behavior The last character on the first line gets erased when backspacing over the first character in the second line. This is what it looks like after wrapping. ![image](https://github.com/user-attachments/assets/c31b06fa-52c1-4a74-b4ab-7eda11111eae) And this is what it looks like after two backspaces. Notice the `r` erased from the first line. ![image](https://github.com/user-attachments/assets/e6e440b0-0460-452e-92f0-cc14cadce133) The same thing occurs in both OpenConsole and Windows Terminal. I think this was introduced by the new VT cooked read implementation (PR #17445).
claunia added the Product-ConhostNeeds-TriageIssue-BugIn-PRArea-CookedRead labels 2026-01-31 07:59:29 +00:00
claunia commented 2026-01-31 07:59:31 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jul 12, 2024):

I should note that this is just a visual glitch. The actual prompt content is correct. It just looks like a character is missing.

@j4james commented on GitHub (Jul 12, 2024): I should note that this is just a visual glitch. The actual prompt content is correct. It just looks like a character is missing.
claunia commented 2026-01-31 07:59:31 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jul 12, 2024):

Your issue occurs because if (pagerPromptEnd.x >= size.width) must be after if (pagerPromptEnd.y <= _pagerPromptEnd.y) and not before it (I think).

I found two more bugs:

  • Writing a wide glyph into the last column breaks the cursor position.
    Fixed by moving dist += state.len; in TextBuffer::FitTextIntoColumns to the end of the loop.
  • Having a fairly full prompt (e.g. 80% of the viewport height) and pressing F7 with a rather full history will move the prompt contents upwards. But when dismissing F7 via ESC it'll not restore the prompt to its previous state.
@lhecker commented on GitHub (Jul 12, 2024): Your issue occurs because `if (pagerPromptEnd.x >= size.width)` must be after `if (pagerPromptEnd.y <= _pagerPromptEnd.y)` and not before it (I think). I found two more bugs: * Writing a wide glyph into the last column breaks the cursor position. Fixed by moving `dist += state.len;` in `TextBuffer::FitTextIntoColumns` to the end of the loop. * Having a fairly full prompt (e.g. 80% of the viewport height) and pressing F7 with a rather full history will move the prompt contents upwards. But when dismissing F7 via ESC it'll not restore the prompt to its previous state.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CookedRead In-PR Issue-Bug Needs-Triage Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21963
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?