starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Search resets current position while new results arrive #21965

New Issue
Closed
opened 2026-01-31 07:59:31 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 07:59:31 +00:00
Owner
Copy Link

Originally created by @lhecker on GitHub (Jul 11, 2024).

Originally posted by @OAguinagalde here: 32fbb16d43:

On version 1.21.1772.0, whenever using some log reading tool such as logcat or similar, I still get the scroll being triggered on many situations that I wouldn't expect it to:

Situation: logcat or whatever constantly outputs stuff to the terminal. I search for something on the terminal.

  • Whenever a new occurrence of my search is output, it automatically jumps to the new one. I'd expect that if I'm on occurrence 10/10, and 2 new occurrences appear, my scrolls would be wherever I originally had it and the active search would stay at 10/12. Instead of that, the active search is automatically set to the latest one (12/12) and it jumps there.
  • Also, If I try to "follow" the log output as it is printed to the terminal, as soon as the active search result is out of the screen, it jumps back to it, even if there is no new occurrences of the search, so I'm forced to cancel the search (meaning that I lose the highlighting) to be able to follow the logs being printed.

Is this commit supposed to fix those situations? I'm unsure whether I got my versions wrong or whether these situations where not taken into account when working on it.

https://github.com/microsoft/terminal/assets/2256941/e840403a-e418-4600-8d10-a2b4cbcd084e

Originally created by @lhecker on GitHub (Jul 11, 2024). Originally posted by @OAguinagalde here: https://github.com/microsoft/terminal/commit/32fbb16d43ddfcdd039a61c5af051a16b972faeb: --- On version `1.21.1772.0`, whenever using some log reading tool such as logcat or similar, I still get the scroll being triggered on many situations that I wouldn't expect it to: Situation: logcat or whatever constantly outputs stuff to the terminal. I search for something on the terminal. * Whenever a new occurrence of my search is output, it automatically jumps to the new one. I'd expect that if I'm on occurrence 10/10, and 2 new occurrences appear, my scrolls would be wherever I originally had it and the active search would stay at 10/12. Instead of that, the active search is automatically set to the latest one (12/12) and it jumps there. * Also, If I try to "follow" the log output as it is printed to the terminal, as soon as the active search result is out of the screen, it jumps back to it, even if there is no new occurrences of the search, so I'm forced to cancel the search (meaning that I lose the highlighting) to be able to follow the logs being printed. Is this commit supposed to fix those situations? I'm unsure whether I got my versions wrong or whether these situations where not taken into account when working on it. --- https://github.com/microsoft/terminal/assets/2256941/e840403a-e418-4600-8d10-a2b4cbcd084e
claunia commented 2026-01-31 07:59:33 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 22, 2024):

We should fix this at the same time as /dup #17301

@DHowett commented on GitHub (Aug 22, 2024): We should fix this at the same time as /dup #17301
claunia commented 2026-01-31 07:59:33 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (Aug 22, 2024):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service[bot] commented on GitHub (Aug 22, 2024): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! <!-- Policy app identification https://img.shields.io/static/v1?label=PullRequestIssueManagement. -->
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Priority-3 Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21965
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?