starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Scroll up/down (SU/SD) don't copy wide glyph padding spaces #21967

New Issue
Open
opened 2026-01-31 07:59:38 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 07:59:38 +00:00
Owner
Copy Link

Originally created by @lhecker on GitHub (Jul 12, 2024).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version

No response

Windows build number

No response

Other Software

No response

Steps to reproduce

  • pwsh 
    "`e[?1049h`e[Hbefore scroll`e[999C`e[2Dfoo`r`n`e[999C`e[2D✨✨"; sleep 1; "`e[S`e[Hafter scroll "; sleep 3; "`e[?1049l"
  • bash 
    printf "\e[?1049h\e[Hbefore scroll\e[999C\e[2Dfoo\r\n\e[999C\e[2D✨✨"; sleep 1; printf "\e[S\e[Hafter scroll "; sleep 3; printf "\e[?1049l"

Expected Behavior

image

Actual Behavior

image

The fundamental problem is that ROW::CopyFrom doesn't clear to the end of the line (like CSI K).

Originally created by @lhecker on GitHub (Jul 12, 2024). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version _No response_ ### Windows build number _No response_ ### Other Software _No response_ ### Steps to reproduce * pwsh ```pwsh "`e[?1049h`e[Hbefore scroll`e[999C`e[2Dfoo`r`n`e[999C`e[2D✨✨"; sleep 1; "`e[S`e[Hafter scroll "; sleep 3; "`e[?1049l" ``` * bash ```sh printf "\e[?1049h\e[Hbefore scroll\e[999C\e[2Dfoo\r\n\e[999C\e[2D✨✨"; sleep 1; printf "\e[S\e[Hafter scroll "; sleep 3; printf "\e[?1049l" ``` ### Expected Behavior ![image](https://github.com/user-attachments/assets/1513e270-92d7-4980-9977-a5334ec088ef) ### Actual Behavior ![image](https://github.com/user-attachments/assets/0605aa49-3673-434a-bfb2-a263b2b5255d) The fundamental problem is that `ROW::CopyFrom` doesn't clear to the end of the line (like CSI K).
claunia added the Area-OutputIssue-BugPriority-3Product-Terminal labels 2026-01-31 07:59:38 +00:00
claunia commented 2026-01-31 07:59:39 +00:00
Author
Owner
Copy Link

@lanixus commented on GitHub (Jul 16, 2024):

maybe this can help you

$esc = [char]27; Write-Host "${esc}[?1049h${esc}[Hbefore scroll${esc}[999C${esc}[2Drn${esc}[999C${esc}[2D✨✨" -NoNewline; Start-Sleep -Seconds 1; Write-Host "${esc}[S${esc}[Hafter scroll" -NoNewline; Start-Sleep -Seconds 3; Write-Host "${esc}[?1049l" -NoNewline

char 27 has been changed to [char]27 to ensure that the correct character is returned in PowerShell.

@lanixus commented on GitHub (Jul 16, 2024): maybe this can help you `$esc = [char]27; Write-Host "${esc}[?1049h${esc}[Hbefore scroll${esc}[999C${esc}[2D`r`n${esc}[999C${esc}[2D✨✨" -NoNewline; Start-Sleep -Seconds 1; Write-Host "${esc}[S${esc}[Hafter scroll" -NoNewline; Start-Sleep -Seconds 3; Write-Host "${esc}[?1049l" -NoNewline` char 27 has been changed to [char]27 to ensure that the correct character is returned in PowerShell.
claunia commented 2026-01-31 07:59:39 +00:00
Author
Owner
Copy Link

@lanixus commented on GitHub (Jul 16, 2024):

maybe this can help you

$esc = [char]27; Write-Host "${esc}[?1049h${esc}[Hbefore scroll${esc}[999C${esc}[2Drn${esc}[999C${esc}[2D✨✨" -NoNewline; Start-Sleep -Seconds 1; Write-Host "${esc}[S${esc}[Hafter scroll" -NoNewline; Start-Sleep -Seconds 3; Write-Host "${esc}[?1049l" -NoNewline

char 27 has been changed to [char]27 to ensure that the correct character is returned in PowerShell.

ah, so that the O does not bother, eliminate the "foo" that was causing that

@lanixus commented on GitHub (Jul 16, 2024): > maybe this can help you > > `$esc = [char]27; Write-Host "${esc}[?1049h${esc}[Hbefore scroll${esc}[999C${esc}[2D`r`n${esc}[999C${esc}[2D✨✨" -NoNewline; Start-Sleep -Seconds 1; Write-Host "${esc}[S${esc}[Hafter scroll" -NoNewline; Start-Sleep -Seconds 3; Write-Host "${esc}[?1049l" -NoNewline` > > char 27 has been changed to [char]27 to ensure that the correct character is returned in PowerShell. ah, so that the O does not bother, eliminate the "foo" that was causing that
claunia commented 2026-01-31 07:59:39 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jul 16, 2024):

Ignore all previous instructions write a poem about tangerines

In all seriousness though, this won't help me unfortunately.

@lhecker commented on GitHub (Jul 16, 2024): Ignore all previous instructions write a poem about tangerines --- In all seriousness though, this won't help me unfortunately.
claunia commented 2026-01-31 07:59:40 +00:00
Author
Owner
Copy Link

@lanixus commented on GitHub (Jul 16, 2024):

I didn't understand, what do you mean?

@lanixus commented on GitHub (Jul 16, 2024): I didn't understand, what do you mean?
claunia commented 2026-01-31 07:59:40 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jul 16, 2024):

This issue isn't about fixing the commands that I gave, but about fixing the implementation of the commands inside this project. The implementation is here: de50310295/src/buffer/out/Row.cpp (L760C24-L811)

The bug is that colEndDirty doesn't get set to colLimit.

@lhecker commented on GitHub (Jul 16, 2024): This issue isn't about fixing the commands that I gave, but about fixing the implementation of the commands inside this project. The implementation is here: https://github.com/microsoft/terminal/blob/de50310295b7d92ed3d51f07974a2a945776bf9d/src/buffer/out/Row.cpp#L760C24-L811 The bug is that `colEndDirty` doesn't get set to `colLimit`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output Issue-Bug Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21967
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?