starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Saving action without ID immediately erases it; no warning/error #21969

New Issue
Closed
opened 2026-01-31 07:59:39 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 07:59:39 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Jul 12, 2024).

Windows Terminal version

1.22.1831.0

Windows build number

26250.5000

Other Software

N/A

Steps to reproduce

  1. open settings.json
  2. in actions add the following:
        {
            "command": {
                "action": "openSuggestions",
                "source": "all",
                "useCommandline": false
            }
        },

Expected Behavior

A warning should appear saying that the JSON is invalid and Terminal should either (1) ignore the changes or (2) fall back to default settings

Actual Behavior

settings.json is immediately rewritten and the text I just added in disappeared!

Originally created by @carlos-zamora on GitHub (Jul 12, 2024). ### Windows Terminal version 1.22.1831.0 ### Windows build number 26250.5000 ### Other Software N/A ### Steps to reproduce 1. open settings.json 2. in `actions` add the following: ```js { "command": { "action": "openSuggestions", "source": "all", "useCommandline": false } }, ``` ### Expected Behavior A warning should appear saying that the JSON is invalid and Terminal should either (1) ignore the changes or (2) fall back to default settings ### Actual Behavior settings.json is immediately rewritten and the text I just added in disappeared!
claunia commented 2026-01-31 07:59:41 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 12, 2024):

I don't understand - it should have been assigned an ID, right?

@DHowett commented on GitHub (Jul 12, 2024): I don't understand - it should have been assigned an ID, right?
claunia commented 2026-01-31 07:59:41 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jul 12, 2024):

Oh totally. The JSON snippet is intentionally invalid because it's missing an ID. But, in the past, invalid JSON settings throw a warning/error when they get loaded and we don't overwrite the settings.json. For some reason, in this case, we do, and the invalid JSON that gets added disappears.

Also, given that the actions/keybindings split is relatively new, I'm concerned that this is a common case users may hit. I just wanted to add openSuggestions to the command palette, so I added the command without a keybinding attached (common practice before the split). Instead, I immediately had the snippet deleted upon saving the file.

@carlos-zamora commented on GitHub (Jul 12, 2024): Oh totally. The JSON snippet is intentionally invalid because it's missing an ID. But, in the past, invalid JSON settings throw a warning/error when they get loaded and we don't overwrite the settings.json. For some reason, in this case, we do, and the invalid JSON that gets added disappears. Also, given that the `actions`/`keybindings` split is relatively new, I'm concerned that this is a common case users may hit. I just wanted to add `openSuggestions` to the command palette, so I added the command without a keybinding attached (common practice before the split). Instead, I immediately had the snippet deleted upon saving the file.
claunia commented 2026-01-31 07:59:42 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 12, 2024):

Sorry, I mean: shouldn't the "expected behavior" be that we ADD an ID automatically?

@DHowett commented on GitHub (Jul 12, 2024): Sorry, I mean: shouldn't the "expected behavior" be that we ADD an ID automatically?
claunia commented 2026-01-31 07:59:42 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jul 12, 2024):

ah, good call. yeah!

@carlos-zamora commented on GitHub (Jul 12, 2024): ah, good call. yeah!
claunia commented 2026-01-31 07:59:42 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Aug 13, 2024):

Looked into this further. Turns out, openSuggestions doesn't exist. The actual key is supposed to be showSuggestions.

Thus, closing.

@carlos-zamora commented on GitHub (Aug 13, 2024): Looked into this further. Turns out, `openSuggestions` doesn't exist. The actual key is supposed to be `showSuggestions`. Thus, closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Needs-Tag-Fix Product-Terminal Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#21969
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?