starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Cursor desync in Far Manager #22019

New Issue
Closed
opened 2026-01-31 08:01:08 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 08:01:08 +00:00
Owner
Copy Link

Originally created by @o-sdn-o on GitHub (Jul 27, 2024).

Windows Terminal version

current main

Windows build number

10.0.19045.4651

Other Software

Far Manager, version 3.0.6352.0 x64

Steps to reproduce

  1. Launch the latest Far Manager.
  2. Press Ctrl+O to hide panels.
  3. Press Enter (run empty command).

Expected Behavior

The cursor should remain at the command line prompt.

Actual Behavior

The cursor unexpectedly moved to the lower right corner (conhost is ok ,WT is affected).

https://github.com/user-attachments/assets/a95f71c8-d13c-4b4c-ac5e-902ca6f46932

This issue came up right after #17194.

Originally created by @o-sdn-o on GitHub (Jul 27, 2024). ### Windows Terminal version current main ### Windows build number 10.0.19045.4651 ### Other Software Far Manager, version 3.0.6352.0 x64 ### Steps to reproduce 1. Launch the latest Far Manager. 2. Press `Ctrl+O` to hide panels. 3. Press `Enter` (run empty command). ### Expected Behavior The cursor should remain at the command line prompt. ### Actual Behavior The cursor unexpectedly moved to the lower right corner (conhost is ok ,WT is affected). https://github.com/user-attachments/assets/a95f71c8-d13c-4b4c-ac5e-902ca6f46932 This issue came up right after #17194.
claunia added the Needs-TriageIssue-Bug labels 2026-01-31 08:01:08 +00:00
claunia commented 2026-01-31 08:01:10 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jul 28, 2024):

As far as I can make out, we get a linefeed at the bottom of the page which triggers an InvalidateFlush setting the _circled flag. This occurs in a frame with no other changes, so the VtEngine::StartPaint doesn't think there's anything to do, and as a result we never execute the VtEngine::EndPaint, which is where the _circled flag is usually handled and reset.

The next thing that happens is that the cursor is moved to its expected position after the prompt, but the _circled flag will still be set when we paint the next frame, and that prevents the cursor from being "painted" (which is how its position is passed through to conpty). See the code here:

295cd17b02/src/renderer/vt/XtermEngine.cpp (L210-L213)

One possible fix would be to add the _circled flag to the list of things that are checked when determining whether there's something for the renderer to do, i.e. just add it to the condition here:

295cd17b02/src/renderer/vt/paint.cpp (L33-L37)

That seems to fix the issue for me, but I don't fully understand the circling behavior, so there might be more to it than that.

@j4james commented on GitHub (Jul 28, 2024): As far as I can make out, we get a linefeed at the bottom of the page which triggers an `InvalidateFlush` setting the `_circled` flag. This occurs in a frame with no other changes, so the `VtEngine::StartPaint` doesn't think there's anything to do, and as a result we never execute the `VtEngine::EndPaint`, which is where the `_circled` flag is usually handled and reset. The next thing that happens is that the cursor is moved to its expected position after the prompt, but the `_circled` flag will still be set when we paint the next frame, and that prevents the cursor from being "painted" (which is how its position is passed through to conpty). See the code here: https://github.com/microsoft/terminal/blob/295cd17b028d288ff81445f532d9301b44f6ffd9/src/renderer/vt/XtermEngine.cpp#L210-L213 One possible fix would be to add the `_circled` flag to the list of things that are checked when determining whether there's something for the renderer to do, i.e. just add it to the condition here: https://github.com/microsoft/terminal/blob/295cd17b028d288ff81445f532d9301b44f6ffd9/src/renderer/vt/paint.cpp#L33-L37 That seems to fix the issue for me, but I don't fully understand the circling behavior, so there might be more to it than that.
claunia commented 2026-01-31 08:01:10 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jul 29, 2024):

Does this issue repro in Windows Terminal Canary?

If it doesn't repro there, I'd personally like to avoid fixing VtEngine, because I don't fully understand the nuances of the circling behavior either. Seemingly innocent fixes in that area in the past have repeatedly caused regressions.

@lhecker commented on GitHub (Jul 29, 2024): Does this issue repro in Windows Terminal Canary? If it doesn't repro there, I'd personally like to avoid fixing `VtEngine`, because I don't fully understand the nuances of the circling behavior either. Seemingly innocent fixes in that area in the past have repeatedly caused regressions.
claunia commented 2026-01-31 08:01:11 +00:00
Author
Owner
Copy Link

@o-sdn-o commented on GitHub (Jul 29, 2024):

Does this issue repro in Windows Terminal Canary?

Isn't the current main branch the same thing? (this issue is reproducible on the current main branch)

@o-sdn-o commented on GitHub (Jul 29, 2024): > Does this issue repro in Windows Terminal Canary? Isn't the current main branch the same thing? (this issue is reproducible on the current main branch)
claunia commented 2026-01-31 08:01:11 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 29, 2024):

Isn't the current main branch the same thing?

Not currently. We're building Canary out of a merge between a couple in-flight branches right now.

@DHowett commented on GitHub (Jul 29, 2024): > Isn't the current main branch the same thing? Not currently. We're building Canary out of a merge between a couple in-flight branches right now.
claunia commented 2026-01-31 08:01:12 +00:00
Author
Owner
Copy Link

@o-sdn-o commented on GitHub (Jul 29, 2024):

This issue is not reproducible in the dev/lhecker/goodbye-vtengine branch.

@o-sdn-o commented on GitHub (Jul 29, 2024): This issue is not reproducible in the [`dev/lhecker/goodbye-vtengine`](https://github.com/microsoft/terminal/tree/dev/lhecker/goodbye-vtengine) branch.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22019
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?