starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Both WT and Powershell are great, but the startup is a little slow when combined together. And my some thoughts. #22041

New Issue
Closed
opened 2026-01-31 08:01:46 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 08:01:46 +00:00
Owner
Copy Link

Originally created by @flyingcat on GitHub (Aug 1, 2024).

Description of the new feature/enhancement

As the title described. On my computer(AMD Ryzen 3600, even slower on Snapdragon 8cx Gen 3):

→ D:\tmpdir\terminal-1.22.2081.0
> Measure-Command { Start-Process .\WindowsTerminal.exe -PassThru 'pwsh','-c','exit' | Wait-Process } | % TotalMilliseconds
757.2283

I do want to help, but after some digging into the code, it quickly turn out that its complexity is far beyond my level. However I think the ideas maybe somehow helpful for core team, so I just take some time to this.

Proposed technical implementation details (optional)

  1. Start profile's command line as early as possible, ideally right after settings loaded. Then the startup of pwsh.exe will overlap with UI initialization. However I don't know it's valid or not, as I am not familiar with terminal things.
    image

  2. Made subsequent process run faster. Currently it need to load the whole settings to get the value of compatibility.isolatedMode , which in turn cause time-consuming WindowsXamlManager::InitializeForCurrentThread() in App::App(). It should be avoided, or better, avoid loading the whole settings too.

    → D:\tmpdir\terminal-1.22.2081.0
> .\WindowsTerminal.exe; Start-Sleep 2; Measure-Command { Start-Process .\WindowsTerminal.exe -PassThru | Wait-Process } | % TotalMilliseconds
175.0779

  3. Create spare window thread on idle time after new window showed. Add an option to allow keep running in background just like Edge and tweak auto launch on boot to adapt it. Now event if the first is hard to implement and pwsh.exe is still slow to start, we at least always get quick UI response.

Originally created by @flyingcat on GitHub (Aug 1, 2024). # Description of the new feature/enhancement As the title described. On my computer(AMD Ryzen 3600, even slower on Snapdragon 8cx Gen 3): ```powershell → D:\tmpdir\terminal-1.22.2081.0 > Measure-Command { Start-Process .\WindowsTerminal.exe -PassThru 'pwsh','-c','exit' | Wait-Process } | % TotalMilliseconds 757.2283 ``` I do want to help, but after some digging into the code, it quickly turn out that its complexity is far beyond my level. However I think the ideas maybe somehow helpful for core team, so I just take some time to this. # Proposed technical implementation details (optional) 1. Start profile's command line as early as possible, ideally right after settings loaded. Then the startup of pwsh.exe will overlap with UI initialization. However I don't know it's valid or not, as I am not familiar with terminal things. ![image](https://github.com/user-attachments/assets/b6705d47-3636-43b9-8797-fea21bd1476d) 2. Made subsequent process run faster. Currently it need to load the whole settings to get the value of `compatibility.isolatedMode` , which in turn cause time-consuming `WindowsXamlManager::InitializeForCurrentThread()` in `App::App()`. It should be avoided, or better, avoid loading the whole settings too. ```powershell → D:\tmpdir\terminal-1.22.2081.0 > .\WindowsTerminal.exe; Start-Sleep 2; Measure-Command { Start-Process .\WindowsTerminal.exe -PassThru | Wait-Process } | % TotalMilliseconds 175.0779 ``` 3. Create spare window thread on idle time after new window showed. Add an option to allow keep running in background just like Edge and tweak auto launch on boot to adapt it. Now event if the first is hard to implement and pwsh.exe is still slow to start, we at least always get quick UI response.
claunia added the Issue-FeatureNeeds-TriageNeeds-Tag-Fix labels 2026-01-31 08:01:46 +00:00
claunia commented 2026-01-31 08:01:47 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Aug 1, 2024):

I like your first 2 suggestions. I did plan to try and make the app launch faster for the next release after this one (i.e. we're currently working on 1.22 which will release in a month, and I'd like to investigate it afterwards in 1.23).

The 3rd point (Edge-style auto-launch on boot) is something I dislike. Instead of not hurting the victim outright (the user), you simply hurt the victim secretly when they don't pay attention, which is IMO morally reprehensible. It doesn't achieve any lasting progress, and in fact it may lower our chances from getting the fundamental issue fixed (which is Edge's and WinUI's continuously worsening performance). (However, I don't mind keeping an instance of WT running after it first launched, which I is something we already support.)

@lhecker commented on GitHub (Aug 1, 2024): I like your first 2 suggestions. I did plan to try and make the app launch faster for the next release after this one (i.e. we're currently working on 1.22 which will release in a month, and I'd like to investigate it afterwards in 1.23). The 3rd point (Edge-style auto-launch on boot) is something I dislike. Instead of not hurting the victim outright (the user), you simply hurt the victim secretly when they don't pay attention, which is IMO morally reprehensible. It doesn't achieve any lasting progress, and in fact it may lower our chances from getting the fundamental issue fixed (which is Edge's and WinUI's continuously worsening performance). (However, I don't mind keeping an instance of WT running after it first launched, which I is something we already support.)
claunia commented 2026-01-31 08:01:47 +00:00
Author
Owner
Copy Link

@flyingcat commented on GitHub (Aug 1, 2024):

The 3rd point (Edge-style auto-launch on boot) is something I dislike. Instead of not hurting the victim outright (the user), you simply hurt the victim secretly when they don't pay attention, which is IMO morally reprehensible. It doesn't achieve any lasting progress, and in fact it may lower our chances from getting the fundamental issue fixed (which is Edge's and WinUI's continuously worsening performance). (However, I don't mind keeping an instance of WT running after it first launched, which I is something we already support.)

Yes, It's already implemented 👍 https://learn.microsoft.com/en-us/windows/terminal/customize-settings/startup#continue-running-in-the-background-preview

I think you maybe misunderstood me. I don't mean auto launch secretly. I mean combine startOnUserLogin with compatibility.allowHeadless: launch quietly with showing a tray icon, just like a dictionary App or something similar.

Is this on purpose or just a bug, all windows closed.
image

@flyingcat commented on GitHub (Aug 1, 2024): > The 3rd point (Edge-style auto-launch on boot) is something I dislike. Instead of not hurting the victim outright (the user), you simply hurt the victim secretly when they don't pay attention, which is IMO morally reprehensible. It doesn't achieve any lasting progress, and in fact it may lower our chances from getting the fundamental issue fixed (which is Edge's and WinUI's continuously worsening performance). (However, I don't mind keeping an instance of WT running after it first launched, which I is something we already support.) Yes, It's already implemented 👍 https://learn.microsoft.com/en-us/windows/terminal/customize-settings/startup#continue-running-in-the-background-preview I think you maybe misunderstood me. I don't mean auto launch secretly. I mean combine `startOnUserLogin` with `compatibility.allowHeadless`: launch quietly with showing a tray icon, just like a dictionary App or something similar. ------ Is this on purpose or just a bug, all windows closed. ![image](https://github.com/user-attachments/assets/b2677842-4282-466f-b60c-1ea4423dc395)
claunia commented 2026-01-31 08:01:48 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Aug 1, 2024):

That's a bug for sure. I believe we've already come across this before. We're tracking parts of that issue in #17420 among others.

@lhecker commented on GitHub (Aug 1, 2024): That's a bug for sure. I believe we've already come across this before. We're tracking parts of that issue in #17420 among others.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Feature Needs-Tag-Fix Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22041
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?