starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Terminal cannot be opened after adjusting the language #22079

New Issue
Closed
opened 2026-01-31 08:02:52 +00:00 by claunia · 10 comments
claunia commented 2026-01-31 08:02:52 +00:00
Owner
Copy Link

Originally created by @Goo-aw233 on GitHub (Aug 10, 2024).

Windows Terminal version

1.22.2221.0

Windows build number

10.0.26257.5000

Other Software

No response

Steps to reproduce

Open Settings > Appearance > Language > 中文(简体) > Save
Afterwards, close the Settings tab and reopen it. Changing any function and clicking Save will cause the program to crash.
Any language can cause this problem.

Expected Behavior

No response

Actual Behavior

After saving the above changes, Terminal Canary will crash, and after stopping, repairing, or resetting the program, it will not be able to open the program again, and will need to be uninstalled and reinstalled.

Terminal Preview 1.21.1772.0 does not have this problem.

In addition, this is the DMP that is automatically generated after the program crashes.

WindowsTerminal.exe.18664.dmp

Originally created by @Goo-aw233 on GitHub (Aug 10, 2024). ### Windows Terminal version 1.22.2221.0 ### Windows build number 10.0.26257.5000 ### Other Software _No response_ ### Steps to reproduce Open Settings > Appearance > Language > 中文(简体) > Save Afterwards, close the Settings tab and reopen it. Changing any function and clicking Save will cause the program to crash. Any language can cause this problem. ### Expected Behavior _No response_ ### Actual Behavior After saving the above changes, Terminal Canary will crash, and after stopping, repairing, or resetting the program, it will not be able to open the program again, and will need to be uninstalled and reinstalled. Terminal Preview 1.21.1772.0 does not have this problem. In addition, this is the DMP that is automatically generated after the program crashes. [WindowsTerminal.exe.18664.dmp](https://github.com/user-attachments/files/16570297/WindowsTerminal.exe.18664.dmp)
claunia commented 2026-01-31 08:02:54 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Aug 12, 2024):

@DHowett How would you like your bad MSVC news today?

@lhecker commented on GitHub (Aug 12, 2024): @DHowett How would you like your bad MSVC news today?
claunia commented 2026-01-31 08:02:54 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 12, 2024):

Preferably “actionable so we stop getting knocked over by compiler bugs every eight minutes”

@DHowett commented on GitHub (Aug 12, 2024): Preferably “actionable so we stop getting knocked over by compiler bugs every eight minutes”
claunia commented 2026-01-31 08:02:55 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 20, 2024):

@lhecker scale of 1-10, how bad is this? This sounds like it's ship blocking

@zadjii-msft commented on GitHub (Aug 20, 2024): @lhecker scale of 1-10, how bad is this? This sounds like it's ship blocking
claunia commented 2026-01-31 08:02:55 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Aug 20, 2024):

I would try disabling PGO as a test. It's possible that it's because I'm using VS 17.11 (and now .12), but this issue doesn't repro for me in local Release builds. Alternatively, we could find a way to get a OneBranch 17.11 image.

@lhecker commented on GitHub (Aug 20, 2024): I would try disabling PGO as a test. It's possible that it's because I'm using VS 17.11 (and now .12), but this issue doesn't repro for me in local Release builds. Alternatively, we could find a way to get a OneBranch 17.11 image.
claunia commented 2026-01-31 08:02:55 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Aug 21, 2024):

Disabling PGO worked: The crash is now fixed in 1.22.2334.0.

@lhecker commented on GitHub (Aug 21, 2024): Disabling PGO worked: The crash is now fixed in 1.22.2334.0.
claunia commented 2026-01-31 08:02:55 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 21, 2024):

Okay, so what's the next step here? We can't disable PGO for a real release. Do we just need to roll back the PGO CI to an older VS version?

@zadjii-msft commented on GitHub (Aug 21, 2024): Okay, so what's the next step here? We can't disable PGO for a real release. Do we just need to roll back the PGO CI to an older VS version?
claunia commented 2026-01-31 08:02:56 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 21, 2024):

We can't disable PGO for a real release.

Why not?

Leonard had this to say:

Is there a reason why PGO must be enabled? I thought it's just an optimization.

FWIW, the bug is not in the generation of PGO data (which as of today is on VS 17.11) but in the consumption of it (which is in a onebranch pipeline that is stuck on VS 17.10 -- the known bad compiler.)

@DHowett commented on GitHub (Aug 21, 2024): > We can't disable PGO for a real release. Why not? Leonard had this to say: > Is there a reason why PGO must be enabled? I thought it's just an optimization. --- FWIW, the bug is not in the generation of PGO data (which as of today is on VS 17.11) but in the consumption of it (which is in a onebranch pipeline that is stuck on VS 17.10 -- the known bad compiler.)
claunia commented 2026-01-31 08:02:56 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Aug 21, 2024):

Disabling PGO caused a ~13% regression in my testing. It's still magnitudes faster than what it used to be though, so I think we'll be fine even if we never enabled it again. (I think we should though, because PGO is technically really nice.)

@lhecker commented on GitHub (Aug 21, 2024): Disabling PGO caused a ~13% regression in my testing. It's still magnitudes faster than what it used to be though, so I think we'll be fine even if we never enabled it again. (I think we should though, because PGO is technically really nice.)
claunia commented 2026-01-31 08:02:56 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Aug 21, 2024):

Since this is now fixed on Canary, and we have a plan moving forward, I'm closing this. Thanks all!

@carlos-zamora commented on GitHub (Aug 21, 2024): Since this is now fixed on Canary, and we have a plan moving forward, I'm closing this. Thanks all!
claunia commented 2026-01-31 08:02:56 +00:00
Author
Owner
Copy Link

@Andarwinux commented on GitHub (Aug 22, 2024):

Maybe consider trying to use clang-cl.

@Andarwinux commented on GitHub (Aug 22, 2024): Maybe consider trying to use clang-cl.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Issue-Bug Needs-Tag-Fix Product-Terminal Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22079
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?