starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Potential crash when calling ITerminalConnection::WriteInput #22082

New Issue
Closed
opened 2026-01-31 08:02:59 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 08:02:59 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Aug 10, 2024).

Windows Terminal version

Commit edfa3ea0f0

Windows build number

10.0.19045.4651

Other Software

No response

Steps to reproduce

  1. Patch the DeviceAttributes implementation in adaptDispatch.cpp to respond like this: 
    _api.ReturnResponse({L"ABCD", 3});
  2. Open a WSL shell in OpenConsole and execute this: 
    printf "\e[c"; read
  3. Note that it successfully responds with ABC.
  4. Now try the same thing in a WSL shell from within Windows Terminal.

Expected Behavior

It should also respond successfully with ABC.

Actual Behavior

The terminal crashes.

The ReturnResponse method takes a std::wstring_view, but the Windows Terminal implementation calls ControlCore::_sendInputToConnection, which calls ITerminalConnection::WriteInput, which expects an hstring. When constructing an hstring from a std::wstring_view it's required that the string be null-terminated, otherwise it aborts. And since std::wstring_view is obviously not guaranteed to be null-terminated, this is asking for trouble.

I know the example I've given above is contrived, but that's just because it was the easiest way to demonstrate the problem. There are a number of places in the AdaptDispatch class that are calling ReturnResponse with a fmt::basic_memory_buffer, and that's not guaranteed to be null-terminated. It's just a matter of luck whether that code crashes or not.

Originally created by @j4james on GitHub (Aug 10, 2024). ### Windows Terminal version Commit edfa3ea0f0080eadf7f01b463ed0a8638de6ce04 ### Windows build number 10.0.19045.4651 ### Other Software _No response_ ### Steps to reproduce 1. Patch the `DeviceAttributes` implementation in adaptDispatch.cpp to respond like this: ```cpp _api.ReturnResponse({L"ABCD", 3}); ``` 2. Open a WSL shell in OpenConsole and execute this: ``` printf "\e[c"; read ``` 3. Note that it successfully responds with `ABC`. 4. Now try the same thing in a WSL shell from within Windows Terminal. ### Expected Behavior It should also respond successfully with `ABC`. ### Actual Behavior The terminal crashes. The `ReturnResponse` method takes a `std::wstring_view`, but the Windows Terminal implementation calls `ControlCore::_sendInputToConnection`, which calls `ITerminalConnection::WriteInput`, which expects an `hstring`. When constructing an `hstring` from a `std::wstring_view` it's required that the string be null-terminated, otherwise it aborts. And since `std::wstring_view` is obviously not guaranteed to be null-terminated, this is asking for trouble. I know the example I've given above is contrived, but that's just because it was the easiest way to demonstrate the problem. There are a number of places in the `AdaptDispatch` class that are calling `ReturnResponse` with a `fmt::basic_memory_buffer`, and that's not guaranteed to be null-terminated. It's just a matter of luck whether that code crashes or not.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalConnection In-PR Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22082
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?