starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Crash when switching back from the alt buffer #22089

New Issue
Closed
opened 2026-01-31 08:03:08 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 08:03:08 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Aug 13, 2024).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version

Commit edfa3ea0f0

Windows build number

10.0.19045.4651

Other Software

No response

Steps to reproduce

It's not easy to reproduce, but I think all you really need to trigger the crash is to switch to the alt buffer with printf "\e[?1049h", and then switch back to the main buffer with printf "\e[?1049l".

This is in Windows Terminal using a build that includes the new VT passthrough (PR #17510).

Expected Behavior

The terminal should not crash.

Actual Behavior

I got an access violation accessing the screenInfo parameter in the WriteCharsVT function here:

0199ca33dd/src/host/_stream.cpp (L353)

What happens is that we first pass the \e[?1049l sequence through to conhost in the stateMachine.ProcessString call a couple of lines above. That ends up calling SCREEN_INFORMATION::UseMainScreenBuffer, which calls s_RemoveScreenBuffer(psiAlt), which deletes the active screenInfo instance here:

0199ca33dd/src/host/screenInfo.cpp (L231)

That's the same screenInfo instance that was passed to our WriteCharsVT function, so when we later try to reference that, we're referencing a deleted object. Sometimes we get lucky and nothing bad happens, but sometimes it will crash.

I think maybe all we need to do to prevent the crash is to save the screenInfo.OutputMode at the start of the function, and then use that saved value instead of trying to look it up via the screenInfo object.

Originally created by @j4james on GitHub (Aug 13, 2024). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version Commit edfa3ea0f0080eadf7f01b463ed0a8638de6ce04 ### Windows build number 10.0.19045.4651 ### Other Software _No response_ ### Steps to reproduce It's not easy to reproduce, but I think all you really need to trigger the crash is to switch to the alt buffer with `printf "\e[?1049h"`, and then switch back to the main buffer with `printf "\e[?1049l"`. This is in Windows Terminal using a build that includes the new VT passthrough (PR #17510). ### Expected Behavior The terminal should not crash. ### Actual Behavior I got an access violation accessing the `screenInfo` parameter in the `WriteCharsVT` function here: https://github.com/microsoft/terminal/blob/0199ca33ddb4a02ca3549627d772ce6b330ed1ce/src/host/_stream.cpp#L353 What happens is that we first pass the `\e[?1049l` sequence through to conhost in the `stateMachine.ProcessString` call a couple of lines above. That ends up calling `SCREEN_INFORMATION::UseMainScreenBuffer`, which calls `s_RemoveScreenBuffer(psiAlt)`, which deletes the active `screenInfo` instance here: https://github.com/microsoft/terminal/blob/0199ca33ddb4a02ca3549627d772ce6b330ed1ce/src/host/screenInfo.cpp#L231 That's the same `screenInfo` instance that was passed to our `WriteCharsVT` function, so when we later try to reference that, we're referencing a deleted object. Sometimes we get lucky and nothing bad happens, but sometimes it will crash. I think maybe all we need to do to prevent the crash is to save the `screenInfo.OutputMode` at the start of the function, and then use that saved value instead of trying to look it up via the `screenInfo` object.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output In-PR Issue-Bug Needs-Tag-Fix Product-Terminal Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22089
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?