starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

The URL highlighting fade effect may look unpleasant with TUI programs #22103

New Issue
Open
opened 2026-01-31 08:03:32 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 08:03:32 +00:00
Owner
Copy Link

Originally created by @Zeroes1 on GitHub (Aug 16, 2024).

Windows Terminal version

1.21.1772.0

Windows build number

10.0.19045.3448

Other Software

Far Manager 3.0.6359.0 x64

Steps to reproduce

Run FAR Manager
create new file, insert line:
https://aka.ms/terminal-documentation
save

set mouse cursor over URL
press Esc (exit from editor to panel)

Expected Behavior

no strange visual effects

Actual Behavior

Effect of fade highlight URLs may be strange look (as flickering line)
with TUI programs for example FAR Manager (in example Video when exit from editor).

https://github.com/user-attachments/assets/1a474490-e660-4ab5-a554-72792c67b0d7

Originally created by @Zeroes1 on GitHub (Aug 16, 2024). ### Windows Terminal version 1.21.1772.0 ### Windows build number 10.0.19045.3448 ### Other Software Far Manager 3.0.6359.0 x64 ### Steps to reproduce Run FAR Manager create new file, insert line: https://aka.ms/terminal-documentation save set mouse cursor over URL press Esc (exit from editor to panel) ### Expected Behavior no strange visual effects ### Actual Behavior Effect of fade highlight URLs may be strange look (as flickering line) with TUI programs for example FAR Manager (in example Video when exit from editor). https://github.com/user-attachments/assets/1a474490-e660-4ab5-a554-72792c67b0d7
claunia added the Issue-BugPriority-3Product-TerminalArea-UserInterface labels 2026-01-31 08:03:32 +00:00
claunia commented 2026-01-31 08:03:33 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Aug 16, 2024):

We did this to improve the performance of the application. Scanning for URLs all the time is somewhat expensive after all.
To fix this we could hide all URL underlines whenever there's output and only show them when there hasn't been any new output for a while. I think that may be look a lot better, but it's possible that this may result in similar edge cases.

@lhecker commented on GitHub (Aug 16, 2024): We did this to improve the performance of the application. Scanning for URLs all the time is somewhat expensive after all. To fix this we could hide all URL underlines whenever there's output and only show them when there hasn't been any new output for a while. I think that may be look a lot better, but it's possible that this may result in similar edge cases.
claunia commented 2026-01-31 08:03:33 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 19, 2024):

Another possible heuristic we could try: hide them if there's ever a frame that invalidates the whole buffer? Clearly Far isn't using alt buffers here, so we can't use that as the heuristic. But a full-frame invalidation seems like it would suggest the whole thing changed like the way a full-viewport app would.

There's also the xterm.js suggestion where we just don't do the URL scanning at all anymore. They just scan the row the mouse pointer is on, and check if that text is a URL. Not sure we're tracking that anywhere

@zadjii-msft commented on GitHub (Aug 19, 2024): Another possible heuristic we could try: hide them if there's ever a frame that invalidates the whole buffer? Clearly Far isn't using alt buffers here, so we can't use that as the heuristic. But a full-frame invalidation seems like it would suggest the whole thing changed like the way a full-viewport app would. There's also the xterm.js suggestion where we just don't do the URL scanning at all anymore. They just scan the row the mouse pointer is on, and check if that text is a URL. Not sure we're tracking that anywhere
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22103
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?