starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

The "Overwrite key binding" warning is very broken #22120

New Issue
Closed
opened 2026-01-31 08:03:55 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 08:03:55 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Aug 20, 2024).

Originally assigned to: @PankajBhojwani on GitHub.

(from bug bash 1.22)

Action Editor
🛑 "Overwrite key binding" warning is very broken

image
(thats right, I had to take a screenshot of the image in Loop, thanks Loop)

I can't say "no". Dismissing it is like saying "yes". Also it scrolls horizontally.

Originally created by @zadjii-msft on GitHub (Aug 20, 2024). Originally assigned to: @PankajBhojwani on GitHub. (from bug bash 1.22) Action Editor 🛑 "Overwrite key binding" warning is very broken ![image](https://github.com/user-attachments/assets/0cdbab01-b1d4-4963-b04e-9691b9ae2000) _(thats right, I had to take a screenshot of the image in Loop, thanks Loop)_ I can't say "no". Dismissing it is like saying "yes". Also it scrolls horizontally.
claunia added the Issue-BugIn-PRNeeds-Tag-FixProduct-TerminalArea-SettingsUI labels 2026-01-31 08:03:55 +00:00
claunia commented 2026-01-31 08:03:56 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 20, 2024):

/cc @PankajBhojwani since I believe you were the last one to touch Actions

@zadjii-msft commented on GitHub (Aug 20, 2024): /cc @PankajBhojwani since I believe you were the last one to touch Actions
claunia commented 2026-01-31 08:03:57 +00:00
Author
Owner
Copy Link

@PankajBhojwani commented on GitHub (Aug 21, 2024):

I'm somewhat certain this is the way it worked before my changes as well (I see this same behaviour in Stable)

@PankajBhojwani commented on GitHub (Aug 21, 2024): I'm somewhat certain this is the way it worked before my changes as well (I see this same behaviour in Stable)
claunia commented 2026-01-31 08:03:57 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 21, 2024):

I see this same behaviour in Stable

I do not. Dismissing the flyout does not "confirm" and overwrite the binding in Stable.

@DHowett commented on GitHub (Aug 21, 2024): > I see this same behaviour in Stable I do not. Dismissing the flyout does not "confirm" and overwrite the binding in Stable.
claunia commented 2026-01-31 08:03:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 21, 2024):

Dismissing the flyout does confirm for me in 1.21. So maybe it regressed in 20->21?

@zadjii-msft commented on GitHub (Aug 21, 2024): Dismissing the flyout does confirm for me in 1.21. So maybe it regressed in 20->21?
claunia commented 2026-01-31 08:03:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 21, 2024):

I wonder if it's something more subtle in XAML somewhere. Cause like, on 1.20, when you hit the checkbox button, the action stays in the "editing" state, with the textbox and the buttons. But in 1.21, the button immediately exits the editing state, then pops the "are you sure"?

@zadjii-msft commented on GitHub (Aug 21, 2024): I wonder if it's something more subtle in XAML somewhere. Cause like, on 1.20, when you **hit the checkbox button**, the action stays in the "editing" state, with the textbox and the buttons. But in 1.21, the button immediately exits the editing state, then pops the "are you sure"?
claunia commented 2026-01-31 08:03:58 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 21, 2024):

Much more likely that it was from #14292, which rewrote the action view model (and it should be the viewmodel that keeps track of states like this.)

@DHowett commented on GitHub (Aug 21, 2024): Much more likely that it was from #14292, which rewrote the action view model (and it should be the viewmodel that keeps track of states like this.)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI In-PR Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22120
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?