starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Dim terminal when app terminates #22137

New Issue
Open
opened 2026-01-31 08:04:31 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 08:04:31 +00:00
Owner
Copy Link

Originally created by @elad-eyal-ns on GitHub (Aug 22, 2024).

I have a profile which is used for SSH. When the connection is lost, I get a message saying the process has terminated and I am to press ENTER to restart. It's not always easy to spot this message, since it can appear at the top or middle of the screen (wherever the cursor happened to be). I propose that at this time (optionally) dim the entire window. This way it will be easier to notice the app termination and hit ENTER before continuing.

Originally created by @elad-eyal-ns on GitHub (Aug 22, 2024). I have a profile which is used for SSH. When the connection is lost, I get a message saying the process has terminated and I am to press ENTER to restart. It's not always easy to spot this message, since it can appear at the top or middle of the screen (wherever the cursor happened to be). I propose that at this time (optionally) dim the entire window. This way it will be easier to notice the app termination and hit ENTER before continuing.
claunia added the Issue-FeatureProduct-TerminalArea-UserInterface labels 2026-01-31 08:04:31 +00:00
claunia commented 2026-01-31 08:04:32 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 4, 2024):

Thanks for the request! For what it's worth... we have another visual indicator that the connection has been broken:

Image

We're not likely to prioritize the "appearance matrix" work required to support the combinations of {terminated/running, admin/non-admin, focused/unfocused} required to make this possible, so we're committing it to the distant distant backlog for now.

@DHowett commented on GitHub (Sep 4, 2024): Thanks for the request! For what it's worth... we have another visual indicator that the connection has been broken: ![Image](https://github.com/user-attachments/assets/dade8a04-c19a-4dc8-86c7-16b7eaeb13a9) We're not likely to prioritize the "appearance matrix" work required to support the combinations of {terminated/running, admin/non-admin, focused/unfocused} required to make this possible, so we're committing it to the distant distant backlog for now.
claunia commented 2026-01-31 08:04:32 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 4, 2024):

and my stupid idea from triage:

  • connection dead? ---> deadConnectionAppearance
  • alive?
    • unfocused? ---> unfocusedAppearance
    • focused?
      • admin? ---> adminAppearance
      • standard ---> defaultAppearance
@zadjii-msft commented on GitHub (Sep 4, 2024): and my stupid idea from triage: * connection dead? ---> deadConnectionAppearance * alive? * unfocused? ---> unfocusedAppearance * focused? * admin? ---> adminAppearance * standard ---> defaultAppearance
claunia commented 2026-01-31 08:04:32 +00:00
Author
Owner
Copy Link

@elad-eyal commented on GitHub (Sep 5, 2024):

Thanks for the request! For what it's worth... we have another visual indicator that the connection has been broken:

Image

what is "another visual indicator" ? the two lines of text? when using ssh and tmux they tend to appear anywhere on screen, hiding between whatever text happens to be on screen. it is not as clear as in the demo image you placed.

@elad-eyal commented on GitHub (Sep 5, 2024): > Thanks for the request! For what it's worth... we have another visual indicator that the connection has been broken: > > ![Image](https://github.com/user-attachments/assets/dade8a04-c19a-4dc8-86c7-16b7eaeb13a9) > what is "another visual indicator" ? the two lines of text? when using ssh and tmux they tend to appear anywhere on screen, hiding between whatever text happens to be on screen. it is not as clear as in the demo image you placed.
claunia commented 2026-01-31 08:04:32 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 5, 2024):

Good point.

It’s the (x) which appears to the left of the title. It’s visible in the tab.

@DHowett commented on GitHub (Sep 5, 2024): Good point. It’s the (x) which appears to the left of the title. It’s visible in the tab.
claunia commented 2026-01-31 08:04:33 +00:00
Author
Owner
Copy Link

@hi2u commented on GitHub (Feb 6, 2025):

I posted a similar issue #18489 a few days ago, didn't find this one here at the time.

@carlos-zamora's reply in #18489:

A consistent problem we've been running into is that we need a way to resolve combined states (i.e. admin session that is unfocused).

@DHowett's reply here:

We're not likely to prioritize the "appearance matrix" work required to support the combinations

Yeah fair enough, that could be over-complicating it.

For each of these "binary states" we're doubling the total number of combined states for the whole program. And I don't think it should be dictated how the prioritization works anyway. Especially when there's the possibilities of having 3+ of these competing binary states... 3 binary states is already 8 combined states seeing we're doubling for each one... and maybe more will come in the future.

People have their own priorities, and they might even have differing priorities amongst their own profiles.

Maybe the simplest + most flexible solution would just to be to use an array. i.e. rather than unfocusedAppearance etc being keys in the top-level profile object, they're just a type field in an array of objects, i.e.

OLD (what we have now)

{
    "name": "My Profile Name",
    "commandline": "the_command.exe",
    "guid": "{23516c80-6c27-41ec-9049-4a56b1511a5d}",
    "background": "#000000",
    "unfocusedAppearance": {
        "background": "#680909",
    }
},

NEW

{
    "name": "My Profile Name",
    "commandline": "the_command.exe",
    "guid": "{23516c80-6c27-41ec-9049-4a56b1511a5d}",
    "appearances": [
        {
            "type": "defaultAppearance",
            "background": "#000000",
        },
        {
            "type": "unfocusedAppearance",
            "background": "#680909",
        },
        {
            "type": "deadProcessAppearance",
            "background": "#838996",
        },
    ]
},

All of the currently applicable "binary states" in the appearances array are merged, and any "competing" overlapping settings such as background will "win" based on either being first or last matching state in the array (pretty similar to how firewall rules get applied).

"Last match wins" probably makes more sense to me seeing it's merging settings rather than doing a "hard stop" that only applies one of the states that ignores the rest that also apply. And you'll usually have "default" at the top, and you get more "niche" as you read downward. Pretty easy to read, and probably simpler to code too (JS example below).

This would give users full flexibility for their own priorities, including when they differ for different profiles. And is pretty future-proof if more of these "binary states" are added later.

Whether or not defaultAppearance is included in the array, or just remains top-level settings is a separate decision I guess. Not really needed for this request in general, but could be considered later on if you wanted to clean up all the properties in the top-level.

Shouldn't be too hard to code hopefully either? It's just looping through an array and overwriting applicable values in the final merged appearance object. I know Terminal is written in C++, but just an an example of how it would be done pretty easily in JS with Array.reduce()....

@hi2u commented on GitHub (Feb 6, 2025): I posted a similar issue #18489 a few days ago, didn't find this one here at the time. @carlos-zamora's reply in #18489: > A consistent problem we've been running into is that we need a way to resolve combined states (i.e. admin session that is unfocused). @DHowett's reply here: > We're not likely to prioritize the "appearance matrix" work required to support the combinations Yeah fair enough, that could be over-complicating it. For each of these "binary states" we're doubling the total number of combined states for the whole program. And I don't think it should be dictated how the prioritization works anyway. Especially when there's the possibilities of having 3+ of these competing binary states... 3 binary states is already 8 combined states seeing we're doubling for each one... and maybe more will come in the future. People have their own priorities, and they might even have differing priorities amongst their own profiles. Maybe the simplest + most flexible solution would just to be to use an array. i.e. rather than `unfocusedAppearance` etc being keys in the top-level profile object, they're just a `type` field in an array of objects, i.e. ### OLD (what we have now) ```json { "name": "My Profile Name", "commandline": "the_command.exe", "guid": "{23516c80-6c27-41ec-9049-4a56b1511a5d}", "background": "#000000", "unfocusedAppearance": { "background": "#680909", } }, ``` ### NEW ```json { "name": "My Profile Name", "commandline": "the_command.exe", "guid": "{23516c80-6c27-41ec-9049-4a56b1511a5d}", "appearances": [ { "type": "defaultAppearance", "background": "#000000", }, { "type": "unfocusedAppearance", "background": "#680909", }, { "type": "deadProcessAppearance", "background": "#838996", }, ] }, ``` All of the currently applicable "binary states" in the `appearances` array are merged, and any "competing" overlapping settings such as `background` will "win" based on either being first or last matching state in the array (pretty similar to how firewall rules get applied). "Last match wins" probably makes more sense to me seeing it's merging settings rather than doing a "hard stop" that only applies one of the states that ignores the rest that also apply. And you'll usually have "default" at the top, and you get more "niche" as you read downward. Pretty easy to read, and probably simpler to code too (JS example below). This would give users full flexibility for their own priorities, including when they differ for different profiles. And is pretty future-proof if more of these "binary states" are added later. Whether or not `defaultAppearance` is included in the array, or just remains top-level settings is a separate decision I guess. Not really needed for this request in general, but could be considered later on if you wanted to clean up all the properties in the top-level. Shouldn't be too hard to code hopefully either? It's just looping through an array and overwriting applicable values in the final merged `appearance` object. I know Terminal is written in C++, [but just an an example of how it would be done pretty easily in JS with Array.reduce()....](https://www.typescriptlang.org/play/?#code/MYewdgzgLgBAhgBwQUzgJzmYyIwLwwwDaAUIYQN5nk0BEUAnirQFwy0AmyAZnAK4AbKAEEkqDFmS14uUJCgAaajUK0ARnGABrAOZoQfMB1bsAxAAZLV2kpoBfW+Sory9JlLa1D3EMD4RkDlEUdExsaThZcGhHF3VNXX1DY09TADYADnMAThybZRgHAucXdkZmTy44DgAFfWwICGDxMKkZGDkYgroNbT0DIxNaUwyAZgzs7LT8+yUAXQBuEhJuQ2AoAEtwGA2IAH1EBAEN4Dg1AWQ96DgoZAAKcuQWAHIuXkERMVDJZ4AfZ+8vn8gWa32wf1eqFq9RwTS+EnBAEoWGoQCALpgYCVCGhkFA+GgwDAALI3AAWADoJBwQABbO6ImAAHhg5gpAFYlnZlp1YLTkGgdIF8PB4a0IFTAnxsHcCndNH5aQoOgTcWAoIi8AA+LHdcgbbgwO67A5IY6nc6Xa63O5+NBqqAUx6IxnY0o4vEEolu900Cn+hV8JV630wf0Uu0O2K+7khwowZACAK60Me-GE+DARVLd3c2bFPPkRk86Lo5AUgQgHR3fmCwKIpbLIA)
claunia commented 2026-01-31 08:04:33 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 7, 2025):

Moving a comment out of the triage thread

Image

appearances with when field. the user solves the combinatorial matrix. also actions with a when field like VS Code. some of our whens are provided by default. one of the whens could be connectionTerminated ... and

  • appearance + connectionTerminated = change color when process dies
  • action + connectionTerminated = move ^D and Enter actions out of ConptyConnection

some keywords to find this thread faster next time: conditional appearance combinatorial appearances matrix focused admin unfocused dead connection theme light dark

@zadjii-msft commented on GitHub (Feb 7, 2025): Moving a comment out of the triage thread > ![Image](https://github.com/user-attachments/assets/b414bcb8-f499-4f5f-9327-a77c0758d77d) > > appearances with `when` field. the user solves the combinatorial matrix. also `actions` with a `when` field like VS Code. some of our `when`s are provided by default. one of the `when`s could be `connectionTerminated` ... and > > * `appearance` + `connectionTerminated` = change color when process dies > * `action` + `connectionTerminated` = move ^D and Enter actions out of `ConptyConnection` some keywords to find this thread faster next time: conditional appearance combinatorial appearances matrix focused admin unfocused dead connection theme light dark
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Feature Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22137
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?