starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Wrapped scrollback + CMD leads to the commandline being drawn at the top of the window #22150

New Issue
Closed
opened 2026-01-31 08:04:49 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 08:04:49 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Aug 23, 2024).

Canary 1.22.2334.0

just jotting notes as I go

  • in cmd
  • ran all the screenbuffer tests, filling the scrollback
  • as it was running, I scrolled up briefly, then back to the bottom
  • after it was done, hit up arrow
  • this is where the commandline got redrawn:

image

basically I suspect that the mapping from buffer- to VT-viewport-coordinates in cooked read is racy
it's definitely not trivial to reproduce by simply printing text and concurrently scrolling / resizing the window

oh dear, I then hit enter to run the command - it predictably printed starting at the cursor, that makes sense. Problem after that was that another up arrow? brought it back to the weird place from before

image

oh wait I just remembered that the last this time has happened to me I also ran TAEF tests
HMMMMM probably a bug in my code, but that's sus

THAT IS SUS

Originally created by @zadjii-msft on GitHub (Aug 23, 2024). Canary 1.22.2334.0 > just jotting notes as I go > * in cmd > * ran all the screenbuffer tests, filling the scrollback > * as it was running, I scrolled up briefly, then back to the bottom > * after it was done, hit up arrow > * this is where the commandline got redrawn: ![image](https://github.com/user-attachments/assets/bffe75c2-6c4c-4d1e-adf7-b4a0f81ed472) > basically I suspect that the mapping from buffer- to VT-viewport-coordinates in cooked read is racy > it's definitely not trivial to reproduce by simply printing text and concurrently scrolling / resizing the window > oh dear, I then hit enter to run the command - it predictably printed starting at the cursor, that makes sense. Problem after that was that another up arrow? brought it back to the weird place from before ![image](https://github.com/user-attachments/assets/004fcfec-e930-4f2b-9ece-242998a8f244) > oh wait I just remembered that the last this time has happened to me I also ran TAEF tests > HMMMMM probably a bug in my code, but that's sus > THAT IS SUS
claunia commented 2026-01-31 08:04:51 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 23, 2024):

Wait I know exactly what happened:

image

The buffer got resized to 12x12 during one of the tests. This is just /dup #17736

@zadjii-msft commented on GitHub (Aug 23, 2024): Wait I know exactly what happened: ![image](https://github.com/user-attachments/assets/b082f414-b366-4ce9-a4ff-6a729eb8aaa4) The buffer got resized to 12x12 during one of the tests. This is just /dup #17736
claunia commented 2026-01-31 08:04:51 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (Aug 23, 2024):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service[bot] commented on GitHub (Aug 23, 2024): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! <!-- Policy app identification https://img.shields.io/static/v1?label=PullRequestIssueManagement. -->
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CookedRead Area-VT Issue-Bug Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22150
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?