starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Command history not saved when tab is closed on msys64 #22211

New Issue
Closed
opened 2026-01-31 08:06:35 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 08:06:35 +00:00
Owner
Copy Link

Originally created by @alshdavid on GitHub (Sep 4, 2024).

Windows Terminal version

1.20.11781.0

Windows build number

10.0.19045.0

Other Software

After setting up msys64 and adding it to Windows Terminal, closing the tab does not store the command history.

However, if I run exit rather than closing the tab/window, the history is saved. The history is also saved when closing the window when using the classic Windows command prompt.

This comment explains that Windows Terminal is sending the wrong signal to msys64.

Steps to reproduce

Install msys64 and add the profile to Windows Terminal

https://www.msys2.org/docs/terminals/

{
  "guid": "{55355a23-abac-48c2-b092-70c8cfc95684}",
  "hidden": false,
  "name": "zsh",
  "icon": "C:\\Users\\alshdavid\\.local\\msys64\\msys2.ico",
  "closeOnExit": "always",
  "commandline": "C:\\Users\\alshdavid\\.local\\msys64\\msys2_shell.cmd -defterm -here -no-start -mingw64 -shell zsh",
  "startingDirectory": "C:/Users/%USERNAME%",
  "environment": {
    "MSYS": "winsymlinks:nativestrict",
    "CHERE_INVOKING": "1",
    "MSYSTEM": "MINGW64"
  }
}

Expected Behavior

History is saved

Actual Behavior

History is not saved

https://github.com/user-attachments/assets/55ed4b7b-716c-4fbb-a11f-376ff9c1ad61

Originally created by @alshdavid on GitHub (Sep 4, 2024). ### Windows Terminal version 1.20.11781.0 ### Windows build number 10.0.19045.0 ### Other Software After setting up `msys64` and adding it to Windows Terminal, closing the tab does not store the command history. However, if I run `exit` rather than closing the tab/window, the history is saved. The history is also saved when closing the window when using the classic Windows command prompt. [This comment](https://github.com/msys2/MSYS2-packages/issues/1684#issuecomment-508786102) explains that Windows Terminal is sending the wrong signal to msys64. ### Steps to reproduce Install msys64 and add the profile to Windows Terminal https://www.msys2.org/docs/terminals/ ```json { "guid": "{55355a23-abac-48c2-b092-70c8cfc95684}", "hidden": false, "name": "zsh", "icon": "C:\\Users\\alshdavid\\.local\\msys64\\msys2.ico", "closeOnExit": "always", "commandline": "C:\\Users\\alshdavid\\.local\\msys64\\msys2_shell.cmd -defterm -here -no-start -mingw64 -shell zsh", "startingDirectory": "C:/Users/%USERNAME%", "environment": { "MSYS": "winsymlinks:nativestrict", "CHERE_INVOKING": "1", "MSYSTEM": "MINGW64" } } ``` ### Expected Behavior History is saved ### Actual Behavior History is not saved https://github.com/user-attachments/assets/55ed4b7b-716c-4fbb-a11f-376ff9c1ad61
claunia added the Needs-TriageIssue-Bug labels 2026-01-31 08:06:35 +00:00
claunia commented 2026-01-31 08:06:36 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 4, 2024):

@mominshaikhdevs please stop pinging random engineers on the team. We all have our notifications configured to make sure that we receive the things that are relevant to us, and we have a teamwide triage session every week. We will almost certainly see something, without you having to loop one of us in explicitly.

If you're seeing an issue that needs a timely response (and I do mean timely, like "people are going to be hurt"), Microsoft offers a number of paid support options.

@DHowett commented on GitHub (Sep 4, 2024): @mominshaikhdevs please stop pinging random engineers on the team. We all have our notifications configured to make sure that we receive the things that are relevant to us, and we have a teamwide triage session every week. _We will almost certainly see something,_ without you having to loop one of us in explicitly. If you're seeing an issue that needs a timely response (and I do mean timely, like "people are going to be hurt"), Microsoft offers a number of paid support options.
claunia commented 2026-01-31 08:06:37 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 4, 2024):

I just tested this with the following code:

#define WIN32_LEAN_AND_MEAN
#include <Windows.h>
#include <cstdio>

static wchar_t path[MAX_PATH];

int main() {
    ExpandEnvironmentStringsW(L"%USERPROFILE%\\Downloads\\status.txt", &path[0], ARRAYSIZE(path));
    wprintf(L"Writing to: %s\nExit now...\n", &path[0]);

    SetConsoleCtrlHandler(
        [](DWORD event) -> BOOL {
            const char* msg = nullptr;
            switch (event) {
            case CTRL_C_EVENT:
                msg = "CTRL_C_EVENT";
                break;
            case CTRL_BREAK_EVENT:
                msg = "CTRL_BREAK_EVENT";
                break;
            case CTRL_CLOSE_EVENT:
                msg = "CTRL_CLOSE_EVENT";
                break;
            case CTRL_LOGOFF_EVENT:
                msg = "CTRL_LOGOFF_EVENT";
                break;
            case CTRL_SHUTDOWN_EVENT:
                msg = "CTRL_SHUTDOWN_EVENT";
                break;
            default:
                msg = "default";
                break;
            }

            const auto f = CreateFileW(&path[0], GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, nullptr);
            WriteFile(f, msg, (DWORD)strlen(msg), nullptr, nullptr);
            CloseHandle(f);
            return FALSE;
        },
        TRUE
    );

    Sleep(INFINITE);
    return 0;
}

It results in CTRL_CLOSE_EVENT, which is the expected event. If a SIGHUP event is not generated, then I believe that's a bug in Cygwin, because it implements a POSIX environment on top of Windows. To me that means that it's Cygwin's job to translate SetConsoleCtrlHandler events to signal events.

FYI signal events like SIGBREAK and SIGHUP don't exist on Windows. Their support inside the CRT (C runtime = C library) is faked, based on SetConsoleCtrlHandler. SIGBREAK is simply any ctrl event that isn't a CTRL_C_EVENT which is just completely wrong. But the console implementation in the CRT is overall bad for many reasons, so it shouldn't be too unexpected.

As such, I'll be closing the issue for now. Let me know if you have any questions or if you think that I made a mistake.

@lhecker commented on GitHub (Sep 4, 2024): I just tested this with the following code: ```cpp #define WIN32_LEAN_AND_MEAN #include <Windows.h> #include <cstdio> static wchar_t path[MAX_PATH]; int main() { ExpandEnvironmentStringsW(L"%USERPROFILE%\\Downloads\\status.txt", &path[0], ARRAYSIZE(path)); wprintf(L"Writing to: %s\nExit now...\n", &path[0]); SetConsoleCtrlHandler( [](DWORD event) -> BOOL { const char* msg = nullptr; switch (event) { case CTRL_C_EVENT: msg = "CTRL_C_EVENT"; break; case CTRL_BREAK_EVENT: msg = "CTRL_BREAK_EVENT"; break; case CTRL_CLOSE_EVENT: msg = "CTRL_CLOSE_EVENT"; break; case CTRL_LOGOFF_EVENT: msg = "CTRL_LOGOFF_EVENT"; break; case CTRL_SHUTDOWN_EVENT: msg = "CTRL_SHUTDOWN_EVENT"; break; default: msg = "default"; break; } const auto f = CreateFileW(&path[0], GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, nullptr); WriteFile(f, msg, (DWORD)strlen(msg), nullptr, nullptr); CloseHandle(f); return FALSE; }, TRUE ); Sleep(INFINITE); return 0; } ``` It results in `CTRL_CLOSE_EVENT`, which is the expected event. If a `SIGHUP` event is not generated, then I believe that's a bug in Cygwin, because it implements a POSIX environment on top of Windows. To me that means that it's Cygwin's job to translate `SetConsoleCtrlHandler` events to signal events. FYI signal events like `SIGBREAK` and `SIGHUP` don't exist on Windows. Their support inside the CRT (C runtime = C library) is faked, based on `SetConsoleCtrlHandler`. `SIGBREAK` is simply any ctrl event that isn't a `CTRL_C_EVENT` which is just completely wrong. But the console implementation in the CRT is overall bad for many reasons, so it shouldn't be too unexpected. As such, I'll be closing the issue for now. Let me know if you have any questions or if you think that I made a mistake.
claunia commented 2026-01-31 08:06:37 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 7, 2024):

@mominshaikhdevs Sorry for singling you out, and misremembering how many times you'd done that. Thanks for keeping us honest. I know that some of our sister teams have not been very good about that. 🙂

@DHowett commented on GitHub (Sep 7, 2024): @mominshaikhdevs Sorry for singling you out, and misremembering how many times you'd done that. Thanks for keeping us honest. I know that some of our sister teams have not been very good about that. 🙂
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22211
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?