starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Clear Buffer is broken in Windows Terminal Preview (1.22.2362.0) #22227

New Issue
Closed
opened 2026-01-31 08:07:08 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 08:07:08 +00:00
Owner
Copy Link

Originally created by @valiko-ua on GitHub (Sep 5, 2024).

Windows Terminal version

1.22.2362.0

Windows build number

10.0.22631.4037

Steps to reproduce

  • Settings -> Actions -> Add New -> Add "Ctrl+l" (lowercase L) for "Clear Buffer". Press Save.
  • Open tab with "Command Prompt".
  • Execute "cd C:\Windows". Execute "dir" several times to fill the screen.
  • Press Ctrl+l (lowercase L).

Expected Behavior

Clear Buffer works fine in Windows Terminal v.1.20.11781.0.

Actual Behavior

Clear Buffer does not work in Windows Terminal Preview v.1.22.2362.0.

The same problem can be reproduced with "Ubuntu 24.04 LTS" tab (WSL2).

I've just noticed that pressing Ctrl+Shift+L works differently from Ctrl+L (but still broken). And I didn't assign Ctrl+Shift+L to anything.

Originally created by @valiko-ua on GitHub (Sep 5, 2024). ### Windows Terminal version 1.22.2362.0 ### Windows build number 10.0.22631.4037 ### Steps to reproduce * Settings -> Actions -> Add New -> Add "Ctrl+l" (lowercase L) for "Clear Buffer". Press Save. * Open tab with "Command Prompt". * Execute "cd C:\Windows". Execute "dir" several times to fill the screen. * Press Ctrl+l (lowercase L). ### Expected Behavior Clear Buffer works fine in Windows Terminal v.1.20.11781.0. ### Actual Behavior Clear Buffer does not work in Windows Terminal Preview v.1.22.2362.0. The same problem can be reproduced with "Ubuntu 24.04 LTS" tab (WSL2). I've just noticed that pressing Ctrl+Shift+L works differently from Ctrl+L (but still broken). And I didn't assign Ctrl+Shift+L to anything.
claunia commented 2026-01-31 08:07:11 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 5, 2024):

@lhecker Didn't we fix this during the original #17510? I could have swore that I filed that, but I can't find it now

@zadjii-msft commented on GitHub (Sep 5, 2024): @lhecker Didn't we fix this during the original #17510? I could have swore that I filed that, but I can't find it now
claunia commented 2026-01-31 08:07:11 +00:00
Author
Owner
Copy Link

@elsaco commented on GitHub (Sep 6, 2024):

@valiko-ua it's not the key binding. In 1.22.2362 the Clear buffer doesn't work. Fill the buffer with data and invoke the command via ctrl+shift+p. It won't clear the buffer!

@elsaco commented on GitHub (Sep 6, 2024): @valiko-ua it's not the key binding. In `1.22.2362` the `Clear buffer` doesn't work. Fill the buffer with data and invoke the command via `ctrl+shift+p`. It won't clear the buffer!
claunia commented 2026-01-31 08:07:11 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Sep 7, 2024):

I think the problem is explained by the comment here:

544452dad4/src/cascadia/TerminalControl/ControlCore.cpp (L2232-L2238)

In the past when you asked conpty to clear its buffer, the vtengine would have pushed back an update that also cleared the buffer in the connected terminal, but that's not happening anymore. On the conhost side, the ClearBuffer signal is handled here:

544452dad4/src/host/PtySignalInputThread.cpp (L185-L201)

Which just calls the SCREEN_INFORMATION class here:

544452dad4/src/host/screenInfo.cpp (L2142-L2162)

That's just going to clear the conhost buffer. As far as I can see, there's nothing in that code that will emit sequences to sync it up with the terminal buffer.

@j4james commented on GitHub (Sep 7, 2024): I think the problem is explained by the comment here: https://github.com/microsoft/terminal/blob/544452dad41d05b865f1fa1d665397befaa9ec2b/src/cascadia/TerminalControl/ControlCore.cpp#L2232-L2238 In the past when you asked conpty to clear its buffer, the vtengine would have pushed back an update that also cleared the buffer in the connected terminal, but that's not happening anymore. On the conhost side, the `ClearBuffer` signal is handled here: https://github.com/microsoft/terminal/blob/544452dad41d05b865f1fa1d665397befaa9ec2b/src/host/PtySignalInputThread.cpp#L185-L201 Which just calls the `SCREEN_INFORMATION` class here: https://github.com/microsoft/terminal/blob/544452dad41d05b865f1fa1d665397befaa9ec2b/src/host/screenInfo.cpp#L2142-L2162 That's just going to clear the conhost buffer. As far as I can see, there's nothing in that code that will emit sequences to sync it up with the terminal buffer.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11ySev1 A11yWCAG Area-Accessibility HCL-E+D HCL-WindowsTerminal In-PR Issue-Bug Needs-Tag-Fix WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22227
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?