starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Windows Terminal - Settings]: In dark mode, Luminosity ratio for 'Reset to inherited value' icon is '2.6:1', which is less than required '3:1'. #22259

New Issue
Closed
opened 2026-01-31 08:08:02 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 08:08:02 +00:00
Owner
Copy Link

Originally created by @Saurabh220304 on GitHub (Sep 11, 2024).

Windows Terminal version

1.22.2362.0

Windows build number

27695.1000

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 27695.1000)
App: Windows Terminal Preview

Steps to reproduce

Prerequisites:
Settings> Personalization> Colors> Choose your Mode> Dark Mode.

Repro steps:

  1. Open the 'windows terminal' application.
  2. Apply dark mode by following the prerequisites.
  3. Now open 'Setting' and activate 'Startup' tab.
  4. Navigate to the 'Defaults' tab and activate it.
  5. Now navigate to the 'Appearance' button and activate it.
  6. Now navigate to any control like 'Line height' and change value.
  7. 'Reset to inherited value' button will appear.
  8. Open Accessibility Insights for windows and check contrast ratio of 'Reset to inherited value' icon.
  9. Observe the issue.

User experience:
Low vision users will find difficulty in tracking the control, if contrast ratio for the control's icon is less than '3:1' (Required).

WCAG Reference Link:
[MAS 4.3.1 – No Disruption of Accessibility Features.docx (sharepoint.com)](https://www.w3.org/WAI/WCAG22/Understanding/non-text-contrast)

Attachment:
MAS1.4.11 - In Dark mode, cca failed for 'Reset to inherited value' button..zip

Expected Behavior

In dark mode, Luminosity ratio for 'Reset to inherited value' icon should be greater than or equal to 3:1.

Actual Behavior

In dark mode, Luminosity ratio for 'Reset to inherited value' icon is '2.6:1', which is less than required '3:1'.

Note:
Same issue repro for all 'Reset to inherited value' button's icon throughout.

Originally created by @Saurabh220304 on GitHub (Sep 11, 2024). ### Windows Terminal version 1.22.2362.0 ### Windows build number 27695.1000 ### Other Software **Test Environment:** OS: Windows 11 Version Dev (OS Build 27695.1000) App: Windows Terminal Preview ### Steps to reproduce **Prerequisites:** Settings> Personalization> Colors> Choose your Mode> Dark Mode. **Repro steps:** 1. Open the 'windows terminal' application. 2. Apply dark mode by following the prerequisites. 3. Now open 'Setting' and activate 'Startup' tab. 4. Navigate to the 'Defaults' tab and activate it. 5. Now navigate to the 'Appearance' button and activate it. 6. Now navigate to any control like 'Line height' and change value. 7. 'Reset to inherited value' button will appear. 8. Open Accessibility Insights for windows and check contrast ratio of 'Reset to inherited value' icon. 9. Observe the issue. **User experience:** Low vision users will find difficulty in tracking the control, if contrast ratio for the control's icon is less than '3:1' (Required). **WCAG Reference Link:** [[MAS 4.3.1 – No Disruption of Accessibility Features.docx (sharepoint.com)](https://microsoft.sharepoint.com/:w:/s/accessibility/EegntkLK4KBBvzE1qsKpIoABG2UIxUY2y3uo1LomKoz_bg?e=wLbDEr)](https://www.w3.org/WAI/WCAG22/Understanding/non-text-contrast) **Attachment:** [MAS1.4.11 - In Dark mode, cca failed for 'Reset to inherited value' button..zip](https://github.com/user-attachments/files/16959865/MAS1.4.11.-.In.Dark.mode.cca.failed.for.Reset.to.inherited.value.button.zip) ### Expected Behavior In dark mode, Luminosity ratio for 'Reset to inherited value' icon should be greater than or equal to 3:1. ### Actual Behavior In dark mode, Luminosity ratio for 'Reset to inherited value' icon is '2.6:1', which is less than required '3:1'. **Note:** Same issue repro for all 'Reset to inherited value' button's icon throughout.
claunia commented 2026-01-31 08:08:05 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Sep 11, 2024):

@SaurabhNew is there an associated severity rating for this issue?

@carlos-zamora commented on GitHub (Sep 11, 2024): @SaurabhNew is there an associated severity rating for this issue?
claunia commented 2026-01-31 08:08:05 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Sep 12, 2024):

@SaurabhNew I'm making the change in PR #17912. I have a question though. The accent color is configurable by the user to be just about any color (I noticed you can't set it to white, thankfully). Because of that, the contrast can be wildly different. I've tested this out with various shades of the accent color (as described in these docs).

We want to maintain that the color used is the accent color, but going too light/dark removes that feeling of personalization from the app. Is there a suggested range of accent colors that are expected to be supported? Or any limitations on this space (like using the blue color you have it set to in your testing)?

@carlos-zamora commented on GitHub (Sep 12, 2024): @SaurabhNew I'm making the change in PR #17912. I have a question though. The accent color is configurable by the user to be just about any color (I noticed you can't set it to white, thankfully). Because of that, the contrast can be wildly different. I've tested this out with various shades of the accent color (as described in [these docs](https://learn.microsoft.com/en-us/windows/apps/design/style/color#accent-color-palette)). We want to maintain that the color used is the accent color, but going too light/dark removes that feeling of personalization from the app. Is there a suggested range of accent colors that are expected to be supported? Or any limitations on this space (like using the blue color you have it set to in your testing)?
claunia commented 2026-01-31 08:08:06 +00:00
Author
Owner
Copy Link

@Saurabh220304 commented on GitHub (Sep 18, 2024):

@carlos-zamora, I referred the document that is mentioned above and observed that the HEX code of color used for '+1' will pass the contrast ratio of 3:1 in all high contrast modes.
image

@Saurabh220304 commented on GitHub (Sep 18, 2024): @carlos-zamora, I referred the document that is mentioned above and observed that the HEX code of color used for '+1' will pass the contrast ratio of 3:1 in all high contrast modes. ![image](https://github.com/user-attachments/assets/68b1a0d4-3cf6-4111-a3f0-f4a3d6c82911)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11ySev2 A11yWCAG Area-Accessibility HCL-E+D HCL-WindowsTerminal In-PR Issue-Bug Needs-Tag-Fix Product-Terminal WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22259
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?