starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

ClosePseudoConsole does not close the process handle to conhost #22267

New Issue
Closed
opened 2026-01-31 08:08:21 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 08:08:21 +00:00
Owner
Copy Link

Originally created by @asmichi on GitHub (Sep 11, 2024).

Windows Terminal version

N/A

Windows build number

10.0.22631.4037 (Windows 11 Pro, 23H2)

Other Software

(None, just Kernel32)

Steps to reproduce

Run the EchoCon sample and observe its handles before/after the ClosePseudoConsole call.

  • Add a breakpoint at ClosePseudoConsole(hPC)
  • Start debugging
  • Run handle.exe -p EchoCon.exe -a | findstr Process when the program breaks at ClosePseudoConsole(hPC)
  • Step over
  • Run handle.exe -p EchoCon.exe -a | findstr Process

Expected Behavior

ClosePseudoConsole closes the handle to conhost.exe.

Actual Behavior

ClosePseudoConsole does not close the handle to conhost.exe (leaks the handle).

This looks like a Kernel32 version of #8706.

D:\>REM break just before ClosePseudoConsole(hPC)

D:\>handle -p EchoCon.exe -a | findstr Process
   E0: Process       conhost.exe(34388)

D:\>REM step over ClosePseudoConsole(hPC)

D:\>handle -p EchoCon.exe -a | findstr Process
   E0: Process       <Nonexistent process>(34388)
Originally created by @asmichi on GitHub (Sep 11, 2024). ### Windows Terminal version N/A ### Windows build number 10.0.22631.4037 (Windows 11 Pro, 23H2) ### Other Software (None, just Kernel32) ### Steps to reproduce Run the `EchoCon` sample and observe its handles before/after the `ClosePseudoConsole` call. - Add a breakpoint at `ClosePseudoConsole(hPC)` - Start debugging - Run `handle.exe -p EchoCon.exe -a | findstr Process` when the program breaks at `ClosePseudoConsole(hPC)` - Step over - Run `handle.exe -p EchoCon.exe -a | findstr Process` ### Expected Behavior `ClosePseudoConsole` closes the handle to conhost.exe. ### Actual Behavior `ClosePseudoConsole` does not close the handle to conhost.exe (leaks the handle). This looks like a Kernel32 version of #8706. ``` D:\>REM break just before ClosePseudoConsole(hPC) D:\>handle -p EchoCon.exe -a | findstr Process E0: Process conhost.exe(34388) D:\>REM step over ClosePseudoConsole(hPC) D:\>handle -p EchoCon.exe -a | findstr Process E0: Process <Nonexistent process>(34388) ```
claunia commented 2026-01-31 08:08:23 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 11, 2024):

I checked the corresponding branch internally and it doesn't include the CloseHandle fix. The good news is that 24h2 doesn't have this issue (its ClosePseudoConsole implementation is way simpler and more robust).

@lhecker commented on GitHub (Sep 11, 2024): I checked the corresponding branch internally and it doesn't include the `CloseHandle` fix. The good news is that 24h2 doesn't have this issue (its `ClosePseudoConsole` implementation is way simpler and more robust).
claunia commented 2026-01-31 08:08:23 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 12, 2024):

We can probably close this as fix-checked-in, right? I'm not sure we can backport that...

(if you want to backport it, go for it)

@zadjii-msft commented on GitHub (Sep 12, 2024): We can probably close this as fix-checked-in, right? I'm not sure we can backport that... (if you want to backport it, go for it)
claunia commented 2026-01-31 08:08:23 +00:00
Author
Owner
Copy Link

@asmichi commented on GitHub (Sep 14, 2024):

Thank you! I'm glad to hear this is already fixed in the insider build. I have confirmed the fix with 10.0.26120.1542 (Dev Channel).

If backporting is not planned, please feel free to close this as fixed.

@asmichi commented on GitHub (Sep 14, 2024): Thank you! I'm glad to hear this is already fixed in the insider build. I have confirmed the fix with 10.0.26120.1542 (Dev Channel). If backporting is not planned, please feel free to close this as fixed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Triage Product-Conpty Resolution-Fix-Available Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22267
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?