starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

keybindings marked deprecated in preview $schema #22281

New Issue
Closed
opened 2026-01-31 08:08:47 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 08:08:47 +00:00
Owner
Copy Link

Originally created by @xudyang1 on GitHub (Sep 12, 2024).

Originally assigned to: @nguyen-dows on GitHub.

Windows Terminal version

1.22.2362.0

Windows build number

10.0.19045.0

Other Software

No response

Steps to reproduce

  1. Open windows terminal settings.json.
  2. See a record with key "keybindings", and value of an array of { "id": "...", "keys": "key..." }.
  3. Remove the keybindings record
  4. Open command palette by ctrl+shift+p
  5. Notice that settings.json has been updated and contains a new keybindings record.

image

Expected Behavior

No deprecated keybindings generated.

Actual Behavior

Always updates settings.json automatically.

Originally created by @xudyang1 on GitHub (Sep 12, 2024). Originally assigned to: @nguyen-dows on GitHub. ### Windows Terminal version 1.22.2362.0 ### Windows build number 10.0.19045.0 ### Other Software _No response_ ### Steps to reproduce 1. Open windows terminal settings.json. 2. See a record with key "keybindings", and value of an array of `{ "id": "...", "keys": "key..." }`. 3. Remove the keybindings record 4. Open command palette by `ctrl+shift+p` 5. Notice that settings.json has been updated and contains a new keybindings record. ![image](https://github.com/user-attachments/assets/5eb9c258-e4e0-436b-ae75-9290d89b7e1f) ### Expected Behavior No deprecated keybindings generated. ### Actual Behavior Always updates settings.json automatically.
claunia added the Needs-TriageIssue-Docs labels 2026-01-31 08:08:48 +00:00
claunia commented 2026-01-31 08:08:48 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 14, 2024):

That's actually by design. keybindings is coming back to the settings in 1.22.

what isn't by design is that the link in the $schema hasn't been redirected to the preview branch yet. Our bad! @nguyen-dows can you update that aka.ms link then close this out?

@zadjii-msft commented on GitHub (Sep 14, 2024): That's actually by design. `keybindings` is coming back to the settings in 1.22. what isn't by design is that the link in the `$schema` hasn't been redirected to the preview branch yet. Our bad! @nguyen-dows can you update that aka.ms link then close this out?
claunia commented 2026-01-31 08:08:49 +00:00
Author
Owner
Copy Link

@xudyang1 commented on GitHub (Sep 15, 2024):

That's actually by design. keybindings is coming back to the settings in 1.22.

what isn't by design is that the link in the $schema hasn't been redirected to the preview branch yet. Our bad! @nguyen-dows can you update that aka.ms link then close this out?

I have updated the issue title.

@xudyang1 commented on GitHub (Sep 15, 2024): > That's actually by design. `keybindings` is coming back to the settings in 1.22. > > what isn't by design is that the link in the `$schema` hasn't been redirected to the preview branch yet. Our bad! @nguyen-dows can you update that aka.ms link then close this out? I have updated the issue title.
claunia commented 2026-01-31 08:08:49 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 16, 2024):

Thanks. I just redirected the schema links. Sorry for the delay.

@DHowett commented on GitHub (Sep 16, 2024): Thanks. I just redirected the schema links. Sorry for the delay.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Docs Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22281
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?