starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

WSL paths need further escape of single quotes #22357

New Issue
Open
opened 2026-01-31 08:10:48 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 08:10:48 +00:00
Owner
Copy Link

Originally created by @a4lg on GitHub (Oct 8, 2024).

Windows Terminal version

1.20.11781.0

Windows build number

10.0.26100.0

Other Software

Ubuntu 24.04 (in WSL and source of Windows.Terminal.Wsl in the profile; any WSL distributions are affected)

Steps to reproduce

  1. Open a WSL tab.
  2. Drag and drop a file/folder (the full path needs at least one single quote ' character), say D:\John's Archive.

Expected Behavior

When

D:\John's Archive

is dropped to a WSL tab, a string which expands to:

/mnt/d/John's Archive

(single argument) in the shell should be dropped.

An example satisfying this condition includes '/mnt/d/John'"'"'s Archive' (escaping a single quote ' with '"'"' (finish quote, print a single quote character then begin quote again).

Note: the expected behavior may differ depending on which environment we should assume.
This expected behavior here is of the POSIX shell context and I think this is reasonable.

Actual Behavior

In the dropped path, single quotes in the original full path are kept as-is (D:\John's Archive → '/mnt/d/John's Archive').

This is clearly wrong in the POSIX shell context because a quoted string ends before s and the space after s is not quoted and will not be preserved.

Originally created by @a4lg on GitHub (Oct 8, 2024). ### Windows Terminal version 1.20.11781.0 ### Windows build number 10.0.26100.0 ### Other Software Ubuntu 24.04 (in WSL and `source` of `Windows.Terminal.Wsl` in the profile; any WSL distributions are affected) ### Steps to reproduce 1. Open a WSL tab. 2. Drag and drop a file/folder (the full path needs at least one single quote `'` character), say `D:\John's Archive`. ### Expected Behavior When ``` D:\John's Archive ``` is dropped to a WSL tab, a string which expands to: ``` /mnt/d/John's Archive ``` (single argument) in the shell should be dropped. An example satisfying this condition includes `'/mnt/d/John'"'"'s Archive'` (escaping a single quote `'` with `'"'"'` (finish quote, print a single quote character then begin quote again). Note: the *expected* behavior may differ depending on which environment we should assume. *This expected behavior here* is of the POSIX shell context and I think this is reasonable. ### Actual Behavior In the dropped path, single quotes in the original full path are kept as-is (`D:\John's Archive` → `'/mnt/d/John's Archive'`). This is clearly wrong in the POSIX shell context because a quoted string ends before `s` and the space after `s` is not quoted and will not be preserved.
claunia added the Issue-BugIn-PRNeeds-Tag-FixProduct-TerminalArea-TerminalControl labels 2026-01-31 08:10:48 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl In-PR Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22357
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?