starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Ctrl+C kills the process abruptly #22390

New Issue
Closed
opened 2026-01-31 08:11:45 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 08:11:45 +00:00
Owner
Copy Link

Originally created by @rom1v on GitHub (Oct 12, 2024).

Windows Terminal version

No response

Windows build number

No response

Other Software

No response

Steps to reproduce

Hello,

In a program called scrcpy that I develop, I listen to Ctrl+C on Windows using SetConsoleCtrlHandler(windows_ctrl_handler, TRUE);:

665ccb32f5/app/src/scrcpy.c (L148-L149)

It works correctly in the default (old) Windows console (typically started by cmd.exe), Ctrl+C is catched and the program can terminate gracefully (finishing writing a video footer for example).

However, from Windows Terminal, it has been reported that Ctrl+C terminates the process abruptly (which in that case cause the recorded mp4 file to be corrupted, but any other cleanup actions cannot be executed): https://github.com/Genymobile/scrcpy/issues/5122#issuecomment-2243087702

Is there a reason for this behavior?

Thank you for your help.

Expected Behavior

The Ctrl handler should be executed on Ctrl+C.

Actual Behavior

The process is killed abruptly on Ctrl+C.

Originally created by @rom1v on GitHub (Oct 12, 2024). ### Windows Terminal version _No response_ ### Windows build number _No response_ ### Other Software _No response_ ### Steps to reproduce Hello, In a program called scrcpy that I develop, I listen to Ctrl+C on Windows using `SetConsoleCtrlHandler(windows_ctrl_handler, TRUE);`: https://github.com/Genymobile/scrcpy/blob/665ccb32f5306ebd866dc0d99f4d08ed2aeb91c3/app/src/scrcpy.c#L148-L149 It works correctly in the default (old) Windows console (typically started by `cmd.exe`), Ctrl+C is catched and the program can terminate gracefully (finishing writing a video footer for example). However, from Windows Terminal, it has been reported that Ctrl+C terminates the process abruptly (which in that case cause the recorded mp4 file to be corrupted, but any other cleanup actions cannot be executed): https://github.com/Genymobile/scrcpy/issues/5122#issuecomment-2243087702 Is there a reason for this behavior? Thank you for your help. ### Expected Behavior The Ctrl handler should be executed on Ctrl+C. ### Actual Behavior The process is killed abruptly on Ctrl+C.
claunia commented 2026-01-31 08:11:49 +00:00
Author
Owner
Copy Link

@ronal33 commented on GitHub (Oct 13, 2024):

Could you add this code?
when this flag is added, ctrl+C is processed as a control event and the handler set with SetConsoleCtrlHandler is sent

static void
sdl_configure(bool video_playback, bool disable_screensaver) {
#ifdef _WIN32
    // Clean up properly on Ctrl+C on Windows
    bool ok = SetConsoleCtrlHandler(windows_ctrl_handler, TRUE);
    if (!ok) {
        LOGW("Could not set Ctrl+C handler");
    }

    // Habilitar ENABLE_PROCESSED_INPUT
    HANDLE hStdin = GetStdHandle(STD_INPUT_HANDLE);
    DWORD mode;
    if (GetConsoleMode(hStdin, &mode)) {
        mode |= ENABLE_PROCESSED_INPUT;
        if (!SetConsoleMode(hStdin, mode)) {
            LOGW("Could not set console mode");
        }
    } else {
        LOGW("Could not get console mode");
    }
#endif // _WIN32

    if (!video_playback) {
        return;
    }

    if (disable_screensaver) {
        SDL_DisableScreenSaver();
    } else {
        SDL_EnableScreenSaver();
    }
}
@ronal33 commented on GitHub (Oct 13, 2024): Could you add this code? when this flag is added, ctrl+C is processed as a control event and the handler set with SetConsoleCtrlHandler is sent ``` static void sdl_configure(bool video_playback, bool disable_screensaver) { #ifdef _WIN32 // Clean up properly on Ctrl+C on Windows bool ok = SetConsoleCtrlHandler(windows_ctrl_handler, TRUE); if (!ok) { LOGW("Could not set Ctrl+C handler"); } // Habilitar ENABLE_PROCESSED_INPUT HANDLE hStdin = GetStdHandle(STD_INPUT_HANDLE); DWORD mode; if (GetConsoleMode(hStdin, &mode)) { mode |= ENABLE_PROCESSED_INPUT; if (!SetConsoleMode(hStdin, mode)) { LOGW("Could not set console mode"); } } else { LOGW("Could not get console mode"); } #endif // _WIN32 if (!video_playback) { return; } if (disable_screensaver) { SDL_DisableScreenSaver(); } else { SDL_EnableScreenSaver(); } } ```
claunia commented 2026-01-31 08:11:49 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Oct 16, 2024):

Thanks for filing! Could you create a minimal repro in a single file?

@carlos-zamora commented on GitHub (Oct 16, 2024): Thanks for filing! Could you create a minimal repro in a single file?
claunia commented 2026-01-31 08:11:50 +00:00
Author
Owner
Copy Link

@rom1v commented on GitHub (Oct 21, 2024):

Thank you for your replies.

@carlos-zamora I could not reproduce myself.

@ronal33 I built a binary with your additional code, so that people could test: https://github.com/Genymobile/scrcpy/issues/5122#issuecomment-2408888597
But no answer so far.

@rom1v commented on GitHub (Oct 21, 2024): Thank you for your replies. @carlos-zamora I could not reproduce myself. @ronal33 I built a binary with your additional code, so that people could test: https://github.com/Genymobile/scrcpy/issues/5122#issuecomment-2408888597 But no answer so far.
claunia commented 2026-01-31 08:11:50 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 21, 2024):

I'm just gonna @vinayhatyal, since they're the user on your repo that originally filed this. Perhaps they can share some debugging light.

@vinayhatyal can you share the version of the Terminal that you're using? There's been some changes to the way process shutdown happens semi-recently, and I wonder if that was fixed since July

@zadjii-msft commented on GitHub (Oct 21, 2024): I'm just gonna @vinayhatyal, since they're the user on your repo that originally filed this. Perhaps they can share some debugging light. @vinayhatyal can you share the version of the Terminal that you're using? There's been some changes to the way process shutdown happens semi-recently, and I wonder if that was fixed since July
claunia commented 2026-01-31 08:11:50 +00:00
Author
Owner
Copy Link

@Zeroes1 commented on GitHub (Oct 22, 2024):

for first look all OK?

test under
scrcpy-win64-v2.7.zip
os 10.0.19045.3448 (22H2)
release terminal-1.17.11461.0 and canary terminal-1.23.2913.0

under cmd and powershell 5.1
ran:
scrcpy --record=file.mp4

and aftrer press Ctrl-C
i see output to console:
INFO: Recording complete to mp4 file: file.mp4

behavior as cmd (under conhost)

SetConsoleCtrlHandler is work?

@Zeroes1 commented on GitHub (Oct 22, 2024): for first look all OK? test under scrcpy-win64-v2.7.zip os 10.0.19045.3448 (22H2) release terminal-1.17.11461.0 and canary terminal-1.23.2913.0 under cmd and powershell 5.1 ran: scrcpy --record=file.mp4 and aftrer press Ctrl-C i see output to console: INFO: Recording complete to mp4 file: file.mp4 behavior as cmd (under conhost) SetConsoleCtrlHandler is work?
claunia commented 2026-01-31 08:11:50 +00:00
Author
Owner
Copy Link

@Zeroes1 commented on GitHub (Oct 24, 2024):

@rom1v
also i check (all what write up my post) with key --no-window
all good too.

@Zeroes1 commented on GitHub (Oct 24, 2024): @rom1v also i check (all what write up my post) with key --no-window all good too.
claunia commented 2026-01-31 08:11:51 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (Oct 28, 2024):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (Oct 28, 2024): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**. <!-- Policy app identification https://img.shields.io/static/v1?label=PullRequestIssueManagement. -->
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Author-Feedback Needs-Repro Needs-Triage No-Recent-Activity
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22390
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?