starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Crash when closing split pane in maximised focus #22429

New Issue
Closed
opened 2026-01-31 08:12:58 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 08:12:58 +00:00
Owner
Copy Link

Originally created by @EthicalBen on GitHub (Oct 20, 2024).

Windows Terminal version

1.21.2911.0

Windows build number

10.0.22635.0

Other Software

No response

Steps to reproduce

Open Terminal
Set window to maximised.
Set window to 'focus', aka missing title bar, aka fullscreen.
Open split pane.
Close split pane.
[Hard Crash Process]

Expected Behavior

Not crash.

Actual Behavior

Crash.

Originally created by @EthicalBen on GitHub (Oct 20, 2024). ### Windows Terminal version 1.21.2911.0 ### Windows build number 10.0.22635.0 ### Other Software _No response_ ### Steps to reproduce Open Terminal Set window to maximised. Set window to 'focus', aka missing title bar, aka fullscreen. Open split pane. Close split pane. [Hard Crash Process] ### Expected Behavior Not crash. ### Actual Behavior Crash.
claunia added the Issue-BugNeeds-Tag-FixNeeds-ReproProduct-TerminalSeverity-Crash labels 2026-01-31 08:12:58 +00:00
claunia commented 2026-01-31 08:12:59 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 21, 2024):

Huh. I can't repro this locally, on 1.21 or 1.22.

Can you try capturing a dump from the crash and sending it to us/? That should be able to ID what's responsible.

@zadjii-msft commented on GitHub (Oct 21, 2024): Huh. I can't repro this locally, on 1.21 or 1.22. Can you try [capturing a dump](https://github.com/microsoft/terminal/wiki/Troubleshooting-Tips#capture-automatically) from the crash and sending it to us/? That should be able to ID what's responsible.
claunia commented 2026-01-31 08:13:00 +00:00
Author
Owner
Copy Link

@EthicalBen commented on GitHub (Oct 22, 2024):

Have captured a crash dump. I'll email it at you as stated in the guide. Because of PII concerns on my part, please do not make the dump publicly available.

@EthicalBen commented on GitHub (Oct 22, 2024): Have captured a crash dump. I'll email it at you as stated in the guide. Because of PII concerns on my part, please do not make the dump publicly available.
claunia commented 2026-01-31 08:13:00 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 24, 2024):

[0x0]   TerminalApp!winrt::impl::consume_TerminalApp_IPaneContent<winrt::TerminalApp::IPaneContent>::ReadOnly+0x38   0xf56ddfe840   0x7fff6051e935   
[0x1]   TerminalApp!Pane::ContainsReadOnly+0x33   (Inline Function)   (Inline Function)   
[0x2]   TerminalApp!winrt::TerminalApp::implementation::TerminalTab::_RecalculateAndApplyReadOnly+0x115   0xf56ddfe8a0   0x7fff6051ab7b   
[0x3]   TerminalApp!winrt::TerminalApp::implementation::TerminalTab::_UpdateActivePane+0x1ab   0xf56ddfe910   0x7fff6051b158   
[0x4]   TerminalApp!`winrt::TerminalApp::implementation::TerminalTab::_AttachEventHandlersToPane'::`2'::<lambda_1>::operator()+0x128   0xf56ddfe980   0x7fff6052542c   
[0x5]   TerminalApp!winrt::impl::variadic_delegate<`winrt::TerminalApp::implementation::TerminalTab::_AttachEventHandlersToPane'::`2'::<lambda_1>,void,std::shared_ptr<Pane>,enum winrt::Windows::UI::Xaml::FocusState>::invoke+0x3c   0xf56ddfea00   0x7fff604f9a84   
[0x6]   TerminalApp!winrt::impl::delegate_base<void,std::shared_ptr<Pane>,enum winrt::Windows::UI::Xaml::FocusState>::operator()+0x10   (Inline Function)   (Inline Function)   
[0x7]   TerminalApp!winrt::impl::invoke<winrt::delegate<std::shared_ptr<Pane>,enum winrt::Windows::UI::Xaml::FocusState>,std::shared_ptr<Pane>,enum winrt::Windows::UI::Xaml::FocusState>+0x14   0xf56ddfea40   0x7fff604f8d4e   
[0x8]   TerminalApp!winrt::event<winrt::delegate<std::shared_ptr<Pane>,enum winrt::Windows::UI::Xaml::FocusState> >::operator()<std::shared_ptr<Pane>,enum winrt::Windows::UI::Xaml::FocusState>+0x7e   0xf56ddfea70   0x7fff604ed978   
[0x9]   TerminalApp!til::event<winrt::delegate<std::shared_ptr<Pane>,enum winrt::Windows::UI::Xaml::FocusState> >::raise+0x13   (Inline Function)   (Inline Function)   
[0xa]   TerminalApp!Pane::_ContentGotFocusHandler+0x128   0xf56ddfeac0   0x7fff604a2508   
[0xb]   TerminalApp!winrt::Windows::UI::Xaml::Data::PropertyChangedEventHandler::{ctor}::__l1::<lambda_482_>::operator()+0x18   (Inline Function)   (Inline Function)   
[0xc]   TerminalApp!winrt::impl::delegate<winrt::Windows::UI::Xaml::Data::PropertyChangedEventHandler,`winrt::Windows::UI::Xaml::Data::PropertyChangedEventHandler::implementation<winrt::TerminalApp::implementation::XamlBindingTrackingBase,void (__cdecl winrt::TerminalApp::implementation::XamlBindingTrackingBase::*)(winrt::Windows::Foundation::IInspectable const &,winrt::Windows::UI::Xaml::Data::PropertyChangedEventArgs const &)>'::`1'::<lambda_482_> >::Invoke+0x38   0xf56ddfeb30   0x7fff9507d0b4   

blah blah blah

[0x31]   WindowsTerminal!WindowThread::_messagePump+0x1fe   0xf56ddff730   0x7ff6fcf9cfc6   
[0x32]   WindowsTerminal!WindowThread::RunMessagePump+0x8   (Inline Function)   (Inline Function)   
[0x33]   WindowsTerminal!`WindowEmperor::_createNewWindowThread'::`2'::<lambda_1>::operator()+0x426   0xf56ddff810   0x7ff6fcfa23ae   
[0x34]   WindowsTerminal!std::invoke+0x5   (Inline Function)   (Inline Function)   
[0x35]   WindowsTerminal!std::thread::_Invoke<std::tuple<`WindowEmperor::_createNewWindowThread'::`2'::<lambda_1> >,0>+0xe   0xf56ddff920   0x7fffc7689333   
[0x36]   ucrtbase!thread_start<unsigned int (__cdecl*)(void *),1>+0x93   0xf56ddff950   0x7fffc8d1257d   
[0x37]   kernel32!BaseThreadInitThunk+0x1d   0xf56ddff980   0x7fffc9b0aa48   
[0x38]   ntdll!RtlUserThreadStart+0x28   0xf56ddff9b0   0x0

Main:
8d3f12b1c0/src/cascadia/TerminalApp/Pane.cpp (L2943-L2947)

Before #17330:
ec9289288e/src/cascadia/TerminalApp/Pane.cpp (L2945-L2948)

I bet this is just fixed in 1.22. Can you try Windows Terminal Preview v1.22.2912.0 and see if this still repros/?

@zadjii-msft commented on GitHub (Oct 24, 2024): ``` [0x0] TerminalApp!winrt::impl::consume_TerminalApp_IPaneContent<winrt::TerminalApp::IPaneContent>::ReadOnly+0x38 0xf56ddfe840 0x7fff6051e935 [0x1] TerminalApp!Pane::ContainsReadOnly+0x33 (Inline Function) (Inline Function) [0x2] TerminalApp!winrt::TerminalApp::implementation::TerminalTab::_RecalculateAndApplyReadOnly+0x115 0xf56ddfe8a0 0x7fff6051ab7b [0x3] TerminalApp!winrt::TerminalApp::implementation::TerminalTab::_UpdateActivePane+0x1ab 0xf56ddfe910 0x7fff6051b158 [0x4] TerminalApp!`winrt::TerminalApp::implementation::TerminalTab::_AttachEventHandlersToPane'::`2'::<lambda_1>::operator()+0x128 0xf56ddfe980 0x7fff6052542c [0x5] TerminalApp!winrt::impl::variadic_delegate<`winrt::TerminalApp::implementation::TerminalTab::_AttachEventHandlersToPane'::`2'::<lambda_1>,void,std::shared_ptr<Pane>,enum winrt::Windows::UI::Xaml::FocusState>::invoke+0x3c 0xf56ddfea00 0x7fff604f9a84 [0x6] TerminalApp!winrt::impl::delegate_base<void,std::shared_ptr<Pane>,enum winrt::Windows::UI::Xaml::FocusState>::operator()+0x10 (Inline Function) (Inline Function) [0x7] TerminalApp!winrt::impl::invoke<winrt::delegate<std::shared_ptr<Pane>,enum winrt::Windows::UI::Xaml::FocusState>,std::shared_ptr<Pane>,enum winrt::Windows::UI::Xaml::FocusState>+0x14 0xf56ddfea40 0x7fff604f8d4e [0x8] TerminalApp!winrt::event<winrt::delegate<std::shared_ptr<Pane>,enum winrt::Windows::UI::Xaml::FocusState> >::operator()<std::shared_ptr<Pane>,enum winrt::Windows::UI::Xaml::FocusState>+0x7e 0xf56ddfea70 0x7fff604ed978 [0x9] TerminalApp!til::event<winrt::delegate<std::shared_ptr<Pane>,enum winrt::Windows::UI::Xaml::FocusState> >::raise+0x13 (Inline Function) (Inline Function) [0xa] TerminalApp!Pane::_ContentGotFocusHandler+0x128 0xf56ddfeac0 0x7fff604a2508 [0xb] TerminalApp!winrt::Windows::UI::Xaml::Data::PropertyChangedEventHandler::{ctor}::__l1::<lambda_482_>::operator()+0x18 (Inline Function) (Inline Function) [0xc] TerminalApp!winrt::impl::delegate<winrt::Windows::UI::Xaml::Data::PropertyChangedEventHandler,`winrt::Windows::UI::Xaml::Data::PropertyChangedEventHandler::implementation<winrt::TerminalApp::implementation::XamlBindingTrackingBase,void (__cdecl winrt::TerminalApp::implementation::XamlBindingTrackingBase::*)(winrt::Windows::Foundation::IInspectable const &,winrt::Windows::UI::Xaml::Data::PropertyChangedEventArgs const &)>'::`1'::<lambda_482_> >::Invoke+0x38 0xf56ddfeb30 0x7fff9507d0b4 blah blah blah [0x31] WindowsTerminal!WindowThread::_messagePump+0x1fe 0xf56ddff730 0x7ff6fcf9cfc6 [0x32] WindowsTerminal!WindowThread::RunMessagePump+0x8 (Inline Function) (Inline Function) [0x33] WindowsTerminal!`WindowEmperor::_createNewWindowThread'::`2'::<lambda_1>::operator()+0x426 0xf56ddff810 0x7ff6fcfa23ae [0x34] WindowsTerminal!std::invoke+0x5 (Inline Function) (Inline Function) [0x35] WindowsTerminal!std::thread::_Invoke<std::tuple<`WindowEmperor::_createNewWindowThread'::`2'::<lambda_1> >,0>+0xe 0xf56ddff920 0x7fffc7689333 [0x36] ucrtbase!thread_start<unsigned int (__cdecl*)(void *),1>+0x93 0xf56ddff950 0x7fffc8d1257d [0x37] kernel32!BaseThreadInitThunk+0x1d 0xf56ddff980 0x7fffc9b0aa48 [0x38] ntdll!RtlUserThreadStart+0x28 0xf56ddff9b0 0x0 ``` Main: https://github.com/microsoft/terminal/blob/8d3f12b1c065a965974cd6b5bc7a81176ffb0f1b/src/cascadia/TerminalApp/Pane.cpp#L2943-L2947 Before #17330: https://github.com/microsoft/terminal/blob/ec9289288e6581b8d1cbb5f7d334422de4dee07a/src/cascadia/TerminalApp/Pane.cpp#L2945-L2948 I bet this is just fixed in 1.22. Can you try [Windows Terminal Preview v1.22.2912.0](https://github.com/microsoft/terminal/releases/tag/v1.22.2912.0) and see if this still repros/?
claunia commented 2026-01-31 08:13:01 +00:00
Author
Owner
Copy Link

@EthicalBen commented on GitHub (Oct 26, 2024):

Cannot reproduce bug in Terminal Preview (1.22.2912.0).
Assume fixed.

@EthicalBen commented on GitHub (Oct 26, 2024): Cannot reproduce bug in Terminal Preview (1.22.2912.0). Assume fixed.
claunia commented 2026-01-31 08:13:02 +00:00
Author
Owner
Copy Link

@EthicalBen commented on GitHub (Oct 26, 2024):

Never mind.

@EthicalBen commented on GitHub (Oct 26, 2024): Never mind.
claunia commented 2026-01-31 08:13:02 +00:00
Author
Owner
Copy Link

@EthicalBen commented on GitHub (Oct 26, 2024):

I got it to crash again.

@EthicalBen commented on GitHub (Oct 26, 2024): I got it to crash again.
claunia commented 2026-01-31 08:13:03 +00:00
Author
Owner
Copy Link

@EthicalBen commented on GitHub (Oct 26, 2024):

Actually never mind my never mind. Is fixed.

@EthicalBen commented on GitHub (Oct 26, 2024): Actually never mind my never mind. Is fixed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Repro Needs-Tag-Fix Product-Terminal Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22429
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?