URL Detection Faulty #22447

Closed
opened 2026-01-31 08:13:28 +00:00 by claunia · 4 comments
Owner

Originally created by @TheUnlimited64 on GitHub (Oct 23, 2024).

Windows Terminal version

1.20.11781.0

Windows build number

10.0.22631.0

Other Software

Hey,

the URL detection seems to be a bit buggy in my case its about following example:

https://foo/bar?foo[bar]=1

In vscode the whole string is interpreted as an url, but in the Windows terminal only https://foo/bar?foo part is recognized as an url

Steps to reproduce

  1. print a link

echo "https://foo/bar?foo[bar]=1"

  1. Hover with ctrl over the link

Expected Behavior

The whole string is interpreted as an url.

Actual Behavior

If the bracket notation is used, the part after it will get cut off

Originally created by @TheUnlimited64 on GitHub (Oct 23, 2024). ### Windows Terminal version 1.20.11781.0 ### Windows build number 10.0.22631.0 ### Other Software Hey, the URL detection seems to be a bit buggy in my case its about following example: `https://foo/bar?foo[bar]=1` In vscode the whole string is interpreted as an url, but in the Windows terminal only `https://foo/bar?foo` part is recognized as an url ### Steps to reproduce 1. print a link `echo "https://foo/bar?foo[bar]=1" ` 2. Hover with ctrl over the link ### Expected Behavior The whole string is interpreted as an url. ### Actual Behavior If the bracket notation is used, the part after it will get cut off
claunia added the Issue-BugResolution-Duplicate labels 2026-01-31 08:13:28 +00:00
Author
Owner

@similar-issues-ai[bot] commented on GitHub (Oct 23, 2024):

We've found some similar issues:

  • #9689 , similarity score: 85%

If any of the above are duplicates, please consider closing this issue out and adding additional context in the original issue.

Note: You can give me feedback by 👍 or 👎 this comment.

@similar-issues-ai[bot] commented on GitHub (Oct 23, 2024): We've found some similar issues: - #9689 , similarity score: 85% If any of the above are duplicates, please consider closing this issue out and adding additional context in the original issue. > Note: You can give me feedback by 👍 or 👎 this comment.
Author
Owner

@TheUnlimited64 commented on GitHub (Oct 26, 2024):

It's still not fixed in #8321 but it can be avoided in certain cases with encoded parameters

@TheUnlimited64 commented on GitHub (Oct 26, 2024): It's still not fixed in #8321 but it can be avoided in certain cases with encoded parameters
Author
Owner

@carlos-zamora commented on GitHub (Oct 30, 2024):

Thanks! Yeah, the fix would be to have a better regex for URL detection, which is tracked over in #8321. So we're going to mark this as a /dup of #8321 and track that work over there.

@carlos-zamora commented on GitHub (Oct 30, 2024): Thanks! Yeah, the fix would be to have a better regex for URL detection, which is tracked over in #8321. So we're going to mark this as a /dup of #8321 and track that work over there.
Author
Owner

@microsoft-github-policy-service[bot] commented on GitHub (Oct 30, 2024):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service[bot] commented on GitHub (Oct 30, 2024): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! <!-- Policy app identification https://img.shields.io/static/v1?label=PullRequestIssueManagement. -->
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22447