starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Settings are always saved with command id #22455

New Issue
Closed
opened 2026-01-31 08:13:38 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 08:13:38 +00:00
Owner
Copy Link

Originally created by @ebarzilay-godaddy on GitHub (Oct 26, 2024).

Windows Terminal version

1.21.2911.0

Windows build number

10.0.22631.4317

Other Software

No response

Steps to reproduce

Making any modification to the settings and saving them adds an id field to all actions.

I don't use these IDs yet, and even when I do, then not for all of my actions.

This sounds harmless, but the annoying thing is related to #18110 -- I have a lot of sendInput actions (mapping obscure key combos to escape sequences which my environment knows about), and I'm forced to add useless IDs to all of them.

Looks like they're optional -- BUT -- if I drop them, then next time Terminal rewrites my settings, it blesses me with a fresh layer of IDs, and I now need to check the differences and re-remove them. Since this is tedious and error prone, I'm effectively forced to accept this and add IDs. Life becomes unnecessarily more verbose with IDs that I'll never need.

Expected Behavior

No IDs added for actions unless I already had an id for them.

Actual Behavior

IDs are always added.

Originally created by @ebarzilay-godaddy on GitHub (Oct 26, 2024). ### Windows Terminal version 1.21.2911.0 ### Windows build number 10.0.22631.4317 ### Other Software _No response_ ### Steps to reproduce Making any modification to the settings and saving them adds an `id` field to all actions. I don't use these IDs yet, and even when I do, then not for all of my actions. This sounds harmless, but the annoying thing is related to #18110 -- I have a lot of `sendInput` actions (mapping obscure key combos to escape sequences which my environment knows about), and I'm forced to add useless IDs to all of them. Looks like they're optional -- BUT -- if I drop them, then next time Terminal rewrites my settings, it blesses me with a fresh layer of IDs, and I now need to check the differences and re-remove them. Since this is tedious and error prone, I'm effectively forced to accept this and add IDs. Life becomes unnecessarily more verbose with IDs that I'll never need. ### Expected Behavior No IDs added for actions unless I already had an id for them. ### Actual Behavior IDs are always added.
claunia added the Issue-BugNeeds-Tag-FixNeeds-Author-FeedbackNo-Recent-Activity labels 2026-01-31 08:13:39 +00:00
claunia commented 2026-01-31 08:13:41 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Nov 18, 2024):

We know that this worsens the situation around #18110 and we're hoping to possibly remedy that in the future. To explain, if the settings model was a database, our intention was to "normalize" it, as we wanted multiple key bindings to be able to refer to the same action. In a sense, the action ID we're adding is a foreign key. For what it's worth, you can use arbitrary IDs that you choose yourself.

@lhecker commented on GitHub (Nov 18, 2024): We know that this worsens the situation around #18110 and we're hoping to possibly remedy that in the future. To explain, if the settings model was a database, our intention was to "normalize" it, as we wanted multiple key bindings to be able to refer to the same action. In a sense, the action ID we're adding is a foreign key. For what it's worth, you can use arbitrary IDs that you choose yourself.
claunia commented 2026-01-31 08:13:41 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (Nov 24, 2024):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (Nov 24, 2024): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**. <!-- Policy app identification https://img.shields.io/static/v1?label=PullRequestIssueManagement. -->
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Author-Feedback Needs-Tag-Fix No-Recent-Activity
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#22455
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?